You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Gerry Gao (JIRA)" <ax...@ws.apache.org> on 2005/06/20 04:55:30 UTC

[jira] Created: (AXIS-2064) The format of multi-cookie in HTTP request head.

The format of multi-cookie in HTTP request head.
------------------------------------------------

         Key: AXIS-2064
         URL: http://issues.apache.org/jira/browse/AXIS-2064
     Project: Apache Axis
        Type: Improvement
  Components: Basic Architecture  
    Versions: 1.2.1    
 Environment: Any platform
    Reporter: Gerry Gao


In Axis 1.2.1, the HTTPSender and CommonsHTTPSender are sending multiple cookies for the default format (multiple cookie headers):
    Cookie: a=a1
    Cookie: b=b2
    Cookie: c=c3
or
    Cookie2: a=a1
    Cookie2: b=b2
    Cookie2: c=c3

According to RFC2965, the multiple cookies should be baked with format (single cookie header):
    Cookie: a=a1;b=b2;c=c3

But in fact, most HTTP server supports the multiple cookie headers format. 
The CommonsHTTPSender employs commons-httpclient which already supports switch between the formats with a parameter like:
    DefaultHttpParams.getDefaultParams().setBooleanParameter(
       HttpMethodParams.SINGLE_COOKIE_HEADER,
       true);
(Reference: http://htmlunit.sourceforge.net/phpwiki/index.php/SingleCookieHeader)

But the HTTPSender doesn't support this kind of switch.

The suggestion is that Axis can add the feature of customizing the cookies' format and provide a parameter for wsdl2java or just provide a public method in Stub to let the user designate whihc cookie format should be used. Then make HTTPSender and CommonsHTTPSender (commons-httpclient) be aware of this parameter.

Gerry


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (AXIS-2064) The format of multi-cookie in HTTP request head.

Posted by "Tom Jordahl (JIRA)" <ax...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Jordahl resolved AXIS-2064.
-------------------------------

       Resolution: Fixed
    Fix Version/s: current (nightly)

Fix in SVN head of Axis 1.x tree, revision r511966.


> The format of multi-cookie in HTTP request head.
> ------------------------------------------------
>
>                 Key: AXIS-2064
>                 URL: https://issues.apache.org/jira/browse/AXIS-2064
>             Project: Axis
>          Issue Type: Improvement
>          Components: Basic Architecture
>    Affects Versions: 1.2.1, 1.3, 1.4
>         Environment: Any platform
>            Reporter: Gerry Gao
>            Priority: Blocker
>             Fix For: current (nightly)
>
>
> In Axis 1.2.1, the HTTPSender and CommonsHTTPSender are sending multiple cookies for the default format (multiple cookie headers):
>     Cookie: a=a1
>     Cookie: b=b2
>     Cookie: c=c3
> or
>     Cookie2: a=a1
>     Cookie2: b=b2
>     Cookie2: c=c3
> According to RFC2965, the multiple cookies should be baked with format (single cookie header):
>     Cookie: a=a1;b=b2;c=c3
> But in fact, most HTTP server supports the multiple cookie headers format. 
> The CommonsHTTPSender employs commons-httpclient which already supports switch between the formats with a parameter like:
>     DefaultHttpParams.getDefaultParams().setBooleanParameter(
>        HttpMethodParams.SINGLE_COOKIE_HEADER,
>        true);
> (Reference: http://htmlunit.sourceforge.net/phpwiki/index.php/SingleCookieHeader)
> But the HTTPSender doesn't support this kind of switch.
> The suggestion is that Axis can add the feature of customizing the cookies' format and provide a parameter for wsdl2java or just provide a public method in Stub to let the user designate whihc cookie format should be used. Then make HTTPSender and CommonsHTTPSender (commons-httpclient) be aware of this parameter.
> Gerry

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS-2064) The format of multi-cookie in HTTP request head.

Posted by "Amon Beckler (JIRA)" <ax...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462009 ] 

Amon Beckler commented on AXIS-2064:
------------------------------------

Given that we are now two "final" releases past when this bug and a potential patch was posted, am I to assume that this is not going to be fixed and will be left as is?

> The format of multi-cookie in HTTP request head.
> ------------------------------------------------
>
>                 Key: AXIS-2064
>                 URL: https://issues.apache.org/jira/browse/AXIS-2064
>             Project: Apache Axis
>          Issue Type: Improvement
>          Components: Basic Architecture
>    Affects Versions: 1.2.1
>         Environment: Any platform
>            Reporter: Gerry Gao
>
> In Axis 1.2.1, the HTTPSender and CommonsHTTPSender are sending multiple cookies for the default format (multiple cookie headers):
>     Cookie: a=a1
>     Cookie: b=b2
>     Cookie: c=c3
> or
>     Cookie2: a=a1
>     Cookie2: b=b2
>     Cookie2: c=c3
> According to RFC2965, the multiple cookies should be baked with format (single cookie header):
>     Cookie: a=a1;b=b2;c=c3
> But in fact, most HTTP server supports the multiple cookie headers format. 
> The CommonsHTTPSender employs commons-httpclient which already supports switch between the formats with a parameter like:
>     DefaultHttpParams.getDefaultParams().setBooleanParameter(
>        HttpMethodParams.SINGLE_COOKIE_HEADER,
>        true);
> (Reference: http://htmlunit.sourceforge.net/phpwiki/index.php/SingleCookieHeader)
> But the HTTPSender doesn't support this kind of switch.
> The suggestion is that Axis can add the feature of customizing the cookies' format and provide a parameter for wsdl2java or just provide a public method in Stub to let the user designate whihc cookie format should be used. Then make HTTPSender and CommonsHTTPSender (commons-httpclient) be aware of this parameter.
> Gerry

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS-2064) The format of multi-cookie in HTTP request head.

Posted by "Tom Jordahl (JIRA)" <ax...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Jordahl updated AXIS-2064:
------------------------------

             Priority: Blocker  (was: Major)
    Affects Version/s: 1.4
                       1.3

Add 1.3 and 1.4 to versions and update this to a blocker.
I will try to change the SVN head version of the file

> The format of multi-cookie in HTTP request head.
> ------------------------------------------------
>
>                 Key: AXIS-2064
>                 URL: https://issues.apache.org/jira/browse/AXIS-2064
>             Project: Axis
>          Issue Type: Improvement
>          Components: Basic Architecture
>    Affects Versions: 1.2.1, 1.3, 1.4
>         Environment: Any platform
>            Reporter: Gerry Gao
>            Priority: Blocker
>
> In Axis 1.2.1, the HTTPSender and CommonsHTTPSender are sending multiple cookies for the default format (multiple cookie headers):
>     Cookie: a=a1
>     Cookie: b=b2
>     Cookie: c=c3
> or
>     Cookie2: a=a1
>     Cookie2: b=b2
>     Cookie2: c=c3
> According to RFC2965, the multiple cookies should be baked with format (single cookie header):
>     Cookie: a=a1;b=b2;c=c3
> But in fact, most HTTP server supports the multiple cookie headers format. 
> The CommonsHTTPSender employs commons-httpclient which already supports switch between the formats with a parameter like:
>     DefaultHttpParams.getDefaultParams().setBooleanParameter(
>        HttpMethodParams.SINGLE_COOKIE_HEADER,
>        true);
> (Reference: http://htmlunit.sourceforge.net/phpwiki/index.php/SingleCookieHeader)
> But the HTTPSender doesn't support this kind of switch.
> The suggestion is that Axis can add the feature of customizing the cookies' format and provide a parameter for wsdl2java or just provide a public method in Stub to let the user designate whihc cookie format should be used. Then make HTTPSender and CommonsHTTPSender (commons-httpclient) be aware of this parameter.
> Gerry

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS-2064) The format of multi-cookie in HTTP request head.

Posted by "John Cherniavsky (JIRA)" <ax...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS-2064?page=comments#action_12315604 ] 

John Cherniavsky commented on AXIS-2064:
----------------------------------------

Here's a patch - it's worked great in my environment for a couple of weeks 

Starting at HTTPSender.java:534 using Axis 1.2.1 Final
----
            if (ck1 instanceof String[]) {
                String [] cookies = (String[]) ck1;
                otherHeaders.append(header).append(": ");
                for (int i=0;i<cookies.length;i++)
                {
                    // This is the old code-> addCookie(otherHeaders, header, cookies[i]);
                    /* Begin New Code */
			        // Append the cookie
                    otherHeaders.append(cookies[i]);
                    // Append a ';' if not the last cookie
                    if (i < cookies.length -1)
                       otherHeaders.append("; ");
                }
                otherHeaders.append("\r\n");
		    /* End New Code */
            } else {
                addCookie(otherHeaders, header, (String) ck1);
            }
-----

Thanks,
-John Cherniavsky


> The format of multi-cookie in HTTP request head.
> ------------------------------------------------
>
>          Key: AXIS-2064
>          URL: http://issues.apache.org/jira/browse/AXIS-2064
>      Project: Apache Axis
>         Type: Improvement
>   Components: Basic Architecture
>     Versions: 1.2.1
>  Environment: Any platform
>     Reporter: Gerry Gao

>
> In Axis 1.2.1, the HTTPSender and CommonsHTTPSender are sending multiple cookies for the default format (multiple cookie headers):
>     Cookie: a=a1
>     Cookie: b=b2
>     Cookie: c=c3
> or
>     Cookie2: a=a1
>     Cookie2: b=b2
>     Cookie2: c=c3
> According to RFC2965, the multiple cookies should be baked with format (single cookie header):
>     Cookie: a=a1;b=b2;c=c3
> But in fact, most HTTP server supports the multiple cookie headers format. 
> The CommonsHTTPSender employs commons-httpclient which already supports switch between the formats with a parameter like:
>     DefaultHttpParams.getDefaultParams().setBooleanParameter(
>        HttpMethodParams.SINGLE_COOKIE_HEADER,
>        true);
> (Reference: http://htmlunit.sourceforge.net/phpwiki/index.php/SingleCookieHeader)
> But the HTTPSender doesn't support this kind of switch.
> The suggestion is that Axis can add the feature of customizing the cookies' format and provide a parameter for wsdl2java or just provide a public method in Stub to let the user designate whihc cookie format should be used. Then make HTTPSender and CommonsHTTPSender (commons-httpclient) be aware of this parameter.
> Gerry

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (AXIS-2064) The format of multi-cookie in HTTP request head.

Posted by "Davanum Srinivas (JIRA)" <ax...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS-2064?page=comments#action_12315579 ] 

Davanum Srinivas commented on AXIS-2064:
----------------------------------------

Gerry,

my cycles are limited. could you help with a patch?

thanks,
dims

> The format of multi-cookie in HTTP request head.
> ------------------------------------------------
>
>          Key: AXIS-2064
>          URL: http://issues.apache.org/jira/browse/AXIS-2064
>      Project: Apache Axis
>         Type: Improvement
>   Components: Basic Architecture
>     Versions: 1.2.1
>  Environment: Any platform
>     Reporter: Gerry Gao

>
> In Axis 1.2.1, the HTTPSender and CommonsHTTPSender are sending multiple cookies for the default format (multiple cookie headers):
>     Cookie: a=a1
>     Cookie: b=b2
>     Cookie: c=c3
> or
>     Cookie2: a=a1
>     Cookie2: b=b2
>     Cookie2: c=c3
> According to RFC2965, the multiple cookies should be baked with format (single cookie header):
>     Cookie: a=a1;b=b2;c=c3
> But in fact, most HTTP server supports the multiple cookie headers format. 
> The CommonsHTTPSender employs commons-httpclient which already supports switch between the formats with a parameter like:
>     DefaultHttpParams.getDefaultParams().setBooleanParameter(
>        HttpMethodParams.SINGLE_COOKIE_HEADER,
>        true);
> (Reference: http://htmlunit.sourceforge.net/phpwiki/index.php/SingleCookieHeader)
> But the HTTPSender doesn't support this kind of switch.
> The suggestion is that Axis can add the feature of customizing the cookies' format and provide a parameter for wsdl2java or just provide a public method in Stub to let the user designate whihc cookie format should be used. Then make HTTPSender and CommonsHTTPSender (commons-httpclient) be aware of this parameter.
> Gerry

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira