[GitHub] [mynewt-core] kasjer commented on a change in pull request #1976: hw/mcu/dialog; add da1469x_flash_setup()

[GitBox <gi...@apache.org>]

kasjer commented on a change in pull request #1976: hw/mcu/dialog; add da1469x_flash_setup()
URL: https://github.com/apache/mynewt-core/pull/1976#discussion_r319821955
 
 

 ##########
 File path: hw/mcu/dialog/da1469x/src/hal_flash.c
 ##########
 @@ -307,6 +307,28 @@ da1469x_qspi_erase_sector(const struct hal_flash *dev, uint32_t sector_address)
     return 0;
 }
 
+void
+da1469x_flash_setup(const struct hal_flash *dev, uint32_t bursta,
+                    uint32_t burstb, uint8_t *cmds, int len)
+{
+    int i;
+
+    da1469x_qspi_mode_manual(NULL);
 
 Review comment:
   while da1469x_qspi_mode_manual does not use it's argument for now, it is strange to pass NULL while dev that is in this function is not used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services