You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Pavel Tupitsyn <pt...@apache.org> on 2018/02/20 08:48:38 UTC
Broken tests after IGNITE-7594 merge
Alexey, Ilya,
Recent merge of IGNITE-7594 has broken some tests in master,
AND in ignite-2.4 (which concerns me) [1] [2].
* Have you run the tests before merging your changes?
* Can you please fix this?
In particular, you'll have to update
the DataStorageConfiguration.DefaultWalMode on .NET side.
Thanks,
Pavel
[1]
https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=1c7b42285f27dbcb5bcc38fe3d7dee8aac5cb873
[2] https://ci.ignite.apache.org/viewLog.html?buildId=1102392
Re: Broken tests after IGNITE-7594 merge
Posted by Pavel Tupitsyn <pt...@apache.org>.
Merged to master, cherry-picked to ignite-2.4.
Thanks everyone!
On Wed, Feb 21, 2018 at 12:16 AM, Dmitry Pavlov <dp...@gmail.com>
wrote:
> Ilya, thank you from me too for such a fast issue resolution.
>
> Pavel, could you please merge this PR to master? Or please advice who else
> can?
>
> Anton V. could you help?
>
> вт, 20 февр. 2018 г. в 19:11, Pavel Tupitsyn <pt...@apache.org>:
>
> > Ilya, thanks for the fix, looks good to me.
> > Please make sure TC passes and merge.
> >
> > On Tue, Feb 20, 2018 at 6:08 PM, Dmitriy Pavlov <dp...@gridgain.com>
> > wrote:
> >
> > > Issue is not in 'patch available' state.
> > >
> > > On Tue, Feb 20, 2018 at 6:06 PM Ilya Lantukh <il...@gridgain.com>
> > > wrote:
> > >
> > >> Fixed, please review: https://issues.apache.org/
> jira/browse/IGNITE-7767
> > .
> > >>
> > >> On Tue, Feb 20, 2018 at 5:44 PM, Ilya Lantukh <il...@gridgain.com>
> > >> wrote:
> > >>
> > >>> Pavel,
> > >>>
> > >>> I've fixed default value for WALMode (https://github.com/apache/
> > >>> ignite/pull/3544), but now I have the following test failure:
> > >>> Apache.Ignite.Core.Tests.IgniteConfigurationTest.
> > >>> TestDefaultConfigurationProperties
> > >>>
> > >>> Expected: LogOnly
> > >>> But was: Fsync
> > >>>
> > >>> at NUnit.Framework.Assert.That(Object actual, IResolveConstraint
> > >>> expression, String message, Object[] args)
> > >>> at Apache.Ignite.Core.Tests.IgniteConfigurationTest.
> > >>> CheckDefaultProperties(DataStorageConfiguration cfg) in
> > >>> C:\Projects\ignite\modules\platforms\dotnet\Apache.
> Ignite.Core.Tests\
> > >>> IgniteConfigurationTest.cs:line 551
> > >>> at Apache.Ignite.Core.Tests.IgniteConfigurationTest.
> > >>> TestDefaultConfigurationProperties() in C:\Projects\ignite\modules\
> > >>>
> > platforms\dotnet\Apache.Ignite.Core.Tests\IgniteConfigurationTest.cs:
> line
> > >>> 68
> > >>>
> > >>> Could you please take a look and help us understand why did it
> happen?
> > >>>
> > >>> On Tue, Feb 20, 2018 at 4:48 PM, Pavel Tupitsyn <
> ptupitsyn@apache.org>
> > >>> wrote:
> > >>>
> > >>>> Ilya,
> > >>>>
> > >>>> Please see modules/platforms/dotnet/Apache.Ignite.Core/
> Configuration/
> > >>>> DataStorageConfiguration.cs:129,
> > >>>> should be changed to match default value in Java.
> > >>>>
> > >>>> Pavel
> > >>>>
> > >>>> On Tue, Feb 20, 2018 at 3:11 PM, Dmitry Pavlov <
> dpavlov.spb@gmail.com
> > >
> > >>>> wrote:
> > >>>>
> > >>>>> Hi Pavel,
> > >>>>>
> > >>>>> Thank you for pointing this out.
> > >>>>>
> > >>>>> Sincerely,
> > >>>>> Dmitry Pavlov
> > >>>>>
> > >>>>> вт, 20 февр. 2018 г. в 11:48, Pavel Tupitsyn <ptupitsyn@apache.org
> >:
> > >>>>>
> > >>>>> > Alexey, Ilya,
> > >>>>> >
> > >>>>> > Recent merge of IGNITE-7594 has broken some tests in master,
> > >>>>> > AND in ignite-2.4 (which concerns me) [1] [2].
> > >>>>> >
> > >>>>> > * Have you run the tests before merging your changes?
> > >>>>> > * Can you please fix this?
> > >>>>> >
> > >>>>> > In particular, you'll have to update
> > >>>>> > the DataStorageConfiguration.DefaultWalMode on .NET side.
> > >>>>> >
> > >>>>> > Thanks,
> > >>>>> > Pavel
> > >>>>> >
> > >>>>> >
> > >>>>> > [1]
> > >>>>> >
> > >>>>> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=
> > >>>>> 1c7b42285f27dbcb5bcc38fe3d7dee8aac5cb873
> > >>>>> >
> > >>>>> > [2] https://ci.ignite.apache.org/viewLog.html?buildId=1102392
> > >>>>> >
> > >>>>>
> > >>>>
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> Best regards,
> > >>> Ilya
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >> Best regards,
> > >> Ilya
> > >>
> > >
> >
>
Re: Broken tests after IGNITE-7594 merge
Posted by Dmitry Pavlov <dp...@gmail.com>.
Ilya, thank you from me too for such a fast issue resolution.
Pavel, could you please merge this PR to master? Or please advice who else
can?
Anton V. could you help?
вт, 20 февр. 2018 г. в 19:11, Pavel Tupitsyn <pt...@apache.org>:
> Ilya, thanks for the fix, looks good to me.
> Please make sure TC passes and merge.
>
> On Tue, Feb 20, 2018 at 6:08 PM, Dmitriy Pavlov <dp...@gridgain.com>
> wrote:
>
> > Issue is not in 'patch available' state.
> >
> > On Tue, Feb 20, 2018 at 6:06 PM Ilya Lantukh <il...@gridgain.com>
> > wrote:
> >
> >> Fixed, please review: https://issues.apache.org/jira/browse/IGNITE-7767
> .
> >>
> >> On Tue, Feb 20, 2018 at 5:44 PM, Ilya Lantukh <il...@gridgain.com>
> >> wrote:
> >>
> >>> Pavel,
> >>>
> >>> I've fixed default value for WALMode (https://github.com/apache/
> >>> ignite/pull/3544), but now I have the following test failure:
> >>> Apache.Ignite.Core.Tests.IgniteConfigurationTest.
> >>> TestDefaultConfigurationProperties
> >>>
> >>> Expected: LogOnly
> >>> But was: Fsync
> >>>
> >>> at NUnit.Framework.Assert.That(Object actual, IResolveConstraint
> >>> expression, String message, Object[] args)
> >>> at Apache.Ignite.Core.Tests.IgniteConfigurationTest.
> >>> CheckDefaultProperties(DataStorageConfiguration cfg) in
> >>> C:\Projects\ignite\modules\platforms\dotnet\Apache.Ignite.Core.Tests\
> >>> IgniteConfigurationTest.cs:line 551
> >>> at Apache.Ignite.Core.Tests.IgniteConfigurationTest.
> >>> TestDefaultConfigurationProperties() in C:\Projects\ignite\modules\
> >>>
> platforms\dotnet\Apache.Ignite.Core.Tests\IgniteConfigurationTest.cs:line
> >>> 68
> >>>
> >>> Could you please take a look and help us understand why did it happen?
> >>>
> >>> On Tue, Feb 20, 2018 at 4:48 PM, Pavel Tupitsyn <pt...@apache.org>
> >>> wrote:
> >>>
> >>>> Ilya,
> >>>>
> >>>> Please see modules/platforms/dotnet/Apache.Ignite.Core/Configuration/
> >>>> DataStorageConfiguration.cs:129,
> >>>> should be changed to match default value in Java.
> >>>>
> >>>> Pavel
> >>>>
> >>>> On Tue, Feb 20, 2018 at 3:11 PM, Dmitry Pavlov <dpavlov.spb@gmail.com
> >
> >>>> wrote:
> >>>>
> >>>>> Hi Pavel,
> >>>>>
> >>>>> Thank you for pointing this out.
> >>>>>
> >>>>> Sincerely,
> >>>>> Dmitry Pavlov
> >>>>>
> >>>>> вт, 20 февр. 2018 г. в 11:48, Pavel Tupitsyn <pt...@apache.org>:
> >>>>>
> >>>>> > Alexey, Ilya,
> >>>>> >
> >>>>> > Recent merge of IGNITE-7594 has broken some tests in master,
> >>>>> > AND in ignite-2.4 (which concerns me) [1] [2].
> >>>>> >
> >>>>> > * Have you run the tests before merging your changes?
> >>>>> > * Can you please fix this?
> >>>>> >
> >>>>> > In particular, you'll have to update
> >>>>> > the DataStorageConfiguration.DefaultWalMode on .NET side.
> >>>>> >
> >>>>> > Thanks,
> >>>>> > Pavel
> >>>>> >
> >>>>> >
> >>>>> > [1]
> >>>>> >
> >>>>> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=
> >>>>> 1c7b42285f27dbcb5bcc38fe3d7dee8aac5cb873
> >>>>> >
> >>>>> > [2] https://ci.ignite.apache.org/viewLog.html?buildId=1102392
> >>>>> >
> >>>>>
> >>>>
> >>>>
> >>>
> >>>
> >>> --
> >>> Best regards,
> >>> Ilya
> >>>
> >>
> >>
> >>
> >> --
> >> Best regards,
> >> Ilya
> >>
> >
>
Re: Broken tests after IGNITE-7594 merge
Posted by Pavel Tupitsyn <pt...@apache.org>.
Ilya, thanks for the fix, looks good to me.
Please make sure TC passes and merge.
On Tue, Feb 20, 2018 at 6:08 PM, Dmitriy Pavlov <dp...@gridgain.com>
wrote:
> Issue is not in 'patch available' state.
>
> On Tue, Feb 20, 2018 at 6:06 PM Ilya Lantukh <il...@gridgain.com>
> wrote:
>
>> Fixed, please review: https://issues.apache.org/jira/browse/IGNITE-7767.
>>
>> On Tue, Feb 20, 2018 at 5:44 PM, Ilya Lantukh <il...@gridgain.com>
>> wrote:
>>
>>> Pavel,
>>>
>>> I've fixed default value for WALMode (https://github.com/apache/
>>> ignite/pull/3544), but now I have the following test failure:
>>> Apache.Ignite.Core.Tests.IgniteConfigurationTest.
>>> TestDefaultConfigurationProperties
>>>
>>> Expected: LogOnly
>>> But was: Fsync
>>>
>>> at NUnit.Framework.Assert.That(Object actual, IResolveConstraint
>>> expression, String message, Object[] args)
>>> at Apache.Ignite.Core.Tests.IgniteConfigurationTest.
>>> CheckDefaultProperties(DataStorageConfiguration cfg) in
>>> C:\Projects\ignite\modules\platforms\dotnet\Apache.Ignite.Core.Tests\
>>> IgniteConfigurationTest.cs:line 551
>>> at Apache.Ignite.Core.Tests.IgniteConfigurationTest.
>>> TestDefaultConfigurationProperties() in C:\Projects\ignite\modules\
>>> platforms\dotnet\Apache.Ignite.Core.Tests\IgniteConfigurationTest.cs:line
>>> 68
>>>
>>> Could you please take a look and help us understand why did it happen?
>>>
>>> On Tue, Feb 20, 2018 at 4:48 PM, Pavel Tupitsyn <pt...@apache.org>
>>> wrote:
>>>
>>>> Ilya,
>>>>
>>>> Please see modules/platforms/dotnet/Apache.Ignite.Core/Configuration/
>>>> DataStorageConfiguration.cs:129,
>>>> should be changed to match default value in Java.
>>>>
>>>> Pavel
>>>>
>>>> On Tue, Feb 20, 2018 at 3:11 PM, Dmitry Pavlov <dp...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi Pavel,
>>>>>
>>>>> Thank you for pointing this out.
>>>>>
>>>>> Sincerely,
>>>>> Dmitry Pavlov
>>>>>
>>>>> вт, 20 февр. 2018 г. в 11:48, Pavel Tupitsyn <pt...@apache.org>:
>>>>>
>>>>> > Alexey, Ilya,
>>>>> >
>>>>> > Recent merge of IGNITE-7594 has broken some tests in master,
>>>>> > AND in ignite-2.4 (which concerns me) [1] [2].
>>>>> >
>>>>> > * Have you run the tests before merging your changes?
>>>>> > * Can you please fix this?
>>>>> >
>>>>> > In particular, you'll have to update
>>>>> > the DataStorageConfiguration.DefaultWalMode on .NET side.
>>>>> >
>>>>> > Thanks,
>>>>> > Pavel
>>>>> >
>>>>> >
>>>>> > [1]
>>>>> >
>>>>> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=
>>>>> 1c7b42285f27dbcb5bcc38fe3d7dee8aac5cb873
>>>>> >
>>>>> > [2] https://ci.ignite.apache.org/viewLog.html?buildId=1102392
>>>>> >
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Best regards,
>>> Ilya
>>>
>>
>>
>>
>> --
>> Best regards,
>> Ilya
>>
>
Re: Broken tests after IGNITE-7594 merge
Posted by Pavel Tupitsyn <pt...@apache.org>.
Ilya,
Please see
modules/platforms/dotnet/Apache.Ignite.Core/Configuration/DataStorageConfiguration.cs:129,
should be changed to match default value in Java.
Pavel
On Tue, Feb 20, 2018 at 3:11 PM, Dmitry Pavlov <dp...@gmail.com>
wrote:
> Hi Pavel,
>
> Thank you for pointing this out.
>
> Sincerely,
> Dmitry Pavlov
>
> вт, 20 февр. 2018 г. в 11:48, Pavel Tupitsyn <pt...@apache.org>:
>
> > Alexey, Ilya,
> >
> > Recent merge of IGNITE-7594 has broken some tests in master,
> > AND in ignite-2.4 (which concerns me) [1] [2].
> >
> > * Have you run the tests before merging your changes?
> > * Can you please fix this?
> >
> > In particular, you'll have to update
> > the DataStorageConfiguration.DefaultWalMode on .NET side.
> >
> > Thanks,
> > Pavel
> >
> >
> > [1]
> >
> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=
> 1c7b42285f27dbcb5bcc38fe3d7dee8aac5cb873
> >
> > [2] https://ci.ignite.apache.org/viewLog.html?buildId=1102392
> >
>
Re: Broken tests after IGNITE-7594 merge
Posted by Dmitry Pavlov <dp...@gmail.com>.
Hi Pavel,
Thank you for pointing this out.
Sincerely,
Dmitry Pavlov
вт, 20 февр. 2018 г. в 11:48, Pavel Tupitsyn <pt...@apache.org>:
> Alexey, Ilya,
>
> Recent merge of IGNITE-7594 has broken some tests in master,
> AND in ignite-2.4 (which concerns me) [1] [2].
>
> * Have you run the tests before merging your changes?
> * Can you please fix this?
>
> In particular, you'll have to update
> the DataStorageConfiguration.DefaultWalMode on .NET side.
>
> Thanks,
> Pavel
>
>
> [1]
>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=1c7b42285f27dbcb5bcc38fe3d7dee8aac5cb873
>
> [2] https://ci.ignite.apache.org/viewLog.html?buildId=1102392
>