You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/09 18:40:54 UTC
[GitHub] [kafka] lqxshay opened a new pull request, #13097: Draft: only wipe state store under EOS regardless of state
lqxshay opened a new pull request, #13097:
URL: https://github.com/apache/kafka/pull/13097
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lucasbru commented on pull request #13097: [Draft] KAFKA-10532: close clean for EOS when it's RUNNING standby or RESTORING active
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #13097:
URL: https://github.com/apache/kafka/pull/13097#issuecomment-1477637108
> 2. streams exception: translated from kafka exception from restore consumer's other calls, as well as the restore callback)
`InvalidOffsetException` is rethrown as `StreamsException` in `prepareChangelogs` and `hasRestoredToEnd`. That seems to violate your categorization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on a diff in pull request #13097: [Draft] KAFKA-10532: close clean for EOS when it's RUNNING standby or RESTORING active
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on code in PR #13097:
URL: https://github.com/apache/kafka/pull/13097#discussion_r1132707585
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java:
##########
@@ -276,6 +276,11 @@ private void close(final boolean clean) {
transitionTo(State.CLOSED);
}
+ @Override
+ boolean shouldWipeStateStore(final boolean closeClean, final boolean eosEnabled, final boolean suspendedFromRestoring) {
+ return closeClean;
Review Comment:
Hmm.. not sure if this is correct, let me think through this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13097: [Draft] KAFKA-10532: close clean for EOS when it's RUNNING standby or RESTORING active
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13097:
URL: https://github.com/apache/kafka/pull/13097#issuecomment-1601966180
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rishiraj88 commented on pull request #13097: Draft: only wipe state store under EOS regardless of state
Posted by GitBox <gi...@apache.org>.
rishiraj88 commented on PR #13097:
URL: https://github.com/apache/kafka/pull/13097#issuecomment-1376384331
@lqxshay , thanks for for the helpful checklist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lqxshay commented on pull request #13097: Draft: close clean for EOS when it's RUNNING standby or RESTORING active
Posted by "lqxshay (via GitHub)" <gi...@apache.org>.
lqxshay commented on PR #13097:
URL: https://github.com/apache/kafka/pull/13097#issuecomment-1447390999
@guozhangwang Apologies for the delayed response here.
Thanks for the explanation. To put it in another way, as long as the task is in certain states(RESTORING active, RUNNING standby task), we would always close clean. I've updated the PR to disregard PendingUpdateAction.Action.CLOSE_DIRTY for the condition in `TaskManager#handlRemovedTasksFromStateUpdater` and `TaskManager#handleRestoredTasksFromStateUpdater`.
Could you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org