You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/05/04 17:54:28 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6017: NIFI-9988 Correct Property Decryption for Authorizers and Providers

exceptionfactory opened a new pull request, #6017:
URL: https://github.com/apache/nifi/pull/6017

   # Summary
   
   [NIFI-9988](https://issues.apache.org/jira/browse/NIFI-9988) Corrects Sensitive Property Provider decryption for encrypted property values in `authorizers.xml` and `login-identity-providers.xml`.
   
   Refactoring Sensitive Property Providers to use isolated class-loading for NIFI-9883 involved changes to the configuration classes for Authorizers and Login Identity Providers, leveraging the `ProtectionSchemeResolver` to determine the Protection Scheme based on the value of the `encryption` attribute, such as `aes/gcm/256`.
   
   The `StandardProtectionSchemeResolver` worked with the encrypt-config command, which specifies the scheme using one of the known enumerated values, but did not work with the Authorizers or Login Identity Providers configurations, which used the path value. Updating the `StandardProtectionSchemeResolver` to support resolution based on either the Name or the Path prefix resolves the problem.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6017: NIFI-9988 Correct Property Decryption for Authorizers and Providers

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6017:
URL: https://github.com/apache/nifi/pull/6017#issuecomment-1117721257

   So with main branch I ran into:
   `Caused by: org.apache.nifi.properties.SensitivePropertyProtectionException: Protection Scheme [aes/gcm/256] not supported`
   
   and now with this PR it appears fixed.
   
   +1 will merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog commented on pull request #6017: NIFI-9988 Correct Property Decryption for Authorizers and Providers

Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6017:
URL: https://github.com/apache/nifi/pull/6017#issuecomment-1117669230

   Reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] thenatog closed pull request #6017: NIFI-9988 Correct Property Decryption for Authorizers and Providers

Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6017: NIFI-9988 Correct Property Decryption for Authorizers and Providers
URL: https://github.com/apache/nifi/pull/6017


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org