You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/16 13:04:52 UTC
[GitHub] [pulsar] labuladong opened a new issue, #18060: [Doc] mistakes in `Subscription Type` section
labuladong opened a new issue, #18060:
URL: https://github.com/apache/pulsar/issues/18060
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### What issue do you find in Pulsar docs?
After #17991, the [subscription-types](https://pulsar.apache.org/docs/next/concepts-messaging#subscription-types) content doesn't match SVG images. For example:
<img width="1157" alt="image" src="https://user-images.githubusercontent.com/37220920/196036661-30f60365-88d0-44bf-97f9-2049db28c2d2.png">
### What is your suggestion?
Modify content to match images.
### Any reference?
_No response_
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on issue #18060: [Doc] mistakes in `Subscription Type` section
Posted by GitBox <gi...@apache.org>.
labuladong commented on issue #18060:
URL: https://github.com/apache/pulsar/issues/18060#issuecomment-1282013325
There are some other questions:
#### 1. I notice that https://github.com/apache/pulsar/pull/17863#issuecomment-1265458658 update this image:
But this image wasn't uploaded in https://github.com/apache/pulsar/pull/17991, we may upload this image and deploy it on the site.
#### 2. I think the gray block means this consumer is a _master_ consumer in [failover type](https://pulsar.apache.org//docs/next/concepts-messaging#failover):
But what does this gray block mean in [shared type](https://pulsar.apache.org//docs/next/concepts-messaging#shared)?
<img width="1132" alt="image" src="https://user-images.githubusercontent.com/37220920/196376537-22f37c24-2a70-4d44-b665-4a2505bf2132.png">
I suggest removing this gray block in [shared type](https://pulsar.apache.org//docs/next/concepts-messaging#shared) and [key shard type](https://pulsar.apache.org//docs/next/concepts-messaging#key_shared).
cc @DaveDuggins @momo-jun @tisonkun @Anonymitaet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed issue #18060: [Doc] mistakes in `Subscription Type` section
Posted by GitBox <gi...@apache.org>.
Technoboy- closed issue #18060: [Doc] mistakes in `Subscription Type` section
URL: https://github.com/apache/pulsar/issues/18060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org