You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/06/07 00:24:30 UTC

[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #585: MINIFICPP-910 - Extend StringUtils with string join capability

phrocker commented on a change in pull request #585: MINIFICPP-910 - Extend StringUtils with string join capability
URL: https://github.com/apache/nifi-minifi-cpp/pull/585#discussion_r291417988
 
 

 ##########
 File path: libminifi/src/utils/StringUtils.cpp
 ##########
 @@ -0,0 +1,162 @@
+/**
 
 Review comment:
   hmm, can we minimize those changes? Like the idea but it seems that there is scope creep. Is there an actual motivation behind another ticket for which this is necessary? I think I'm -1 on general cleanup until the follow on release since we have so much to test in this release. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services