You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Vincent Hennebert <vi...@anyware-tech.com> on 2007/03/23 12:30:02 UTC
Re: svn commit: r521640 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/table/ColumnSetup.java
test/layoutengine/standard-testcases/table-column_missing.xml
Jeremias,
> Author: jeremias
> Date: Fri Mar 23 02:19:04 2007
> New Revision: 521640
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=521640
> Log:
> Avoid an IndexOutOfBoundsException when more columns are used than are specified even though this is illegal with fixed table layout.
What about our recent discussion on this topic?
http://mail-archives.apache.org/mod_mbox/xmlgraphics-fop-dev/200703.mbox/%3c25DAA610-A141-4D57-9466-2B9B5F583C66@pandora.be%3e
In the testcase you provided we would then rather raise a validation
exception.
Vincent
Re: svn commit: r521640 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/table/ColumnSetup.java test/layoutengine/standard-testcases/table-column_missing.xml
Posted by Andreas L Delmelle <a_...@pandora.be>.
On Mar 23, 2007, at 13:49, Vincent Hennebert wrote:
> <snip /> We would then have two methods of iterating
> over tables: one fast, memory-efficient relying on columns
> specifications,
Slight addition: "... relying on column specifications or, if those
are absent, on cells in the first row."
This is enough to support fixed-layout.
Cheers,
Andreas
Re: svn commit: r521640 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/table/ColumnSetup.java
test/layoutengine/standard-testcases/table-column_missing.xml
Posted by Vincent Hennebert <vi...@anyware-tech.com>.
Jeremias Maerki a écrit :
> Sorry, I wasn't aware of that. I have trouble keeping up lately.
That's ok, just wanted to be sure we were on the same track.
> I guess you're welcome to throw a ValidationException when strict
> validation is on and fixed table layout is in use.
Something like that, yes. We would then have two methods of iterating
over tables: one fast, memory-efficient relying on columns
specifications, and one slow, memory-consuming parsing the entire table
before doing anything else.
Vincent
>
> On 23.03.2007 12:30:02 Vincent Hennebert wrote:
>> Jeremias,
>>
>>> Author: jeremias
>>> Date: Fri Mar 23 02:19:04 2007
>>> New Revision: 521640
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=521640
>>> Log:
>>> Avoid an IndexOutOfBoundsException when more columns are used than are specified even though this is illegal with fixed table layout.
>> What about our recent discussion on this topic?
>> http://mail-archives.apache.org/mod_mbox/xmlgraphics-fop-dev/200703.mbox/%3c25DAA610-A141-4D57-9466-2B9B5F583C66@pandora.be%3e
>>
>> In the testcase you provided we would then rather raise a validation
>> exception.
>>
>> Vincent
>
>
>
> Jeremias Maerki
>
Re: svn commit: r521640 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/table/ColumnSetup.java test/layoutengine/standard-testcases/table-column_missing.xml
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Sorry, I wasn't aware of that. I have trouble keeping up lately.
I guess you're welcome to throw a ValidationException when strict
validation is on and fixed table layout is in use.
On 23.03.2007 12:30:02 Vincent Hennebert wrote:
> Jeremias,
>
> > Author: jeremias
> > Date: Fri Mar 23 02:19:04 2007
> > New Revision: 521640
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=521640
> > Log:
> > Avoid an IndexOutOfBoundsException when more columns are used than are specified even though this is illegal with fixed table layout.
>
> What about our recent discussion on this topic?
> http://mail-archives.apache.org/mod_mbox/xmlgraphics-fop-dev/200703.mbox/%3c25DAA610-A141-4D57-9466-2B9B5F583C66@pandora.be%3e
>
> In the testcase you provided we would then rather raise a validation
> exception.
>
> Vincent
Jeremias Maerki