You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "harishtheking (via GitHub)" <gi...@apache.org> on 2026/03/15 08:58:55 UTC
[PR] Optimize get_dag_runs endpoint query [airflow]
harishtheking opened a new pull request, #63627:
URL: https://github.com/apache/airflow/pull/63627
This PR optimizes the `get_dag_runs` API endpoint by limiting the columns loaded from the `DagRun` model using SQLAlchemy `load_only`.
Previously the query loaded the full DagRun model which could result in unnecessary data being fetched.
This change improves query efficiency while keeping existing eager loading behavior intact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize get_dag_runs endpoint query [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #63627:
URL: https://github.com/apache/airflow/pull/63627#discussion_r2936624866
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -387,7 +387,19 @@ def get_dag_runs(
This endpoint allows specifying `~` as the dag_id to retrieve Dag Runs for all DAGs.
"""
- query = select(DagRun).options(*eager_load_dag_run_for_validation())
+ query = select(DagRun).options(
+ load_only(
Review Comment:
Why did you think other columns are unnecessary to return to user?
We are populating and returning all these to user.
https://github.com/apache/airflow/blob/b93d3798cf4b4561c84900ae4821837294e03d07/airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py#L64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize get_dag_runs endpoint query [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #63627:
URL: https://github.com/apache/airflow/pull/63627#issuecomment-4064117978
@harishtheking This PR has a few issues that need to be addressed before it can be reviewed — please see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
**Issues found:**
- :warning: **Unresolved review comments**: This PR has 1 unresolved review thread from maintainers: **@bugraoz93** (MEMBER): 1 unresolved thread. Please review and resolve all inline review comments before requesting another review. You can resolve a conversation by clicking 'Resolve conversation' on each thread after addressing the feedback. See [pull request guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst).
> **Note:** Your branch is **51 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.
**What to do next:**
- The comment informs you what you need to do.
- Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
- There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
- Maintainers will then proceed with a normal review.
There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize get_dag_runs endpoint query [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #63627: Optimize get_dag_runs endpoint query
URL: https://github.com/apache/airflow/pull/63627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize get_dag_runs endpoint query [airflow]
Posted by "harishtheking (via GitHub)" <gi...@apache.org>.
harishtheking commented on code in PR #63627:
URL: https://github.com/apache/airflow/pull/63627#discussion_r2943510609
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -387,7 +387,19 @@ def get_dag_runs(
This endpoint allows specifying `~` as the dag_id to retrieve Dag Runs for all DAGs.
"""
- query = select(DagRun).options(*eager_load_dag_run_for_validation())
+ query = select(DagRun).options(
+ load_only(
Review Comment:
Thank you for the feedback!
My intention was to reduce unnecessary database loading for the list endpoint by limiting the selected columns. However, I see that the API response model (`DAGRunResponse`) expects all fields from `DagRun`, so restricting the columns could potentially break the response.
I will take another look at the implementation and adjust the approach to ensure compatibility with the response model. Thank you for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize get_dag_runs endpoint query [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #63627:
URL: https://github.com/apache/airflow/pull/63627#issuecomment-4062601642
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize get_dag_runs endpoint query [airflow]
Posted by "harishtheking (via GitHub)" <gi...@apache.org>.
harishtheking commented on PR #63627:
URL: https://github.com/apache/airflow/pull/63627#issuecomment-4071398431
Thanks for the feedback! I reverted the column restriction to maintain compatibility with the DAGRunResponse model and rebased the branch on the latest main. Please let me know if further changes are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org