[GitHub] cjolivier01 commented on a change in pull request #9958: Parallelization for ROIpooling OP

[GitBox <gi...@apache.org>]

cjolivier01 commented on a change in pull request #9958: Parallelization for ROIpooling OP
URL: https://github.com/apache/incubator-mxnet/pull/9958#discussion_r171770240
 
 

 ##########
 File path: src/operator/roi_pooling.cc
 ##########
 @@ -74,7 +76,13 @@ inline void ROIPoolForward(const Tensor<cpu, 4, Dtype> &out,
 
     const Dtype* batch_data = bottom_data + data_size * roi_batch_ind;
 
+    #pragma omp parallel for firstprivate(batch_data, top_data, argmax_data)
     for (int c = 0; c < channels_; ++c) {
+      // Increment all data pointers
+      batch_data += c * data.size(2) * data.size(3);
 
 Review comment:
   if you do that, you can just keep adding that number each pass of c and then you don?t need to do a multiple for these at all

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services