You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/25 22:29:07 UTC

[GitHub] [druid] clintropolis commented on a change in pull request #10791: Run integration tests in a second stage

clintropolis commented on a change in pull request #10791:
URL: https://github.com/apache/druid/pull/10791#discussion_r564083590



##########
File path: .travis.yml
##########
@@ -46,6 +45,7 @@ install: MAVEN_OPTS='-Xmx3000m' travis_wait 15 ${MVN} clean install -q -ff ${MAV
 stages:
   - name: test  # jobs that do not specify a stage get this default value
     if: type != cron
+  - name: it

Review comment:
       nit: should we call this 'integration-tests' or something so it looks a bit more descriptive on web stuffs?
   <img width="1231" alt="Screen Shot 2021-01-25 at 2 20 45 PM" src="https://user-images.githubusercontent.com/1577461/105773297-8929bd80-5f18-11eb-84b4-8821a66f4b5f.png">
   
   although I do kind of like it like this too, so I'm +1 on this PR either way




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org