You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/26 18:11:23 UTC

[GitHub] [superset] eschutho commented on a change in pull request #14849: fix: DatabaseConnection Modal Margin Bottom

eschutho commented on a change in pull request #14849:
URL: https://github.com/apache/superset/pull/14849#discussion_r640010833



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
##########
@@ -81,7 +81,6 @@ export const antDModalNoPaddingStyles = css`
   .ant-modal-body {
     padding-left: 0;
     padding-right: 0;
-    margin-bottom: 110px;

Review comment:
       I think we still want this margin just for the sqlalchemy view.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org