You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by an...@apache.org on 2015/08/14 22:44:42 UTC
spark git commit: [SPARK-9877] [CORE] Fix StandaloneRestServer NPE
when submitting application
Repository: spark
Updated Branches:
refs/heads/master 6518ef630 -> 9407baa2a
[SPARK-9877] [CORE] Fix StandaloneRestServer NPE when submitting application
Detailed exception log can be seen in [SPARK-9877](https://issues.apache.org/jira/browse/SPARK-9877), the problem is when creating `StandaloneRestServer`, `self` (`masterEndpoint`) is null. So this fix is creating `StandaloneRestServer` when `self` is available.
Author: jerryshao <ss...@hortonworks.com>
Closes #8127 from jerryshao/SPARK-9877.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/9407baa2
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/9407baa2
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/9407baa2
Branch: refs/heads/master
Commit: 9407baa2a7c26f527f2d043715d313d75bd765bb
Parents: 6518ef6
Author: jerryshao <ss...@hortonworks.com>
Authored: Fri Aug 14 13:44:38 2015 -0700
Committer: Andrew Or <an...@databricks.com>
Committed: Fri Aug 14 13:44:38 2015 -0700
----------------------------------------------------------------------
.../org/apache/spark/deploy/master/Master.scala | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/9407baa2/core/src/main/scala/org/apache/spark/deploy/master/Master.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/deploy/master/Master.scala b/core/src/main/scala/org/apache/spark/deploy/master/Master.scala
index 9217202..26904d3 100644
--- a/core/src/main/scala/org/apache/spark/deploy/master/Master.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/master/Master.scala
@@ -127,14 +127,8 @@ private[deploy] class Master(
// Alternative application submission gateway that is stable across Spark versions
private val restServerEnabled = conf.getBoolean("spark.master.rest.enabled", true)
- private val restServer =
- if (restServerEnabled) {
- val port = conf.getInt("spark.master.rest.port", 6066)
- Some(new StandaloneRestServer(address.host, port, conf, self, masterUrl))
- } else {
- None
- }
- private val restServerBoundPort = restServer.map(_.start())
+ private var restServer: Option[StandaloneRestServer] = None
+ private var restServerBoundPort: Option[Int] = None
override def onStart(): Unit = {
logInfo("Starting Spark master at " + masterUrl)
@@ -148,6 +142,12 @@ private[deploy] class Master(
}
}, 0, WORKER_TIMEOUT_MS, TimeUnit.MILLISECONDS)
+ if (restServerEnabled) {
+ val port = conf.getInt("spark.master.rest.port", 6066)
+ restServer = Some(new StandaloneRestServer(address.host, port, conf, self, masterUrl))
+ }
+ restServerBoundPort = restServer.map(_.start())
+
masterMetricsSystem.registerSource(masterSource)
masterMetricsSystem.start()
applicationMetricsSystem.start()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org