You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/11 18:39:24 UTC
[GitHub] [superset] duynguyenhoang opened a new pull request #12417: fix(viz dist_bar): Preserve Column Order in Bar chart
duynguyenhoang opened a new pull request #12417:
URL: https://github.com/apache/superset/pull/12417
### SUMMARY
Reindex pivot table by using metric columns
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Create metrics with different name and re-order them, the column in bar chart should reflect those orders
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #12416
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (6b3e02f) into [master](https://codecov.io/gh/apache/superset/commit/0de61df72f58db957891abd10c9eb5c9110a9572?el=desc) (0de61df) will **decrease** coverage by `0.33%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.85% 66.52% -0.34%
==========================================
Files 1018 1018
Lines 49776 49763 -13
Branches 4869 4869
==========================================
- Hits 33280 33105 -175
- Misses 16373 16535 +162
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.95% <ø> (ø)` | |
| javascript | `60.93% <ø> (ø)` | |
| python | `63.46% <50.00%> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [0de61df...d1b02f8](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (edaa807) into [master](https://codecov.io/gh/apache/superset/commit/10c2b09942179cbef2b73bfbd920cfc878de9fab?el=desc) (10c2b09) will **decrease** coverage by `4.08%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.79% 62.71% -4.09%
==========================================
Files 1015 1018 +3
Lines 49673 49759 +86
Branches 4845 4869 +24
==========================================
- Hits 33179 31204 -1975
- Misses 16372 18357 +1985
- Partials 122 198 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.93% <ø> (+0.18%)` | :arrow_up: |
| python | `63.87% <50.00%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [201 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [10c2b09...edaa807](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12417: fix(explore): Preserve Column Order in Bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (ca1393a) into [master](https://codecov.io/gh/apache/superset/commit/4cf3f99ee881a10995212828494f0b126dd5415e?el=desc) (4cf3f99) will **decrease** coverage by `3.48%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.79% 63.30% -3.49%
==========================================
Files 1014 485 -529
Lines 49524 29886 -19638
Branches 5077 0 -5077
==========================================
- Hits 33079 18920 -14159
+ Misses 16314 10966 -5348
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.30% <50.00%> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.00% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [550 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [4cf3f99...ca1393a](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (edaa807) into [master](https://codecov.io/gh/apache/superset/commit/10c2b09942179cbef2b73bfbd920cfc878de9fab?el=desc) (10c2b09) will **decrease** coverage by `4.31%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.79% 62.47% -4.32%
==========================================
Files 1015 1018 +3
Lines 49673 49759 +86
Branches 4845 4869 +24
==========================================
- Hits 33179 31088 -2091
- Misses 16372 18473 +2101
- Partials 122 198 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.93% <ø> (+0.18%)` | :arrow_up: |
| python | `63.49% <50.00%> (-0.51%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [204 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [10c2b09...edaa807](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): Preserve Column Order in Bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (ca1393a) into [master](https://codecov.io/gh/apache/superset/commit/4cf3f99ee881a10995212828494f0b126dd5415e?el=desc) (4cf3f99) will **decrease** coverage by `3.49%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.79% 63.29% -3.50%
==========================================
Files 1014 485 -529
Lines 49524 29901 -19623
Branches 5077 0 -5077
==========================================
- Hits 33079 18927 -14152
+ Misses 16314 10974 -5340
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.29% <50.00%> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.00% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [543 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [4cf3f99...ca1393a](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): Preserve Column Order in Bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (032f83b) into [master](https://codecov.io/gh/apache/superset/commit/10c2b09942179cbef2b73bfbd920cfc878de9fab?el=desc) (10c2b09) will **decrease** coverage by `3.59%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.79% 63.19% -3.60%
==========================================
Files 1015 486 -529
Lines 49673 29984 -19689
Branches 4845 0 -4845
==========================================
- Hits 33179 18949 -14230
+ Misses 16372 11035 -5337
+ Partials 122 0 -122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.19% <50.00%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [541 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [10c2b09...032f83b](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): Preserve Column Order in Bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (ca1393a) into [master](https://codecov.io/gh/apache/superset/commit/4cf3f99ee881a10995212828494f0b126dd5415e?el=desc) (4cf3f99) will **decrease** coverage by `3.48%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.79% 63.30% -3.49%
==========================================
Files 1014 485 -529
Lines 49524 29886 -19638
Branches 5077 0 -5077
==========================================
- Hits 33079 18920 -14159
+ Misses 16314 10966 -5348
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.30% <50.00%> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.00% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [550 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [4cf3f99...ca1393a](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12417:
URL: https://github.com/apache/superset/pull/12417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] duynguyenhoang edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
duynguyenhoang edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-764843417
@villebro Update to f-strings and formatted viz_test using black.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (d1b02f8) into [master](https://codecov.io/gh/apache/superset/commit/0de61df72f58db957891abd10c9eb5c9110a9572?el=desc) (0de61df) will **decrease** coverage by `3.58%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.85% 63.27% -3.59%
==========================================
Files 1018 486 -532
Lines 49776 29984 -19792
Branches 4869 0 -4869
==========================================
- Hits 33280 18972 -14308
+ Misses 16373 11012 -5361
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.27% <50.00%> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [546 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [0de61df...d1b02f8](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (edaa807) into [master](https://codecov.io/gh/apache/superset/commit/10c2b09942179cbef2b73bfbd920cfc878de9fab?el=desc) (10c2b09) will **decrease** coverage by `4.36%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.79% 62.42% -4.37%
==========================================
Files 1015 1018 +3
Lines 49673 49744 +71
Branches 4845 4869 +24
==========================================
- Hits 33179 31055 -2124
- Misses 16372 18491 +2119
- Partials 122 198 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.93% <ø> (+0.18%)` | :arrow_up: |
| python | `63.41% <50.00%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [218 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [10c2b09...edaa807](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] duynguyenhoang commented on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
duynguyenhoang commented on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-764843417
@villebro Update to f-strings and formated viz_test using black.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (d1b02f8) into [master](https://codecov.io/gh/apache/superset/commit/0de61df72f58db957891abd10c9eb5c9110a9572?el=desc) (0de61df) will **decrease** coverage by `3.58%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.85% 63.27% -3.59%
==========================================
Files 1018 486 -532
Lines 49776 29986 -19790
Branches 4869 0 -4869
==========================================
- Hits 33280 18974 -14306
+ Misses 16373 11012 -5361
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.27% <50.00%> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [0de61df...d1b02f8](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] PowerPlop commented on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
PowerPlop commented on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-921738490
@junlincc @duynguyenhoang it seems that this order is not respected in the time series bar chart. Is this expected behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #12417: fix(explore): Preserve Column Order in Bar chart
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12417:
URL: https://github.com/apache/superset/pull/12417#discussion_r561699562
##########
File path: tests/viz_tests.py
##########
@@ -531,6 +531,92 @@ def test_column_nulls(self):
]
self.assertEqual(expected, data)
+ def test_column_metrics_in_order(self):
+ form_data = {
+ "metrics": ["z_column", "votes", "a_column"],
+ "adhoc_filters": [],
+ "groupby": ["toppings"],
+ "columns": [],
+ }
+ datasource = self.get_datasource_mock()
+ df = pd.DataFrame(
+ {
+ "toppings": ["cheese", "pepperoni", "cheese", "pepperoni"],
+ "role": ["engineer", "engineer", None, None],
+ "votes": [3, 5, 1, 2],
+ "a_column": [3, 5, 1, 2],
+ "z_column": [3, 5, 1, 2],
+ }
+ )
+ test_viz = viz.DistributionBarViz(datasource, form_data)
+ data = test_viz.get_data(df)
+
+ expected = [
+ {
+ "key": "z_column",
+ "values": [{"x": "pepperoni", "y": 3.5}, {"x": "cheese", "y": 2.0}],
+ },
+ {
+ "key": "votes",
+ "values": [{"x": "pepperoni", "y": 3.5}, {"x": "cheese", "y": 2.0}],
+ },
+ {
+ "key": "a_column",
+ "values": [{"x": "pepperoni", "y": 3.5}, {"x": "cheese", "y": 2.0}],
+ },
+ ]
+
+ self.assertEqual(expected, data)
+
+ def test_column_metrics_in_order_with_breakdowns(self):
+ form_data = {
+ "metrics": ["z_column", "votes", "a_column"],
+ "adhoc_filters": [],
+ "groupby": ["toppings"],
+ "columns": ["role"],
+ }
+ datasource = self.get_datasource_mock()
+ df = pd.DataFrame(
+ {
+ "toppings": ["cheese", "pepperoni", "cheese", "pepperoni"],
+ "role": ["engineer", "engineer", None, None],
+ "votes": [3, 5, 1, 2],
+ "a_column": [3, 5, 1, 2],
+ "z_column": [3, 5, 1, 2],
+ }
+ )
+ test_viz = viz.DistributionBarViz(datasource, form_data)
+ data = test_viz.get_data(df)
+
+ expected = [
+ {
+ "key": "z_column, {}".format(NULL_STRING),
+ "values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
+ },
+ {
+ "key": "z_column, engineer",
+ "values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
+ },
+ {
+ "key": "votes, {}".format(NULL_STRING),
+ "values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
+ },
+ {
+ "key": "votes, engineer",
+ "values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
+ },
+ {
+ "key": "a_column, {}".format(NULL_STRING),
+ "values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
+ },
+ {
+ "key": "a_column, engineer",
+ "values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
+ },
+ ]
Review comment:
nit: let's use f-strings here
```suggestion
expected = [
{
"key": f"z_column, {NULL_STRING}",
"values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
},
{
"key": "z_column, engineer",
"values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
},
{
"key": f"votes, {NULL_STRING}",
"values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
},
{
"key": "votes, engineer",
"values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
},
{
"key": f"a_column, {NULL_STRING}",
"values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
},
{
"key": "a_column, engineer",
"values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
},
]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] duynguyenhoang edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
duynguyenhoang edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-764843417
@villebro Update to f-strings and formatted viz_test using black.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] duynguyenhoang commented on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
duynguyenhoang commented on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-764843417
@villebro Update to f-strings and formated viz_test using black.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (edaa807) into [master](https://codecov.io/gh/apache/superset/commit/10c2b09942179cbef2b73bfbd920cfc878de9fab?el=desc) (10c2b09) will **decrease** coverage by `4.33%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.79% 62.45% -4.34%
==========================================
Files 1015 1018 +3
Lines 49673 49744 +71
Branches 4845 4869 +24
==========================================
- Hits 33179 31069 -2110
- Misses 16372 18477 +2105
- Partials 122 198 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.93% <ø> (+0.18%)` | :arrow_up: |
| python | `63.46% <50.00%> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [215 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [10c2b09...edaa807](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (6b3e02f) into [master](https://codecov.io/gh/apache/superset/commit/0de61df72f58db957891abd10c9eb5c9110a9572?el=desc) (0de61df) will **decrease** coverage by `0.61%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.85% 66.24% -0.62%
==========================================
Files 1018 1018
Lines 49776 49763 -13
Branches 4869 4869
==========================================
- Hits 33280 32965 -315
- Misses 16373 16671 +298
- Partials 123 127 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.57% <ø> (-0.38%)` | :arrow_down: |
| javascript | `60.93% <ø> (ø)` | |
| python | `63.13% <50.00%> (-0.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [0de61df...d1b02f8](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12417: fix(viz dist_bar): Preserve Column Order in Bar chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758200137
@adam-stasiak please help testing this one as well
@duynguyenhoang thanks for the PR!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (d1b02f8) into [master](https://codecov.io/gh/apache/superset/commit/0de61df72f58db957891abd10c9eb5c9110a9572?el=desc) (0de61df) will **decrease** coverage by `3.13%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.85% 63.71% -3.14%
==========================================
Files 1018 486 -532
Lines 49776 29986 -19790
Branches 4869 0 -4869
==========================================
- Hits 33280 19107 -14173
+ Misses 16373 10879 -5494
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.71% <50.00%> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.82% <0.00%> (-2.48%)` | :arrow_down: |
| ... and [541 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [0de61df...d1b02f8](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (6b3e02f) into [master](https://codecov.io/gh/apache/superset/commit/0de61df72f58db957891abd10c9eb5c9110a9572?el=desc) (0de61df) will **decrease** coverage by `1.47%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.85% 65.38% -1.48%
==========================================
Files 1018 1018
Lines 49776 49763 -13
Branches 4869 4869
==========================================
- Hits 33280 32536 -744
- Misses 16373 17081 +708
- Partials 123 146 +23
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `45.89% <ø> (-5.06%)` | :arrow_down: |
| javascript | `60.93% <ø> (ø)` | |
| python | `63.13% <50.00%> (-0.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.34% <0.00%> (-48.83%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `46.15% <0.00%> (-34.62%)` | :arrow_down: |
| ... and [74 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [0de61df...d1b02f8](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (6b3e02f) into [master](https://codecov.io/gh/apache/superset/commit/0de61df72f58db957891abd10c9eb5c9110a9572?el=desc) (0de61df) will **decrease** coverage by `4.59%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.85% 62.26% -4.60%
==========================================
Files 1018 1018
Lines 49776 49744 -32
Branches 4869 4869
==========================================
- Hits 33280 30972 -2308
- Misses 16373 18574 +2201
- Partials 123 198 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.93% <ø> (ø)` | |
| python | `63.13% <50.00%> (-0.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `60.02% <100.00%> (+0.02%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [220 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [0de61df...d1b02f8](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #12417: fix(explore): Preserve Column Order in Bar chart
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12417:
URL: https://github.com/apache/superset/pull/12417#discussion_r561699562
##########
File path: tests/viz_tests.py
##########
@@ -531,6 +531,92 @@ def test_column_nulls(self):
]
self.assertEqual(expected, data)
+ def test_column_metrics_in_order(self):
+ form_data = {
+ "metrics": ["z_column", "votes", "a_column"],
+ "adhoc_filters": [],
+ "groupby": ["toppings"],
+ "columns": [],
+ }
+ datasource = self.get_datasource_mock()
+ df = pd.DataFrame(
+ {
+ "toppings": ["cheese", "pepperoni", "cheese", "pepperoni"],
+ "role": ["engineer", "engineer", None, None],
+ "votes": [3, 5, 1, 2],
+ "a_column": [3, 5, 1, 2],
+ "z_column": [3, 5, 1, 2],
+ }
+ )
+ test_viz = viz.DistributionBarViz(datasource, form_data)
+ data = test_viz.get_data(df)
+
+ expected = [
+ {
+ "key": "z_column",
+ "values": [{"x": "pepperoni", "y": 3.5}, {"x": "cheese", "y": 2.0}],
+ },
+ {
+ "key": "votes",
+ "values": [{"x": "pepperoni", "y": 3.5}, {"x": "cheese", "y": 2.0}],
+ },
+ {
+ "key": "a_column",
+ "values": [{"x": "pepperoni", "y": 3.5}, {"x": "cheese", "y": 2.0}],
+ },
+ ]
+
+ self.assertEqual(expected, data)
+
+ def test_column_metrics_in_order_with_breakdowns(self):
+ form_data = {
+ "metrics": ["z_column", "votes", "a_column"],
+ "adhoc_filters": [],
+ "groupby": ["toppings"],
+ "columns": ["role"],
+ }
+ datasource = self.get_datasource_mock()
+ df = pd.DataFrame(
+ {
+ "toppings": ["cheese", "pepperoni", "cheese", "pepperoni"],
+ "role": ["engineer", "engineer", None, None],
+ "votes": [3, 5, 1, 2],
+ "a_column": [3, 5, 1, 2],
+ "z_column": [3, 5, 1, 2],
+ }
+ )
+ test_viz = viz.DistributionBarViz(datasource, form_data)
+ data = test_viz.get_data(df)
+
+ expected = [
+ {
+ "key": "z_column, {}".format(NULL_STRING),
+ "values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
+ },
+ {
+ "key": "z_column, engineer",
+ "values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
+ },
+ {
+ "key": "votes, {}".format(NULL_STRING),
+ "values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
+ },
+ {
+ "key": "votes, engineer",
+ "values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
+ },
+ {
+ "key": "a_column, {}".format(NULL_STRING),
+ "values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
+ },
+ {
+ "key": "a_column, engineer",
+ "values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
+ },
+ ]
Review comment:
nit: let's use f-strings here
```suggestion
expected = [
{
"key": f"z_column, {NULL_STRING}",
"values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
},
{
"key": "z_column, engineer",
"values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
},
{
"key": f"votes, {NULL_STRING}",
"values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
},
{
"key": "votes, engineer",
"values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
},
{
"key": f"a_column, {NULL_STRING}",
"values": [{"x": "pepperoni", "y": 2}, {"x": "cheese", "y": 1}],
},
{
"key": "a_column, engineer",
"values": [{"x": "pepperoni", "y": 5}, {"x": "cheese", "y": 3}],
},
]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12417: fix(explore): preserve metric column order in bar chart
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12417:
URL: https://github.com/apache/superset/pull/12417#issuecomment-758237558
# [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=h1) Report
> Merging [#12417](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=desc) (6b3e02f) into [master](https://codecov.io/gh/apache/superset/commit/0de61df72f58db957891abd10c9eb5c9110a9572?el=desc) (0de61df) will **decrease** coverage by `5.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12417 +/- ##
==========================================
- Coverage 66.85% 60.93% -5.93%
==========================================
Files 1018 532 -486
Lines 49776 19773 -30003
Branches 4869 4869
==========================================
- Hits 33280 12049 -21231
+ Misses 16373 7526 -8847
- Partials 123 198 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.93% <ø> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [672 more](https://codecov.io/gh/apache/superset/pull/12417/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=footer). Last update [0de61df...d1b02f8](https://codecov.io/gh/apache/superset/pull/12417?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org