You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Martijn Visser (Jira)" <ji...@apache.org> on 2022/07/05 08:08:00 UTC

[jira] [Commented] (FLINK-28183) flink-python is lacking several test dependencies

    [ https://issues.apache.org/jira/browse/FLINK-28183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562444#comment-17562444 ] 

Martijn Visser commented on FLINK-28183:
----------------------------------------

[~hxbks2ks] Is this something that you can pick up? 

> flink-python is lacking several test dependencies
> -------------------------------------------------
>
>                 Key: FLINK-28183
>                 URL: https://issues.apache.org/jira/browse/FLINK-28183
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: API / Python, Build System
>    Affects Versions: 1.16.0
>            Reporter: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.16.0
>
>
> The pyflink_gateway_server searches the output directories of various modules to construct a test classpath.
> Half of these are not declared as actual test dependencies in maven. Because of that there are no guarantees that these modules are actually built before flink-python.
> Additionally there seem to be no safeguards in place to verify that these jars actually exist.
> Considering that this is only required for testing most of this logic should also be moved into maven, copying these dependencies to some directory under flink-python/target, to make this de-facto build logic more discoverable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)