[hadoop] branch trunk updated: HADOOP-16266. Add more fine-grained processing time metrics to the RPC layer -follow-on patch.

[st...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

stevel pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 827a847  HADOOP-16266. Add more fine-grained processing time metrics to the RPC layer -follow-on patch.
827a847 is described below

commit 827a84778a4e3b8f165806dfd2966f0951a5e575
Author: Steve Loughran <st...@cloudera.com>
AuthorDate: Tue Jun 4 15:30:59 2019 +0100

    HADOOP-16266. Add more fine-grained processing time metrics to the RPC layer -follow-on patch.
    
    This follow-on patch to HADOOP-16266 fixes up the problem where logs were being full of
    stack traces because the timeout passed down to select was in nanos, whereas the API
    expected millis.
    
    Contributed by Erik Krogen.
    
    Change-Id: I5c6e9ddf68127b1d7e0ca0e179d036eb9941e445
---
 .../hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
index 8229b5a..6fc907f 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
@@ -1482,7 +1482,8 @@ public abstract class Server {
       while (running) {
         try {
           waitPending();     // If a channel is being registered, wait.
-          writeSelector.select(PURGE_INTERVAL_NANOS);
+          writeSelector.select(
+              TimeUnit.NANOSECONDS.toMillis(PURGE_INTERVAL_NANOS));
           Iterator<SelectionKey> iter = writeSelector.selectedKeys().iterator();
           while (iter.hasNext()) {
             SelectionKey key = iter.next();


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org