You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/24 03:16:14 UTC

[GitHub] [bookkeeper] mattisonchao opened a new pull request #3135: Fix bad file bookkeeper-4.15.0-SNAPSHOT-src-bin.tar.gz instead of bookkeeper-4.15.0-SNAPSHOT-src.tar.gz

mattisonchao opened a new pull request #3135:
URL: https://github.com/apache/bookkeeper/pull/3135


   
   ### Motivation
   
   See #3129 
   
   ### Changes
   
   Master Issue:#3129 
   
   ### Modification
   
   - Remove ``archiveClassifier = "bin"``


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] mattisonchao closed pull request #3135: Fix bad file bookkeeper-4.15.0-SNAPSHOT-src-bin.tar.gz instead of bookkeeper-4.15.0-SNAPSHOT-src.tar.gz

Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #3135:
URL: https://github.com/apache/bookkeeper/pull/3135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #3135: Fix bad file bookkeeper-4.15.0-SNAPSHOT-src-bin.tar.gz instead of bookkeeper-4.15.0-SNAPSHOT-src.tar.gz

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #3135:
URL: https://github.com/apache/bookkeeper/pull/3135#discussion_r834260371



##########
File path: build.gradle
##########
@@ -230,7 +230,6 @@ allprojects {
                     dependsOn(':bookkeeper-common:jar')
                     dependsOn(':bookkeeper-common-allocator:jar')
                 }
-                archiveClassifier = "bin"

Review comment:
       the "bin" classifier is needed for the bin tarball
   it's the "src" tarball that doesn't need it 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org