[GitHub] [openwhisk] style95 commented on a diff in pull request #5226: add zookeeper storage prefixing to support multi-cluster

[GitBox <gi...@apache.org>]

style95 commented on code in PR #5226:
URL: https://github.com/apache/openwhisk/pull/5226#discussion_r861478781


##########
common/scala/src/main/resources/application.conf:
##########
@@ -128,6 +128,10 @@ whisk {
         logs-enabled       = ${?METRICS_LOG}
     }
 
+    zookeeper {
+        prefix = ""

Review Comment:
   How about adding a comment to describe it should start without `/` and end with `/`?
   



##########
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InstanceIdAssigner.scala:
##########
@@ -39,7 +41,8 @@ private[invoker] class InstanceIdAssigner(connectionString: String)(implicit log
     zkClient.blockUntilConnected()
     logger.info(this, "invokerReg: connected to zookeeper")
 
-    val rootPath = "/invokers/idAssignment/mapping"
+    val zookeeperPrefix = loadConfigOrThrow[String](ConfigKeys.zookeeperStoragePrefix)
+    val rootPath = s"/${zookeeperPrefix}invokers/idAssignment/mapping"

Review Comment:
   👍 
   If nothing specified, it would work as-is.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org