You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by fhieber <gi...@git.apache.org> on 2016/05/31 15:32:27 UTC

[GitHub] incubator-joshua pull request: Reworked some SparseFeature functions. Also a...

GitHub user fhieber opened a pull request:

    https://github.com/apache/incubator-joshua/pull/21

    Reworked some SparseFeature functions. Also added 'lexical' sparse features.

    This makes some of the sparse feature functions more efficient.
    I also removed the redundant "feature-function" string in the JoshuaConfiguration.feature_functions String list, since it served no purposes, afaik.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhieber/incubator-joshua sparse

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-joshua/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit 25a92cbca7c3a11c1d99c3e71686aea9874e0133
Author: Felix Hieber <fh...@amazon.com>
Date:   2016-04-30T16:35:10Z

    Added Sparse lexical feature function. Revised various other sparse feature functions to avoid String formatting. Expensive feature functions now use an LRU cache to avoid re-calculation of feature hashes for commonly used rules. Also cleaned up the feature string parsing a little bit.

commit 5591c6769c162e3268243aa3324c367c6ba9c945
Author: Felix Hieber <fh...@amazon.com>
Date:   2016-05-30T09:54:53Z

    revert change to ivy.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: Reworked some SparseFeature functions. Also a...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-joshua/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---