svn commit: r1450292 - /spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm

[mm...@apache.org]

Author: mmartinec
Date: Tue Feb 26 17:25:11 2013
New Revision: 1450292

URL: http://svn.apache.org/r1450292
Log:
updated a comment: add a ref to Net::DNS bug [rt.cpan.org #83451]

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm?rev=1450292&r1=1450291&r2=1450292&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/DnsResolver.pm Tue Feb 26 17:25:11 2013
@@ -628,11 +628,14 @@ sub _packet_id {
     return join('/', $id, $class, $type, $qname);
 
   } else {
-    # odd.  this should not happen, but clearly some DNS servers
-    # can return something that Net::DNS interprets as having no
-    # question section.  Better support it; just return the
-    # (safe) ID part, along with a text token indicating that
-    # the packet had no question part.
+    # Odd, this should not happen, a DNS servers is supposed to retain
+    # a question section in its reply.  There is a bug in Net::DNS 0.72
+    # and earlier where a signal (e.g. a timeout alarm) during decoding
+    # of a reply packet produces a seemingly valid packet object, but
+    # with missing sections - see [rt.cpan.org #83451] .
+    #
+    # Better support it; just return the (safe) ID part, along with
+    # a text token indicating that the packet had no question part.
     #
     return $id . "/NO_QUESTION_IN_PACKET";
   }