[GitHub] [ignite] agura commented on a change in pull request #7332: IGNITE-12598: Cache metrics configuration should be removed only on cache destroy

[GitBox <gi...@apache.org>]

agura commented on a change in pull request #7332: IGNITE-12598: Cache metrics configuration should be removed only on cache destroy
URL: https://github.com/apache/ignite/pull/7332#discussion_r374821194
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java
 ##########
 @@ -1021,7 +1024,7 @@ private void stopCache(GridCacheAdapter<?, ?> cache, boolean cancel, boolean des
 
             sharedCtx.removeCacheContext(ctx);
 
-            cache.stop();
+            cache.stop(destroy);
 
 Review comment:
   It seems this place (and below at line 1041) are only places where we should remove metric configuration. IF this code will be invoked from this place then we don't need any additional flags for `GridCacheAdapter.stop()` method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services