[GitHub] flink pull request #3037: Flink-4450 update storm version to 1.0

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3037#discussion_r94933332
  
    --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java ---
    @@ -186,15 +186,15 @@ public void testCreateTopologyContext() {
     				.shuffleGrouping("bolt2", TestDummyBolt.groupingStreamId)
     				.shuffleGrouping("bolt2", TestDummyBolt.shuffleStreamId);
     
    -		LocalCluster cluster = new LocalCluster();
    -		Config c = new Config();
    -		c.setNumAckers(0);
    -		cluster.submitTopology("test", c, builder.createTopology());
    -
    -		while (TestSink.result.size() != 8) {
    -			Utils.sleep(100);
    -		}
    -		cluster.shutdown();
    +//		LocalCluster cluster = new LocalCluster();
    --- End diff --
    
    Are these lines accidentally commented out, or is this not working with Storm 1.0 any more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---