You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (Updated) (JIRA)" <ji...@apache.org> on 2012/01/31 23:21:58 UTC
[jira] [Updated] (WICKET-4356) StringValueConversionException
should not be thrown when requesting a conversion on StringValue with a
default value
[ https://issues.apache.org/jira/browse/WICKET-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-4356:
-------------------------------
Summary: StringValueConversionException should not be thrown when requesting a conversion on StringValue with a default value (was: StringValueConversionException thrown when calling toInt(final int defaultValue) on StringValue. Why not to return the default value?)
> StringValueConversionException should not be thrown when requesting a conversion on StringValue with a default value
> --------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-4356
> URL: https://issues.apache.org/jira/browse/WICKET-4356
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Sergei Sizov
> Assignee: Martin Grigorov
> Fix For: 1.5.5, 6.0.0
>
>
> In my application I need to get current page parameter from PageParameters
> so I use this code
> PageParameters parameters = ...
> int currentPage = parameters.get("page").toInt(1);
> It works good when "page" parameter contains an Integer value or is null, but when it contains a non numeric value it throws an exception StringValueConversionException.
> I would expect a little bit different behaviour. Why not to return DEFAULT value when StringValueConversionException is thrown? I think it is more secure and saves many lines of code, because you do not need to check that StringValue is really a string containing only numeric characters.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira