You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Joe Witt (Jira)" <ji...@apache.org> on 2020/03/13 02:53:00 UTC
[jira] [Commented] (NIFI-7250) Add timezones to Github builds
[ https://issues.apache.org/jira/browse/NIFI-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058377#comment-17058377 ]
Joe Witt commented on NIFI-7250:
--------------------------------
also addressing the test which appears brittle on slow windows systems (failed on master and another PR recently)
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.009 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestListenSyslog
[ERROR] testParsingError(org.apache.nifi.processors.standard.TestListenSyslog) Time elapsed: 0.301 s <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at org.apache.nifi.processors.standard.TestListenSyslog.testParsingError(TestListenSyslog.java:141)
> Add timezones to Github builds
> ------------------------------
>
> Key: NIFI-7250
> URL: https://issues.apache.org/jira/browse/NIFI-7250
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Reporter: Pierre Villard
> Assignee: Joe Witt
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> To be sure the code is timezone independent we could add the timezone corresponding the locales we used in the Github actions builds.
> {code:java}
> -Duser.timezone=US/Eastern
> {code}
> As found [Java Util Timezones|http://tutorials.jenkov.com/java-date-time/java-util-timezone.html]
> Ones we care about
> {code:java}
> -Duser.timezone=US/Pacific
> -Duser.timezone=Europe/Paris
> -Duser.timezone=Asia/Tokyo
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)