You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/11/17 16:47:43 UTC
[GitHub] [druid] rohangarg commented on a diff in pull request #13373: Improve performance for ReadableInputStreamFrameChannel
rohangarg commented on code in PR #13373:
URL: https://github.com/apache/druid/pull/13373#discussion_r1025442237
##########
processing/src/main/java/org/apache/druid/frame/channel/ReadableInputStreamFrameChannel.java:
##########
@@ -186,7 +190,15 @@ private void startReading()
totalInputStreamBytesRead += bytesRead;
if (backpressureFuture != null) {
keepReading = false;
- backpressureFuture.addListener(() -> keepReading = true, Execs.directExecutor());
+ backpressureFuture.addListener(
+ () -> {
+ keepReading = true;
+ synchronized (readMonitor) {
Review Comment:
Thanks for catching it Gian! Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org