You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/02/27 20:31:57 UTC
[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6165
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
......................................................................
IMPALA-4983: Set toolchain version to include LZ4 build flags
This bumps the toolchain version to include a change that compiles LZ4
with -O3.
Due to a limitation in the way the toolchain version dependencies,
existing downloads of LZ4 1.7.5 will not be updated. Therefore to ensure
you have the most recent binaries, do the following:
rm -rf ${IMPALA_TOOLCHAIN}/lz4-1.7.5/
cd ${IMPALA_HOME} && . bin/impala-config.sh
bin/bootstrap_toolchain.py
Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/6165/1
--
To view, visit http://gerrit.cloudera.org:8080/6165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
......................................................................
Patch Set 1: Code-Review+2
Ok, I filed https://issues.cloudera.org/browse/IMPALA-5002 to address this build versioning info better in the future.
I'm sure you're already planning on it, but please don't forget to send the update steps to dev@ after this goes in.
--
To view, visit http://gerrit.cloudera.org:8080/6165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
......................................................................
Patch Set 1:
Confirmed that the perf regression is fixed.
With IMPALA-5001 the steps aren't necessary (just a reminder to bootstrap the toolchain).
--
To view, visit http://gerrit.cloudera.org:8080/6165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
......................................................................
IMPALA-4983: Set toolchain version to include LZ4 build flags
This bumps the toolchain version to include a change that compiles LZ4
with -O3.
Due to a limitation in the way the toolchain version dependencies,
existing downloads of LZ4 1.7.5 will not be updated. Therefore to ensure
you have the most recent binaries, do the following:
rm -rf ${IMPALA_TOOLCHAIN}/lz4-1.7.5/
cd ${IMPALA_HOME} && . bin/impala-config.sh
bin/bootstrap_toolchain.py
Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Reviewed-on: http://gerrit.cloudera.org:8080/6165
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Matthew Jacobs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
......................................................................
Patch Set 1:
This does raise an interesting limitation of how we version the toolchain binaries, specifically that we don't have great insight into how a toolchain build was built. I think it's fine for now but it seems like we should have a way to identify the git hash of the native-toolchain used to build a particular "build ID", since that would identify the build flags used for that build ID. I'll file a JIRA for that.
I assume this has passed tests with the new lz4 bits?
--
To view, visit http://gerrit.cloudera.org:8080/6165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/304/
--
To view, visit http://gerrit.cloudera.org:8080/6165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
......................................................................
Patch Set 1:
> I assume this has passed tests with the new lz4 bits?
Basic tests pass. The full suite will be run by GVO as normal.
--
To view, visit http://gerrit.cloudera.org:8080/6165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4983: Set toolchain version to include LZ4 build flags
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No