[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #303: transform old form to new form and use a parameter to control

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #303: transform old form to new form and use a parameter to control
URL: https://github.com/apache/incubator-iotdb/pull/303#discussion_r307565689
 
 

 ##########
 File path: spark-tsfile/src/main/scala/org/apache/iotdb/tsfile/package.scala
 ##########
 @@ -19,15 +19,23 @@
 
 package org.apache.iotdb
 
-import org.apache.spark.sql.{DataFrame, DataFrameReader, DataFrameWriter}
+import org.apache.spark.sql.{DataFrame, DataFrameReader, DataFrameWriter, SparkSession}
 
 package object tsfile {
-
   /**
     * add a method 'tsfile' to DataFrameReader to read tsfile
     */
   implicit class TsFileDataFrameReader(reader: DataFrameReader) {
-    def tsfile: String => DataFrame = reader.format("org.apache.iotdb.tsfile").load
 
 Review comment:
   Is this interface removed: spark.read.tsfile("test.tsfile") ?
   
   You can add an interface, but do not remove the old interface

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services