You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/23 14:00:56 UTC
[GitHub] [orc] pgaref commented on a change in pull request #751: ORC-848: Recycle Internal Buffer in StringHashTableDictionary
pgaref commented on a change in pull request #751:
URL: https://github.com/apache/orc/pull/751#discussion_r675588081
##########
File path: java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java
##########
@@ -75,18 +75,19 @@ public StringHashTableDictionary(int initialCapacity, float loadFactor) {
this.capacity = initialCapacity;
this.loadFactor = loadFactor;
this.keyOffsets = new DynamicIntArray(initialCapacity);
- initHashBuckets(initialCapacity);
+ initHashBuckets(false);
this.threshold = (int)Math.min(initialCapacity * loadFactor, MAX_ARRAY_SIZE + 1);
}
- private void initHashBuckets(int capacity) {
- DynamicIntArray[] buckets = new DynamicIntArray[capacity];
- for (int i = 0; i < capacity; i++) {
+ private void initHashBuckets(final boolean reinit) {
Review comment:
I would even remove the parameter of this method -- we just need to ensure that hashBuckets is initialized right?
So we can just check if its non-null (assuming the capacity remains the same) otherwise create the new buckets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org