You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@archiva.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2010/02/23 16:04:55 UTC
[jira] Created: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
improve the message appearing when an artifact's metadata is incomplete
-----------------------------------------------------------------------
Key: MRM-1335
URL: http://jira.codehaus.org/browse/MRM-1335
Project: Archiva
Issue Type: Improvement
Components: web application
Affects Versions: 1.4
Reporter: Brett Porter
Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=270489#comment-270489 ]
Brett Porter commented on MRM-1335:
-----------------------------------
Looks good to me. There's a couple of code style issues I'd tweak when applying it.
I'm not 100% sure about making maven2-repo depend on problem-reports, but I think it's ok for now until we have a more event-driven approach.
> improve the message appearing when an artifact's metadata is incomplete
> -----------------------------------------------------------------------
>
> Key: MRM-1335
> URL: http://jira.codehaus.org/browse/MRM-1335
> Project: Archiva
> Issue Type: Improvement
> Components: Web Interface
> Affects Versions: 1.4
> Reporter: Brett Porter
> Fix For: 1.4-M1
>
> Attachments: MRM-1335_patch.txt
>
>
> Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
> See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MRM-1335:
------------------------------
Fix Version/s: 1.4
> improve the message appearing when an artifact's metadata is incomplete
> -----------------------------------------------------------------------
>
> Key: MRM-1335
> URL: http://jira.codehaus.org/browse/MRM-1335
> Project: Archiva
> Issue Type: Improvement
> Components: web application
> Affects Versions: 1.4
> Reporter: Brett Porter
> Fix For: 1.4
>
>
> Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
> See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRM-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed MRM-1335.
-----------------------------
Resolution: Fixed
Assignee: Brett Porter
> improve the message appearing when an artifact's metadata is incomplete
> -----------------------------------------------------------------------
>
> Key: MRM-1335
> URL: https://jira.codehaus.org/browse/MRM-1335
> Project: Archiva
> Issue Type: Improvement
> Components: Web Interface
> Affects Versions: 1.4
> Reporter: Brett Porter
> Assignee: Brett Porter
> Fix For: 1.4-M1
>
> Attachments: MRM-1335_patch.txt, MRM-1335_patch_updated.txt
>
>
> Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
> See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=261837#action_261837 ]
Brett Porter commented on MRM-1335:
-----------------------------------
also, the incomplete warning is with a tick instead of warning icon
> improve the message appearing when an artifact's metadata is incomplete
> -----------------------------------------------------------------------
>
> Key: MRM-1335
> URL: http://jira.codehaus.org/browse/MRM-1335
> Project: Archiva
> Issue Type: Improvement
> Components: Web Interface
> Affects Versions: 1.4
> Reporter: Brett Porter
> Fix For: 1.4-M1
>
>
> Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
> See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
Posted by "Greg Michael Meneses (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Michael Meneses updated MRM-1335:
--------------------------------------
Attachment: MRM-1335_patch.txt
Attached patch for fix.
Fix details:
- changed from ActionMessage to ActionError to use warning icon instead of success icon
- changed warning message to include the exception message
- for parent pom problem, changed message indicating that parent pom cannot be resolved
> improve the message appearing when an artifact's metadata is incomplete
> -----------------------------------------------------------------------
>
> Key: MRM-1335
> URL: http://jira.codehaus.org/browse/MRM-1335
> Project: Archiva
> Issue Type: Improvement
> Components: Web Interface
> Affects Versions: 1.4
> Reporter: Brett Porter
> Fix For: 1.4-M1
>
> Attachments: MRM-1335_patch.txt
>
>
> Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
> See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
Posted by "Greg Michael Meneses (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Michael Meneses updated MRM-1335:
--------------------------------------
Attachment: MRM-1335_patch_updated.txt
Attached an updated patch file that fixes a problem where 2 warning message is displayed if the parent pom cannot be resolved
> improve the message appearing when an artifact's metadata is incomplete
> -----------------------------------------------------------------------
>
> Key: MRM-1335
> URL: http://jira.codehaus.org/browse/MRM-1335
> Project: Archiva
> Issue Type: Improvement
> Components: Web Interface
> Affects Versions: 1.4
> Reporter: Brett Porter
> Fix For: 1.4-M1
>
> Attachments: MRM-1335_patch.txt, MRM-1335_patch_updated.txt
>
>
> Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
> See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=270337#comment-270337 ]
Brett Porter commented on MRM-1335:
-----------------------------------
Ideally, the failure will be captured (in addition to flagging it as incomplete), and a descriptive error shown in the box.
A good test case is when a POM with a missing parent is in the repository - it should indicate in the error the error returned from the Maven model builder.
Note the other comments above for more information.
> improve the message appearing when an artifact's metadata is incomplete
> -----------------------------------------------------------------------
>
> Key: MRM-1335
> URL: http://jira.codehaus.org/browse/MRM-1335
> Project: Archiva
> Issue Type: Improvement
> Components: Web Interface
> Affects Versions: 1.4
> Reporter: Brett Porter
> Fix For: 1.4-M1
>
>
> Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
> See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRM-1335) improve the message appearing when an
artifact's metadata is incomplete
Posted by "Greg Michael Meneses (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=270262#comment-270262 ]
Greg Michael Meneses commented on MRM-1335:
-------------------------------------------
Currently this is displayed when the metadata is incomplete:
"The model may be incomplete due to a previous error in resolving information. Refer to the repository problem reports for more information."
Any suggestions on a better message?
> improve the message appearing when an artifact's metadata is incomplete
> -----------------------------------------------------------------------
>
> Key: MRM-1335
> URL: http://jira.codehaus.org/browse/MRM-1335
> Project: Archiva
> Issue Type: Improvement
> Components: Web Interface
> Affects Versions: 1.4
> Reporter: Brett Porter
> Fix For: 1.4-M1
>
>
> Currently the error message on the artifact page points to the problem reports - but these are not necessarily present or related. It should instead log the error that occurred to put it in an incomplete state (this may need to be added to the metadata model as an additional facet of the project version).
> See: http://mail-archives.apache.org/mod_mbox/archiva-dev/201002.mbox/%3C8667b1bd1002180745k10ad8c75o1de8e59a2b1c8ac6@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira