You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gaborgsomogyi <gi...@git.apache.org> on 2018/02/20 10:23:47 UTC
[GitHub] spark pull request #20639: [SPARK-23288][SS] Fix output metrics with parquet...
GitHub user gaborgsomogyi opened a pull request:
https://github.com/apache/spark/pull/20639
[SPARK-23288][SS] Fix output metrics with parquet sink
## What changes were proposed in this pull request?
Output metrics were not filled when parquet sink used.
This PR fixes this problem by passing a `BasicWriteJobStatsTracker` in `FileStreamSink`.
## How was this patch tested?
Additional unit test added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaborgsomogyi/spark SPARK-23288
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20639.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20639
----
commit 22e6ca1576bdeee2092afc8bc82a743e0700a959
Author: Gabor Somogyi <ga...@...>
Date: 2018-02-19T23:43:46Z
[SPARK-23288][SS] Fix output metrics with parquet sink
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by gaborgsomogyi <gi...@git.apache.org>.
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20639
Executed these tests manually again but working fine. Seems like flaky.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20639
**[Test build #87856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87856/testReport)** for PR 20639 at commit [`55aa8bc`](https://github.com/apache/spark/commit/55aa8bca96b112a33cabb352afb4168c2d8f355c).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class CatalogColumnStat(`
* `case class LocalRelation(`
* `case class StreamingDataSourceV2Relation(`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20639
this is ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20639
**[Test build #87856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87856/testReport)** for PR 20639 at commit [`55aa8bc`](https://github.com/apache/spark/commit/55aa8bca96b112a33cabb352afb4168c2d8f355c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20639: [SPARK-23288][SS] Fix output metrics with parquet...
Posted by gaborgsomogyi <gi...@git.apache.org>.
Github user gaborgsomogyi closed the pull request at:
https://github.com/apache/spark/pull/20639
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20639
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20639
**[Test build #4137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4137/testReport)** for PR 20639 at commit [`22e6ca1`](https://github.com/apache/spark/commit/22e6ca1576bdeee2092afc8bc82a743e0700a959).
* This patch passes all tests.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20639
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20639
**[Test build #4137 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4137/testReport)** for PR 20639 at commit [`22e6ca1`](https://github.com/apache/spark/commit/22e6ca1576bdeee2092afc8bc82a743e0700a959).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by gaborgsomogyi <gi...@git.apache.org>.
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20639
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20639
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by gaborgsomogyi <gi...@git.apache.org>.
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20639
God, seems like stuck somehow. I'll re-create the PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20639
@zsxwing as well.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20639
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87856/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by gaborgsomogyi <gi...@git.apache.org>.
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/20639
cc @tdas @viirya @vanzin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20639
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org