You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Guillaume Nodet <gn...@apache.org> on 2015/09/02 14:18:44 UTC

Re: [VOTE] Release SSHD 1.0.0 (2nd try)

I think we're still missing some binding votes.
Can anyone please review ?

2015-08-19 16:13 GMT+02:00 Guillaume Nodet <gn...@apache.org>:

> I uploaded another 1.0.0 release of SSHD to fix the JDK7 compatibility
> problems.
>
> The artefacts are available at
>   https://repository.apache.org/content/repositories/orgapachemina-1014
>
> Release notes:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12323302
>
> Please review and vote.
>
> Cheers,
> Guillaume Nodet
>

Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 02/09/15 14:51, Lyor Goldstein a écrit :
> +1 (if developers can vote for the very code they wrote... :-))

Ahhh...

Please let me check the code tonite and vote.



RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
This is not the way to do this since it lacks all the necessary exclusions configuration - if you look at the actual mvn build command (see below) when you run 'mvn clean install', the rat-check is executed correctly – see below:

lgoldstein@ubuntu-14:~/mina-sshd/sshd-core$ mvn clean install
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Mina SSHD :: Core 1.0.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ sshd-core ---
[INFO] Deleting /home/lgoldstein/mina-sshd/sshd-core/target
[INFO]
[INFO] --- build-helper-maven-plugin:1.9.1:remove-project-artifact (remove-previous-artifact) @ sshd-core ---
[INFO] /home/lgoldstein/.m2/repository/org/apache/sshd/sshd-core/1.0.1-SNAPSHOT removed.
[INFO]
[INFO] --- maven-enforcer-plugin:1.4:enforce (enforce-versions) @ sshd-core ---
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (check-apache-license-header) @ sshd-core ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: **/*.iml
[INFO] Exclude: src/docs/**
[INFO] Exclude: src/test/resources/**
[INFO] Exclude: **/stty-output-*.txt
[INFO] Exclude: **/big-msg.txt
[INFO] Exclude: sshd-sftp/**
[INFO] Exclude: sshd-pam/**
[INFO] Exclude: .metadata/**
[INFO] Exclude: .recommenders/**
[INFO] Exclude: RemoteSystemsTempFiles/**
[INFO] Exclude: .project
[INFO] Exclude: .classpath
[INFO] Exclude: .springBeans
[INFO] Exclude: .settings/**
[INFO] 624 resources included (use -debug for more details)
Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 624 licence.
[INFO]

-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com] 
Sent: Monday, September 7, 2015 10:03
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Le 07/09/15 06:01, Lyor Goldstein a écrit :
> They are excluded (or the build would have failed...)

just run mvn apache-rat:check


Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 07/09/15 10:32, Lyor Goldstein a écrit :
> Found another way (committed in latest 'master' version) - simply run 'mvn apache-rat:check' wherever you like in the project and the correct defaults will be applied - regardless of whether the sources are compiled or not...

Thanks !


RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
Found another way (committed in latest 'master' version) - simply run 'mvn apache-rat:check' wherever you like in the project and the correct defaults will be applied - regardless of whether the sources are compiled or not...

-----Original Message-----
From: Lyor Goldstein [mailto:lgoldstein@vmware.com] 
Sent: Monday, September 7, 2015 11:18
To: dev@mina.apache.org
Subject: RE: [VOTE] Release SSHD 1.0.0 (2nd try)

How about: "mvn -DskipTests clean install" ? This will just compile, make sure that all the licenses are OK, etc.., but not run any tests...

-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com] 
Sent: Monday, September 7, 2015 11:15
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Le 07/09/15 09:08, Lyor Goldstein a écrit :
> This is not

I know. The thing is that there is no way to check that the license headers are correct *before* running the release, when we would like to check that beforehand. That means there is probably something we can fix to be able to run the check as a standalone process. Sorry if that was not clear enough.


RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
How about: "mvn -DskipTests clean install" ? This will just compile, make sure that all the licenses are OK, etc.., but not run any tests...

-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com] 
Sent: Monday, September 7, 2015 11:15
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Le 07/09/15 09:08, Lyor Goldstein a écrit :
> This is not

I know. The thing is that there is no way to check that the license headers are correct *before* running the release, when we would like to check that beforehand. That means there is probably something we can fix to be able to run the check as a standalone process. Sorry if that was not clear enough.


Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 07/09/15 09:08, Lyor Goldstein a écrit :
> This is not

I know. The thing is that there is no way to check that the license
headers are correct *before* running the release, when we would like to
check that beforehand. That means there is probably something we can fix
to be able to run the check as a standalone process. Sorry if that was
not clear enough.


RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
This is not the way to do this since it lacks all the necessary exclusions configuration - if you look at the actual mvn build command (see below) when you run 'mvn clean install', the rat-check is executed correctly – see below:



lgoldstein@ubuntu-14:~/mina-sshd/sshd-core$ mvn clean install

[INFO] Scanning for projects...

[INFO]

[INFO] ------------------------------------------------------------------------

[INFO] Building Apache Mina SSHD :: Core 1.0.1-SNAPSHOT

[INFO] ------------------------------------------------------------------------

[INFO]

[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ sshd-core ---

[INFO] Deleting /home/lgoldstein/mina-sshd/sshd-core/target

[INFO]

[INFO] --- build-helper-maven-plugin:1.9.1:remove-project-artifact (remove-previous-artifact) @ sshd-core ---

[INFO] /home/lgoldstein/.m2/repository/org/apache/sshd/sshd-core/1.0.1-SNAPSHOT removed.

[INFO]

[INFO] --- maven-enforcer-plugin:1.4:enforce (enforce-versions) @ sshd-core ---

[INFO]

[INFO] --- apache-rat-plugin:0.11:check (check-apache-license-header) @ sshd-core ---

[INFO] 51 implicit excludes (use -debug for more details).

[INFO] Exclude: **/*.iml

[INFO] Exclude: src/docs/**

[INFO] Exclude: src/test/resources/**

[INFO] Exclude: **/stty-output-*.txt

[INFO] Exclude: **/big-msg.txt

[INFO] Exclude: sshd-sftp/**

[INFO] Exclude: sshd-pam/**

[INFO] Exclude: .metadata/**

[INFO] Exclude: .recommenders/**

[INFO] Exclude: RemoteSystemsTempFiles/**

[INFO] Exclude: .project

[INFO] Exclude: .classpath

[INFO] Exclude: .springBeans

[INFO] Exclude: .settings/**

[INFO] 624 resources included (use -debug for more details)

Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.

Compiler warnings:

  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'

Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.

Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.

Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 624 licence.

[INFO]



-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Monday, September 7, 2015 10:03
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)



Le 07/09/15 06:01, Lyor Goldstein a écrit :

> They are excluded (or the build would have failed...)



just run mvn apache-rat:check



Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 07/09/15 06:01, Lyor Goldstein a écrit :
> They are excluded (or the build would have failed...)

just run mvn apache-rat:check


RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
They are excluded (or the build would have failed...)

-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com] 
Sent: Sunday, September 6, 2015 13:29
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Le 06/09/15 12:06, Lyor Goldstein a écrit :
> These files are test ones that usually don't have copyright notices since they are standard formats...

uyes, I know. You just have to modify the pom to get those files excluded from the rat check.



Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 06/09/15 12:06, Lyor Goldstein a écrit :
> These files are test ones that usually don't have copyright notices since they are standard formats...

uyes, I know. You just have to modify the pom to get those files
excluded from the rat check.



RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
These files are test ones that usually don't have copyright notices since they are standard formats...
________________________________________
From: Emmanuel Lécharny [elecharny@gmail.com]
Sent: Thursday, September 3, 2015 5:17 PM
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)

btw, soem tuning should be applied to the apache-rat plugin config.

in sshd-core, when running mvn apache-rat:check :

29 Unknown Licenses

*******************************

Unapproved licenses:


/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/big-msg.txt

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_dsa

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_ecdsa

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_rsa_key

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/config/sshd_config

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-DSA-KeyPair

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-DSA-KeyPair.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-256-KeyPair

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-256-KeyPair.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-384-KeyPair

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-384-KeyPair.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-521-KeyPair

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-521-KeyPair.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-RSA-KeyPair

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-RSA-KeyPair.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/stty-output-1.txt

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/stty-output-2.txt

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-128-key

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-128-key.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-192-key

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-192-key.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-256-key

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-256-key.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-DES-EDE3-key

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-DES-EDE3-key.pub

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/authorized_keys

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_dsa_key

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_ecdsa_key

/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_rsa_key



Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 03/09/15 18:29, Stefan Magnus Landrø a écrit :
> Btw, I tried building with three different JDKs on travis:
> https://travis-ci.org/landro/mina-sshd/
>
> They all fail - I haven't had any time to investigate what's going on, but
> it's probably issues similar to the one Emmanuel is experiencing.

Not exectly the same. However, the build seems to take a long time on
your machine (7mins) when it takes only 2 mins on mine. It might have
some impact on some of the tests.



Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Stefan Magnus Landrø <st...@gmail.com>.
Btw, I tried building with three different JDKs on travis:
https://travis-ci.org/landro/mina-sshd/

They all fail - I haven't had any time to investigate what's going on, but
it's probably issues similar to the one Emmanuel is experiencing.

I'll try to look more into that next week or so.

However, I believe 1.0 should be shipped anyways.

Stefan

2015-09-03 16:17 GMT+02:00 Emmanuel Lécharny <el...@gmail.com>:

> btw, soem tuning should be applied to the apache-rat plugin config.
>
> in sshd-core, when running mvn apache-rat:check :
>
> 29 Unknown Licenses
>
> *******************************
>
> Unapproved licenses:
>
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/big-msg.txt
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_dsa
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_ecdsa
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_rsa_key
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/config/sshd_config
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-DSA-KeyPair
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-DSA-KeyPair.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-256-KeyPair
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-256-KeyPair.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-384-KeyPair
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-384-KeyPair.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-521-KeyPair
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-521-KeyPair.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-RSA-KeyPair
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-RSA-KeyPair.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/stty-output-1.txt
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/stty-output-2.txt
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-128-key
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-128-key.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-192-key
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-192-key.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-256-key
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-256-key.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-DES-EDE3-key
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-DES-EDE3-key.pub
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/authorized_keys
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_dsa_key
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_ecdsa_key
>
>
> /Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_rsa_key
>
>
>


-- 
BEKK Open
http://open.bekk.no

TesTcl - a unit test framework for iRules
http://testcl.com

Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
btw, soem tuning should be applied to the apache-rat plugin config.

in sshd-core, when running mvn apache-rat:check :

29 Unknown Licenses

*******************************

Unapproved licenses:

 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/big-msg.txt
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_dsa
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_ecdsa
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/client/config/keys/id_rsa_key
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/config/sshd_config
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-DSA-KeyPair
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-DSA-KeyPair.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-256-KeyPair
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-256-KeyPair.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-384-KeyPair
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-384-KeyPair.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-521-KeyPair
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-EC-521-KeyPair.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-RSA-KeyPair
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/SecurityUtilsTest-RSA-KeyPair.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/stty-output-1.txt
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/stty-output-2.txt
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-128-key
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-128-key.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-192-key
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-192-key.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-256-key
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-AES-256-key.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-DES-EDE3-key
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/common/util/super-secret-passphrase-RSA-DES-EDE3-key.pub
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/authorized_keys
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_dsa_key
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_ecdsa_key
 
/Users/elecharny/Downloads/apache-sshd-1.0.0/sshd-core/src/test/resources/org/apache/sshd/server/config/keys/ssh_host_rsa_key



Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 03/09/15 13:15, Jeff MAURY a écrit :
> +1 (Windows 8.1 / Java 1.8.0_51)

+1 (after having fixed the test).

I don't mean we should change anything in the current code, it's just a
test that work under some specific conditions (or that fails under
specific condition, should I say ;-)


I think we are good to go !

RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
Good idea,
We'll do that for 1.1...
________________________________________
From: Emmanuel Lécharny [elecharny@gmail.com]
Sent: Thursday, September 3, 2015 4:53 PM
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Ok, the failing test is due to the resolution of 'localhost'. On my
computer, 'localhost' resolves to localhost/192.168.1.29, which is not
127.0.0.1.

I would suggest that the test uses 127.0.0.1 (for which teh test is
passing).


Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Ok, the failing test is due to the resolution of 'localhost'. On my
computer, 'localhost' resolves to localhost/192.168.1.29, which is not
127.0.0.1.

I would suggest that the test uses 127.0.0.1 (for which teh test is
passing).


Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Jeff MAURY <je...@jeffmaury.com>.
+1 (Windows 8.1 / Java 1.8.0_51)

Jeff

On Thu, Sep 3, 2015 at 9:17 AM, Emmanuel Lécharny <el...@gmail.com>
wrote:

> Le 03/09/15 06:35, Lyor Goldstein a écrit :
> > That's strange (see below) - I noticed you are using Java 8 to compile
> whereas we use Java 7. It should not matter - e.g., I also use (sometimes)
> Java 8 and have had no problems.
> >
> > - Have you tried running only this test (see below) ?
> > - Maybe your host is too "weak" or too busy and you are hitting some
> internal JSch timeout ?
>
>
> I'll do the test when back home (on the road today...) Sorry for the delay.
>
>
>


-- 
Jeff MAURY


"Legacy code" often differs from its suggested alternative by actually
working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury

Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 03/09/15 06:35, Lyor Goldstein a écrit :
> That's strange (see below) - I noticed you are using Java 8 to compile whereas we use Java 7. It should not matter - e.g., I also use (sometimes) Java 8 and have had no problems.
>
> - Have you tried running only this test (see below) ?
> - Maybe your host is too "weak" or too busy and you are hitting some internal JSch timeout ?


I'll do the test when back home (on the road today...) Sorry for the delay.



RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
That's strange (see below) - I noticed you are using Java 8 to compile whereas we use Java 7. It should not matter - e.g., I also use (sometimes) Java 8 and have had no problems.

- Have you tried running only this test (see below) ?
- Maybe your host is too "weak" or too busy and you are hitting some internal JSch timeout ?

Anyway, here is the result of running the test with Java 7:


lgoldstein@ubuntu-14:~/mina-sshd/sshd-core$ mvn -Dtest=PortForwardingTest#testLocalForwarding clean test
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Mina SSHD :: Core 1.0.0
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ sshd-core ---
[INFO] Deleting /home/lgoldstein/mina-sshd/sshd-core/target
[INFO]
[INFO] --- build-helper-maven-plugin:1.9.1:remove-project-artifact (remove-previous-artifact) @ sshd-core ---
[INFO] /home/lgoldstein/.m2/repository/org/apache/sshd/sshd-core/1.0.0 removed.
[INFO]
[INFO] --- maven-enforcer-plugin:1.4:enforce (enforce-versions) @ sshd-core ---
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (check-apache-license-header) @ sshd-core ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: **/*.iml
[INFO] Exclude: src/docs/**
[INFO] Exclude: src/test/resources/**
[INFO] Exclude: **/stty-output-*.txt
[INFO] Exclude: **/big-msg.txt
[INFO] Exclude: sshd-sftp/**
[INFO] Exclude: sshd-pam/**
[INFO] Exclude: .metadata/**
[INFO] Exclude: .recommenders/**
[INFO] Exclude: RemoteSystemsTempFiles/**
[INFO] Exclude: .project
[INFO] Exclude: .classpath
[INFO] Exclude: .springBeans
[INFO] Exclude: .settings/**
[INFO] 585 resources included (use -debug for more details)
Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 585 licence.
[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ sshd-core ---
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ sshd-core ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ sshd-core ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 455 source files to /home/lgoldstein/mina-sshd/sshd-core/target/classes
[INFO] /home/lgoldstein/mina-sshd/sshd-core/src/main/java/org/apache/sshd/common/util/CloseableUtils.java: /home/lgoldstein/mina-sshd/sshd-core/src/main/java/org/apache/sshd/common/util/CloseableUtils.java uses unchecked or unsafe operations.
[INFO] /home/lgoldstein/mina-sshd/sshd-core/src/main/java/org/apache/sshd/common/util/CloseableUtils.java: Recompile with -Xlint:unchecked for details.
[INFO]
[INFO] --- animal-sniffer-maven-plugin:1.14:check (check-java-api) @ sshd-core ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java17:1.0
[INFO]
[INFO] --- maven-bundle-plugin:2.5.3:manifest (bundle-manifest) @ sshd-core ---
[INFO]
[INFO] --- maven-checkstyle-plugin:2.15:check (verify-style) @ sshd-core ---
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ sshd-core ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 33 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.3:testCompile (default-testCompile) @ sshd-core ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 119 source files to /home/lgoldstein/mina-sshd/sshd-core/target/test-classes
[INFO]
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ sshd-core ---
[INFO] Surefire report directory: /home/lgoldstein/mina-sshd/sshd-core/target/surefire-reports-nio2
[INFO] Using configured provider org.apache.maven.surefire.junitcore.JUnitCoreProvider
[INFO] parallel='none', perCoreThreadCount=false, threadCount=1, useUnlimitedThreads=false, threadCountSuites=0, threadCountClasses=0, threadCountMethods=0, parallelOptimized=true

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.sshd.PortForwardingTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.79 sec - in org.apache.sshd.PortForwardingTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO]
[INFO] --- maven-surefire-plugin:2.18.1:test (mina) @ sshd-core ---
[INFO] Surefire report directory: /home/lgoldstein/mina-sshd/sshd-core/target/surefire-reports-mina
[INFO] Using configured provider org.apache.maven.surefire.junitcore.JUnitCoreProvider
[INFO] parallel='none', perCoreThreadCount=false, threadCount=1, useUnlimitedThreads=false, threadCountSuites=0, threadCountClasses=0, threadCountMethods=0, parallelOptimized=true

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.sshd.PortForwardingTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.619 sec - in org.apache.sshd.PortForwardingTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO]
[INFO] --- maven-surefire-plugin:2.18.1:test (jce) @ sshd-core ---
[INFO] Surefire report directory: /home/lgoldstein/mina-sshd/sshd-core/target/surefire-reports-jce
[INFO] Using configured provider org.apache.maven.surefire.junitcore.JUnitCoreProvider
[INFO] parallel='none', perCoreThreadCount=false, threadCount=1, useUnlimitedThreads=false, threadCountSuites=0, threadCountClasses=0, threadCountMethods=0, parallelOptimized=true

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.sshd.PortForwardingTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.75 sec - in org.apache.sshd.PortForwardingTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:17 min
[INFO] Finished at: 2015-09-03T07:30:28+03:00
[INFO] Final Memory: 32M/110M
[INFO] ------------------------------------------------------------------------

-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com] 
Sent: Thursday, September 3, 2015 02:17
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Le 02/09/15 14:51, Lyor Goldstein a écrit :
> +1 (if developers can vote for the very code they wrote... :-))

I tested the code (from git and from the published package, and I get an
error :

...
Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.744
sec <<< FAILURE! - in org.apache.sshd.PortForwardingTest
testLocalForwarding(org.apache.sshd.PortForwardingTest)  Time elapsed:
0.156 sec  <<< ERROR!
java.net.ConnectException: Connection refused
    at java.net.PlainSocketImpl.socketConnect(Native Method)
    at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345)
    at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
    at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
    at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
    at java.net.Socket.connect(Socket.java:589)
    at java.net.Socket.connect(Socket.java:538)
    at java.net.Socket.<init>(Socket.java:434)
    at java.net.Socket.<init>(Socket.java:211)
    at
org.apache.sshd.PortForwardingTest.testLocalForwarding(PortForwardingTest.java:332)
...
Results :

Tests in error:
  PortForwardingTest.testLocalForwarding:332 » Connect Connection refused

Tests run: 441, Failures: 0, Errors: 1, Skipped: 12

[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Mina SSHD ................................... SUCCESS [
24.408 s]
[INFO] Apache Mina SSHD :: Core ........................... FAILURE
[02:46 min]
[INFO] Apache Mina SSHD :: Git ............................ SKIPPED
[INFO] Apache Mina SSHD :: Assembly ....................... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 03:11 min
[INFO] Finished at: 2015-09-03T01:15:16+02:00
[INFO] Final Memory: 39M/247M
[INFO]
------------------------------------------------------------------------


Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
FTR :

localhost:apache-sshd-1.0.0 elecharny$ mvn -version
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
MaxPermSize=256M; support was removed in 8.0
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T18:29:23+01:00)
Maven home: /opt/apache-maven-3.2.5
Java version: 1.8.0_45, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.9.5", arch: "x86_64", family: "mac"



Le 03/09/15 01:16, Emmanuel Lécharny a écrit :
> Le 02/09/15 14:51, Lyor Goldstein a écrit :
>> +1 (if developers can vote for the very code they wrote... :-))
> I tested the code (from git and from the published package, and I get an
> error :
>
> ...
> Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.744
> sec <<< FAILURE! - in org.apache.sshd.PortForwardingTest
> testLocalForwarding(org.apache.sshd.PortForwardingTest)  Time elapsed:
> 0.156 sec  <<< ERROR!
> java.net.ConnectException: Connection refused
>     at java.net.PlainSocketImpl.socketConnect(Native Method)
>     at
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345)
>     at
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
>     at
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
>     at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
>     at java.net.Socket.connect(Socket.java:589)
>     at java.net.Socket.connect(Socket.java:538)
>     at java.net.Socket.<init>(Socket.java:434)
>     at java.net.Socket.<init>(Socket.java:211)
>     at
> org.apache.sshd.PortForwardingTest.testLocalForwarding(PortForwardingTest.java:332)
> ...
> Results :
>
> Tests in error:
>   PortForwardingTest.testLocalForwarding:332 » Connect Connection refused
>
> Tests run: 441, Failures: 0, Errors: 1, Skipped: 12
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Mina SSHD ................................... SUCCESS [
> 24.408 s]
> [INFO] Apache Mina SSHD :: Core ........................... FAILURE
> [02:46 min]
> [INFO] Apache Mina SSHD :: Git ............................ SKIPPED
> [INFO] Apache Mina SSHD :: Assembly ....................... SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 03:11 min
> [INFO] Finished at: 2015-09-03T01:15:16+02:00
> [INFO] Final Memory: 39M/247M
> [INFO]
> ------------------------------------------------------------------------
>


Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 02/09/15 14:51, Lyor Goldstein a écrit :
> +1 (if developers can vote for the very code they wrote... :-))

I tested the code (from git and from the published package, and I get an
error :

...
Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.744
sec <<< FAILURE! - in org.apache.sshd.PortForwardingTest
testLocalForwarding(org.apache.sshd.PortForwardingTest)  Time elapsed:
0.156 sec  <<< ERROR!
java.net.ConnectException: Connection refused
    at java.net.PlainSocketImpl.socketConnect(Native Method)
    at
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345)
    at
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
    at
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
    at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
    at java.net.Socket.connect(Socket.java:589)
    at java.net.Socket.connect(Socket.java:538)
    at java.net.Socket.<init>(Socket.java:434)
    at java.net.Socket.<init>(Socket.java:211)
    at
org.apache.sshd.PortForwardingTest.testLocalForwarding(PortForwardingTest.java:332)
...
Results :

Tests in error:
  PortForwardingTest.testLocalForwarding:332 » Connect Connection refused

Tests run: 441, Failures: 0, Errors: 1, Skipped: 12

[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Mina SSHD ................................... SUCCESS [
24.408 s]
[INFO] Apache Mina SSHD :: Core ........................... FAILURE
[02:46 min]
[INFO] Apache Mina SSHD :: Git ............................ SKIPPED
[INFO] Apache Mina SSHD :: Assembly ....................... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 03:11 min
[INFO] Finished at: 2015-09-03T01:15:16+02:00
[INFO] Final Memory: 39M/247M
[INFO]
------------------------------------------------------------------------


RE: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by Lyor Goldstein <lg...@vmware.com>.
+1 (if developers can vote for the very code they wrote... :-))

-----Original Message-----
From: Guillaume Nodet [mailto:gnodet@apache.org] 
Sent: Wednesday, September 2, 2015 15:19
To: dev@mina.apache.org
Subject: Re: [VOTE] Release SSHD 1.0.0 (2nd try)

I think we're still missing some binding votes.
Can anyone please review ?

2015-08-19 16:13 GMT+02:00 Guillaume Nodet <gn...@apache.org>:

> I uploaded another 1.0.0 release of SSHD to fix the JDK7 compatibility
> problems.
>
> The artefacts are available at
>   https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_repositories_orgapachemina-2D1014&d=BQIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=jT2ZU0o-zl4HRtggdiVHswmpKFyEJ_B5hyQwoqsedcc&s=KZWueTN5YbzH_ICONlfA2Yk_5a8Mo2P-5tto_r0KIFs&e= 
>
> Release notes:
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_secure_ReleaseNote.jspa-3FprojectId-3D12310849-26version-3D12323302&d=BQIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=jT2ZU0o-zl4HRtggdiVHswmpKFyEJ_B5hyQwoqsedcc&s=wBIsFR8BgK0l-Tcl7ypn-X6pDCFmg-YFGD735MNKVxQ&e= 
>
> Please review and vote.
>
> Cheers,
> Guillaume Nodet
>

Re: [VOTE] Release SSHD 1.0.0 (2nd try)

Posted by "Jamie G." <ja...@gmail.com>.
+1 (non-binding)


On Wed, Sep 2, 2015 at 9:48 AM, Guillaume Nodet <gn...@apache.org> wrote:
> I think we're still missing some binding votes.
> Can anyone please review ?
>
> 2015-08-19 16:13 GMT+02:00 Guillaume Nodet <gn...@apache.org>:
>
>> I uploaded another 1.0.0 release of SSHD to fix the JDK7 compatibility
>> problems.
>>
>> The artefacts are available at
>>   https://repository.apache.org/content/repositories/orgapachemina-1014
>>
>> Release notes:
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12323302
>>
>> Please review and vote.
>>
>> Cheers,
>> Guillaume Nodet
>>