You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/03/14 00:04:23 UTC
Re: Review Request 31017: Fixed comment for remove executor hook.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/
-----------------------------------------------------------
(Updated March 13, 2015, 4:04 p.m.)
Review request for mesos and Kapil Arya.
Changes
-------
Rebased
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d
Diff: https://reviews.apache.org/r/31017/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 31017: Fixed comment for remove executor hook.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/#review80829
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On April 20, 2015, 1:17 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31017/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 1:17 p.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d
>
> Diff: https://reviews.apache.org/r/31017/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 31017: Fixed comment for remove executor hook.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/
-----------------------------------------------------------
(Updated April 20, 2015, 2:34 p.m.)
Review request for mesos and Kapil Arya.
Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d
Diff: https://reviews.apache.org/r/31017/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 31017: Fixed comment for remove executor hook.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/
-----------------------------------------------------------
(Updated April 20, 2015, 1:17 p.m.)
Review request for mesos and Kapil Arya.
Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d
Diff: https://reviews.apache.org/r/31017/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 31017: Fixed comment for remove executor hook.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/
-----------------------------------------------------------
(Updated April 11, 2015, 3:03 a.m.)
Review request for mesos and Kapil Arya.
Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d
Diff: https://reviews.apache.org/r/31017/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 31017: Fixed comment for remove executor hook.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/
-----------------------------------------------------------
(Updated April 7, 2015, 5:58 p.m.)
Review request for mesos and Kapil Arya.
Changes
-------
rebased
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d
Diff: https://reviews.apache.org/r/31017/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 31017: Fixed comment for remove executor hook.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/#review76460
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30961, 30962, 31016, 31028, 31017]
All tests passed.
- Mesos ReviewBot
On March 13, 2015, 11:04 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31017/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 11:04 p.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d
>
> Diff: https://reviews.apache.org/r/31017/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>