[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14451: ARROW-18087: [C++] RecordBatch::Equals should not ignore field names

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on code in PR #14451:
URL: https://github.com/apache/arrow/pull/14451#discussion_r1005980773


##########
cpp/src/arrow/dataset/test_util.h:
##########
@@ -157,7 +157,7 @@ class DatasetFixtureMixin : public ::testing::Test {
     std::shared_ptr<RecordBatch> lhs;
     ASSERT_OK(expected->ReadNext(&lhs));
     EXPECT_NE(lhs, nullptr);
-    AssertBatchesEqual(*lhs, batch, true);
+    AssertBatchesEqual(*lhs, batch);

Review Comment:
   See https://github.com/apache/arrow/pull/14326#discussion_r998421185, this is only reverting what was added in that other PR (to avoid having that PR be blocked on this one). 
   In theory, it shouldn't matter, because if it passes without true, it will certainly pass with `check_metadata=True`. It's just not needed in this case (so to simplify the code and avoid that people wonder why it is here)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org