[GitHub] [skywalking] wallezhang commented on a change in pull request #7271: fix: Fix MultiScopesAnalysisListener#setPublicAttrs log warn frequently

[GitBox <gi...@apache.org>]

wallezhang commented on a change in pull request #7271:
URL: https://github.com/apache/skywalking/pull/7271#discussion_r688275768



##########
File path: oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/MultiScopesAnalysisListener.java
##########
@@ -240,12 +240,15 @@ private void setPublicAttrs(SourceBuilder sourceBuilder, SpanObject span) {
         sourceBuilder.setLatency((int) latency);
         sourceBuilder.setResponseCode(Const.NONE);
         span.getTagsList().forEach(tag -> {
-            if (SpanTags.STATUS_CODE.equals(tag.getKey())) {
+            if (SpanTags.HTTP_RESPONSE_STATUS_CODE.equals(tag.getKey())) {

Review comment:
       Yes, it's reasonable. So I should keep the old tag `SpanTags.STATUS_CODE` and explain in comment that it has been deprecated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org