[GitHub] mkiiskila commented on a change in pull request #55: MYNEWT-583; newt - allow use of specific tag/repository revision.

[gi...@git.apache.org]

mkiiskila commented on a change in pull request #55: MYNEWT-583; newt - allow use of specific tag/repository revision.
URL: https://github.com/apache/incubator-mynewt-newt/pull/55#discussion_r119234348
 
 

 ##########
 File path: newt/repo/repo.go
 ##########
 @@ -157,6 +173,32 @@ func NewRepoDependency(rname string, verstr string) (*RepoDependency, error) {
 	return rd, nil
 }
 
+func pickVersion(repo *Repo, versions []*Version) ([]*Version, error) {
+	fmt.Printf("Dependency list for %s contains a specific commit tag, " +
+		"so normal version number/stability comparison cannot be done.\n",
+		repo.Name())
+	fmt.Printf("If the following list does not contain the requirement to use, "+
+		"then modify your project.yml so that it does.\n")
+	for {
+		for i, vers := range versions {
+			fmt.Printf(" %d) %s\n", i, vers)
 
 Review comment:
   I believe it calls the String() method for it automagically, presumably due to %s on the format string.
   However, I can add the explicit call to make it more clear what's going on.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services