[GitHub] [doris] gavinchou commented on a diff in pull request #13336: [fix](jsonreader) teach jsonreader to release memory

[GitBox <gi...@apache.org>]

gavinchou commented on code in PR #13336:
URL: https://github.com/apache/doris/pull/13336#discussion_r993590746


##########
be/src/exec/json_scanner.h:
##########
@@ -178,7 +178,14 @@ class JsonReader {
     std::vector<std::vector<JsonPath>> _parsed_jsonpaths;
     std::vector<JsonPath> _parsed_json_root;
 
-    rapidjson::Document _origin_json_doc; // origin json document object from parsed json string
+    char _value_buffer[4 * 1024 * 1024];

Review Comment:
   Does it seem that this class may/should/must not be declared as a stack variable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org