You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "TangSiyang2001 (via GitHub)" <gi...@apache.org> on 2023/06/28 02:57:18 UTC

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #21205: [enhancement](query) enable strong consistency by syncing max journal id from master

TangSiyang2001 commented on code in PR #21205:
URL: https://github.com/apache/doris/pull/21205#discussion_r1244604538


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SyncStmt.java:
##########
@@ -27,6 +27,6 @@ public void analyze(Analyzer analyzer) throws UserException {
 
     @Override
     public RedirectStatus getRedirectStatus() {

Review Comment:
   According to the discussion with @dataroaring , SyncStmt is better to reuse `syncJournal`, which sync meta equivalently to the previous way but a little bit lighter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org