You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/09 10:19:45 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
harikrishna-patnala opened a new issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
This is an improvement ticket in which volumes of a VM which are not intended to be deleted (when VM is tried to destroy) are going to be detached from VM during destroy VM operation.
CloudStack volumes are first-class citizens, they do not belong to a VM. Therefore data disks must be detached from the destroyed VM and either be expunged (if that is what the user requested) or be left detached and available for any volume actions - attach, expunge, extract, etc.
The existing behaviour is upon on destroy of VM (having datadisks) and data disks are not selected to delete, then during VM destroy these disks are still marked as attached to VM. Only during VM expunge of VM these volumes are detached from the VM.
Existing behaviour:
- When destroy VM without expunge and when no data disk is selected for deletion
VM is stopped and data disks will still shown as attached to original VM
When tried to recover the VM, the VM is made ready along with its data disks as before.
- When destroy VM without expunge and when one or more data disks are selected for deletion
VM is stopped and data disks which are selected for deletion will be deleted and other data disks will still remain attached
When tried to recover the VM, the VM is made ready along with remaining data disks which are not deleted
- When destroy VM with expunge and when no data disk is selected for deletion
All data disks are detached from VM
VM will be destroyed and expunged completely
- When destroy VM with expunge and few data disks are selected for deletion
Data disks marked for deletion are deleted and the remaining disks are detached from VM
VM will be destroyed and expunged completely.
Expected behaviour after improvement
- When destroy VM with expunge or without expunge and no data disk is selected for deletion
Data disks will be detached from VM during destroy VM itself
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
* Improvement Request
* Enhancement Request
* Feature Idea
* Documentation Report
* Other
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-901595019
Agree with @PaulAngus
@weizhouapache @PaulAngus @DaanHoogland I think Vmware 'as-is' VMs are not a problem, as the volumes cloned from the template are marked as ROOT volumes. Then all the additional data disks added by the user can be treated the same as regular (non-as-is) VM data disks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-902504878
Agree with everybody, or at least @PaulAngus , @weizhouapache and @nvazquez in their discussion above. @nvazquez you trigger a bit of a 'bear on the road'; if multiple `ROOT` disks are defined for a VM , will delete and recover work as expected for such a VM? (let alone if this is `deployAsIs` or not, because we will have that discussion as well, later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-820181740
+1 let's fix in the next major release. For consistency sake with other hypervisors, https://github.com/apache/cloudstack/pull/4493 can be merged to retain backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-890668874
@rhtyd @harikrishna-patnala can you please advise if this is still valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
weizhouapache closed issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-901044545
@PaulAngus great, thanks for your comment. agree with you.
we already support destroy/recover data disks (#3688), so the change will be simple.
@DaanHoogland could you please advice on how to proceed with volumes on vmware ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-887189073
@weizhouapache can you explore a fix for this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-818468895
I agree with you and @PaulAngus, @wido. From a conceptual/cloudstack paradigm point of view.
Some users of appliances might disagree though, and argue that a data disk installed by an appliance is an integral part of it. It seems to me we should think about that use-case as well. I'm not sure how common it is though and whether it matters to any ACS users.
just a heads-up. I agree with implementing as @harikrishna-patnala describes unless ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-900943432
@harikrishna-patnala @DaanHoogland @nvazquez
I am looking at this issue.
here are my opinions (based on previous discussions)
(1) destroy vm, selected data disks will be destroyed (and cleaned by cloudstack after some days), other data disks will be detached.
(2) destroy vm with expunge, selected data disks will be deleted, other data disks will be detached.
(3) expunge vm. all data disks will be detached
(4) recover vm, data disks will not be re-attached.
please correct me if I miss something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-923714190
fixed via #5356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-901013593
As mentioned by Wido and myself, data disks are considered first-class citizens. Therefore the first step when destroying a VM which has data disks attached, is to detach them. Obviously it is perfectly valid for the user to destroy them as well, either via an argument in the initial API command, as a separate API command, or via an option in the UI which calls the appropriate API(s).
Therefore, scenarios (1) and (2) should start 'detach data disks, destroy VM ... '. Scenario (3) is then simply 'Expunge VM'.
There then are four more actions:
- destroy data disk(s)
- recover data disks(s)
- expunge data disk(s)
- attach data disk(s) (to recovered VM or some other VM)
As Daan notes, 'As Is' VMs are a special case, where the data disk will often be considered a part of the VM. One could argue either way. One way of 'solving it' is to make it the operator's problem and add a global or even account setting to choose whether data disks are automatically destroyed for an 'As Is' VM or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-891094242
Thanks @harikrishna-patnala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-901013593
As mentioned by Wido and myself, data disks are considered first-class citizens. Therefore the first step when destroying a VM which has data disks attached, is to detach them. Obviously it is perfectly valid for the user to destroy them as well, either via an argument in the initial API command, as a separate API command, or via an option in the UI which calls the appropriate API(s).
Therefore, scenarios (1) and (2) should start 'detach data disks, destroy VM ... '. Scenario (3) is then simply 'Expunge VM'.
There then are four more actions:
- destroy data disk(s)
- recover data disks(s)
- expunge data disk(s)
- attach data disk(s) (to recovered VM or some other VM)
As Daan notes, 'As Is' VMs are a special case, where the data disk will often be considered a part of the VM. One could argue either way. One way of 'solving it' is to make it the operator's problem and add a global or even account setting to choose whether data disks are automatically destroyed for an 'As Is' VM or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-900943432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-890698538
This is valid based on the earlier discussions on PR #4462 and on this ticket, this is an improvement that we can take it up. We need a volunteer to work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-887427990
@rhtyd @harikrishna-patnala
your opinions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on issue #4902: Destroy VM should detach the volumes from VM and recover VM should not try to attach the volumes again
Posted by GitBox <gi...@apache.org>.
wido commented on issue #4902:
URL: https://github.com/apache/cloudstack/issues/4902#issuecomment-817342014
I agree 100% with this as @PaulAngus also mentioned in other threads.
Datadisks are not part of a VM, they are just attached to it. Upon destruction they should be detached and left alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org