[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5243: MAPREDUCE-7428. Fix failing MapReduce tests due to the JUnit upgrades in WebServicesTestUtils

[GitBox <gi...@apache.org>]

slfan1989 commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053258375


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##########
@@ -75,13 +73,12 @@ public static void createContainerLogFileInRemoteFS(Configuration conf,
     if (fs.exists(rootLogDirPath)) {
       fs.delete(rootLogDirPath, true);
     }
-    assertTrue(fs.mkdirs(rootLogDirPath));
+    fs.mkdirs(rootLogDirPath);
     Path appLogsDir = new Path(rootLogDirPath, appId.toString());
     if (fs.exists(appLogsDir)) {
       fs.delete(appLogsDir, true);
     }
-    assertTrue(fs.mkdirs(appLogsDir));
-
+    fs.mkdirs(appLogsDir);

Review Comment:
   Thanks a lot for asking, I think we should keep this `assertTrue`.
   
   We are currently experiencing some difficulties.
   
   `TestContainerLogsUtils.java` uses assertTrue of `org.junit.jupiter`, `hadoop-mapreduce-client-hs` and `hadoop-mapreduce-client-app` use `TestContainerLogsUtils.java`, `hadoop-mapreduce-client-hs` and `hadoop-mapreduce-client-app` These two modules have not upgraded the junit test, so when running the test, the classes cannot be found.
   
   `hadoop-mapreduce-client-hs` and `hadoop-mapreduce-client-app` may take some time to upgrade junit test.
   
   aajisaka's idea can quickly fix this problem without affecting the compilation of other modules.
   
   I will continue to follow up the `mapreduce` junit upgrade. If the mapreduce module junit upgrade is completed, I will change this back.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org