You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/11 14:08:19 UTC
[GitHub] [superset] jsoref opened a new pull request, #19648: chore: Spelling
jsoref opened a new pull request, #19648:
URL: https://github.com/apache/superset/pull/19648
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling).
The misspellings have been reported at https://github.com/jsoref/superset/commit/d28d76e51474f0fb3235705d0c1ae0757110300e#commitcomment-70995512
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/superset/commit/e50b893119c510d5bb2c8760c8b7a46f4ece3846
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
I'm aware that this PR is quite large, it also includes a couple of API changes (which probably won't be acceptable). I'll try to tag items
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160833113
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -127,7 +127,7 @@ class App extends React.PureComponent {
) {
this.showLocalStorageUsageWarning(
this.props.localStorageUsageInKilobytes,
- this.props.queries?.lenghth || 0,
+ this.props.queries?.length || 0,
Review Comment:
Whoa, interesting catch here.
CC @justinpark in case this poses any risk... or actually fixes something, since this line was ALWAYS returning 0 in its current implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160816250
##########
RELEASING/release-notes-2-0/changelog.md:
##########
@@ -314,7 +314,7 @@ under the License.
- [#19166](https://github.com/apache/superset/pull/19166) fix: time filter should be [start, end) (@zhaoyongjie)
**Others**
-- [#20116](https://github.com/apache/superset/pull/20116) style(typo): occured -> occurred (@sfirke)
+- [#20116](https://github.com/apache/superset/pull/20116) style(typo): occurred -> occurred (@sfirke)
Review Comment:
Yeah, this is an odd case where we'd _want_ the typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160830365
##########
superset-frontend/plugins/legacy-plugin-chart-paired-t-test/README.md:
##########
@@ -19,7 +19,7 @@ under the License.
## @superset-ui/legacy-plugin-chart-paired-t-test
-[](hhttps://www.npmjs.com/package/@superset-ui/legacy-plugin-chart-paired-t-test)
+[](not-https://www.npmjs.com/package/@superset-ui/legacy-plugin-chart-paired-t-test)
Review Comment:
```suggestion
[](https://www.npmjs.com/package/@superset-ui/legacy-plugin-chart-paired-t-test)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on pull request #19648: chore: Spelling
Posted by GitBox <gi...@apache.org>.
jsoref commented on PR #19648:
URL: https://github.com/apache/superset/pull/19648#issuecomment-1097420148
So, I've split these into pieces. Note that a couple conflict w/ each-other. I don't have the energy to deal w/ that now, but they're fairly trivial to deal w/ later.
Once each of the pieces are in, I'll rerun my tooling and see how things look and update this PR to pick up the pieces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160836283
##########
superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts:
##########
@@ -195,9 +195,9 @@ export function expandFilterOnLeftPanel() {
}
/** ************************************************************************
- * Collapes Native Filter from the left panel on dashboard
+ * Collapses Native Filter from the left panel on dashboard
* @returns {None}
- * @summary helper for collape native filter
+ * @summary helper for collapse native filter
Review Comment:
Dunno. It's also possible the one above just wants `Collapse` and not `Collapses`. It depends on whether it's a proper noun or prose. If it's propose, the `for` might be best change to `to`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160848945
##########
superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts:
##########
@@ -195,9 +195,9 @@ export function expandFilterOnLeftPanel() {
}
/** ************************************************************************
- * Collapes Native Filter from the left panel on dashboard
+ * Collapses Native Filter from the left panel on dashboard
* @returns {None}
- * @summary helper for collape native filter
+ * @summary helper for collapse native filter
Review Comment:
I've made a series of additional changes to this file. Including fixing another pair of typos -- https://github.com/jsoref/superset/commit/6fe4623925df39ce5defd96d54e943ac835d39ab.
Note that there are [~3k word-like tokens that I just accepted](https://github.com/check-spelling/superset/blob/13157cd3009b83897f034735b17bc1cad592191c/.github/actions/spelling/expect.txt) -- for smaller projects, I'll review each one, but for larger projects, I aim towards incremental improvement as opposed to absolute perfection :). I do encourage others to browse through them and see if any of the ones I skipped are also errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160848598
##########
superset/migrations/versions/2020-03-25_10-42_f9a30386bd74_cleanup_time_granularity.py:
##########
Review Comment:
Again, nervous about renaming these migrations... not sure if there's a real risk.
##########
tests/integration_tests/core_tests.py:
##########
@@ -615,7 +615,7 @@ def test_cache_logging(self):
app.config["STORE_CACHE_KEYS_IN_METADATA_DB"] = store_cache_keys
def test_redirect_invalid(self):
- model_url = models.Url(url="hhttp://invalid.com")
+ model_url = models.Url(url="not-http://invalid.com")
Review Comment:
```suggestion
model_url = models.Url(url="http://invalid.com")
```
##########
superset/migrations/versions/2017-02-08_14-16_a99f2f7c195a_rewriting_url_from_shortener_with_new_.py:
##########
Review Comment:
@dpgaspar @villebro I'm not sure if there's any risk in renaming a migration file like this. Do you know?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on a diff in pull request #19648: chore: Spelling
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160838582
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -127,7 +127,7 @@ class App extends React.PureComponent {
) {
this.showLocalStorageUsageWarning(
this.props.localStorageUsageInKilobytes,
- this.props.queries?.lenghth || 0,
+ this.props.queries?.length || 0,
Review Comment:
This value only uses for logging so not a huge critical. (Thanks for catching up. I found this issue when I queried the this new logging item first time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160889850
##########
tests/integration_tests/core_tests.py:
##########
@@ -615,7 +615,7 @@ def test_cache_logging(self):
app.config["STORE_CACHE_KEYS_IN_METADATA_DB"] = store_cache_keys
def test_redirect_invalid(self):
- model_url = models.Url(url="hhttp://invalid.com")
+ model_url = models.Url(url="not-http://invalid.com")
Review Comment:
Haha... I didn't even look at it that closely... then disregard my suggestion - your change is fine! I thought it was a really strange correction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by GitBox <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r847795104
##########
RELEASING/changelog.py:
##########
@@ -24,9 +24,9 @@
from click.core import Context
try:
- from github import BadCredentialsException, Github, PullRequest, Repository
+ from github import BadCredentialsException, GitHub, PullRequest, Repository
except ModuleNotFoundError:
- print("PyGithub is a required package for this script")
+ print("PyGitHub is a required package for this script")
exit(1)
Review Comment:
Tested.
Apparently the project does at least occasionally call itself **PyGitHub**:
https://github.com/PyGithub/PyGithub/blob/001970d4a828017f704f6744a5775b4207a6523c/README.md?plain=1#L1
But, the classes/exceptions/methods aren't exposed via the proper spelling, so I'll have to fix up this commit (dropping most of the Python bits, but keeping the change for line 29).
---
As an aside, I can't get `pip install -r ...` to work, it dies on my m1 trying to do stuff using numpy (amd64 stuff at that!!):
```
numpy/core/src/multiarray/scalartypes.c.src:2967:65: error: too few arguments to function call, expected 2, have 1
return _Py_HashDouble((double) PyArrayScalar_VAL(obj, Float));
~~~~~~~~~~~~~~ ^
```
I've tried a couple of versions of numpy and that didn't help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160836283
##########
superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts:
##########
@@ -195,9 +195,9 @@ export function expandFilterOnLeftPanel() {
}
/** ************************************************************************
- * Collapes Native Filter from the left panel on dashboard
+ * Collapses Native Filter from the left panel on dashboard
* @returns {None}
- * @summary helper for collape native filter
+ * @summary helper for collapse native filter
Review Comment:
Dunno. It's also possible the one above just wants `Collapse` and not `Collapses`. It depends on whether it's a proper noun or prose. If it's prose, the `for` might be best change to `to`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160819412
##########
docs/docs/installation/setup-ssh-tunneling.mdx:
##########
@@ -15,7 +15,7 @@ version: 1
2. Create database w/ ssh tunnel enabled
- With the feature flag enabled you should now see ssh tunnel toggle.
- Click the toggle to enables ssh tunneling and add your credentials accordingly.
- - Superset allows for 2 different type authenticaion (Basic + Private Key). These credentials should come from your service provider.
+ - Superset allows for 2 different type authentication (Basic + Private Key). These credentials should come from your service provider.
Review Comment:
```suggestion
- Superset allows for 2 different types of authentication (Basic + Private Key). These credentials should come from your service provider.
```
Worth getting the grammar nit while we're here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160818034
##########
docs/docs/contributing/translations.mdx:
##########
@@ -58,7 +58,7 @@ for your target language already exists in the `superset/translations` directory
ls superset/translations | grep -E "^[a-z]{2}\/"
```
-If your language already has a pre-existing translation, skip to the next section
+If your language already has a preexisting translation, skip to the next section
Review Comment:
I'm happy either way, but this one is a funny case! It depends on whether we're using the AP or Chicago style manuals ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a diff in pull request #19648: chore: Spelling
Posted by GitBox <gi...@apache.org>.
nytai commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r847761908
##########
RELEASING/changelog.py:
##########
@@ -24,9 +24,9 @@
from click.core import Context
try:
- from github import BadCredentialsException, Github, PullRequest, Repository
+ from github import BadCredentialsException, GitHub, PullRequest, Repository
except ModuleNotFoundError:
- print("PyGithub is a required package for this script")
+ print("PyGitHub is a required package for this script")
exit(1)
Review Comment:
can you check that this change actually works by installing pygithub and trying to import that class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by GitBox <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r847371946
##########
CONTRIBUTING.md:
##########
@@ -661,7 +661,7 @@ We use [Pylint](https://pylint.org/) for linting which can be invoked via:
tox -e pylint
```
-In terms of best practices please advoid blanket disablement of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disablement should occur inline as it prevents masking issues and provides context as to why said message is disabled.
+In terms of best practices please avoid blanket disablement of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disablement should occur inline as it prevents masking issues and provides context as to why said message is disabled.
Review Comment:
Note: this PR is generally limited to spelling (including duplicate words). Grammatically, `disabling` would be better than `disablement`.
##########
RELEASING/release-notes-1-2/README.md:
##########
@@ -87,7 +87,7 @@ Expanding the API has been an ongoing effort, and 1.2 introduces several new API
- [14461](https://github.com/apache/superset/pull/14461) feat(native-filters): Auto apply changes in FiltersConfigModal (#14461) (@simcha90)
- [13507](https://github.com/apache/superset/pull/13507) feat(native-filters): Filter set tabs (#13507) (@simcha90)
- [14313](https://github.com/apache/superset/pull/14313) feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters (#14313) (@Kamil Gabryjelski)
-- [14261](https://github.com/apache/superset/pull/14261) feat(native-filters): Show/Hide filter bar by metdata ff (#14261) (@simcha90)
+- [14261](https://github.com/apache/superset/pull/14261) feat(native-filters): Show/Hide filter bar by metadata ff (#14261) (@simcha90)
Review Comment:
Some projects don't like changing release notes. Let me know if this is such a project, it's trivial for me to ignore files/paths.
##########
docs/docs/miscellaneous/chart-params.mdx:
##########
@@ -18,7 +18,7 @@ Note not all fields are correctly categorized. The fields vary based on visualiz
| Field | Type | Notes |
| ----------------- | -------- | ----------------------------------- |
| `database_name` | _string_ | _Deprecated?_ |
-| `datasource` | _string_ | `<datasouce_id>__<datasource_type>` |
+| `datasource` | _string_ | `<datasource_id>__<datasource_type>` |
Review Comment:
I can reset table widths, but I'd rather wait until other basics are agreed upon before I do it.
##########
helm/superset/Chart.yaml:
##########
@@ -22,7 +22,7 @@ maintainers:
- name: craig-rueda
email: craig@craigrueda.com
url: https://github.com/craig-rueda
-version: 0.5.11
+version: 0.5.12
Review Comment:
The linter made me do this
##########
superset-frontend/packages/superset-ui-core/src/query/normalizeOrderBy.ts:
##########
@@ -56,7 +56,7 @@ export default function normalizeOrderBy(
};
}
- // todo: Removed `legacy_ordery_by` after refactoring
+ // todo: Removed `legacy_order_by` after refactoring
if (
queryObject.legacy_order_by !== undefined &&
queryObject.legacy_order_by !== null &&
Review Comment:
I checked and this was committed as a set, it looks like it was a combination of `order`+`by` twice, but w/ the final decision to be having a `_` between the words.
##########
superset-frontend/packages/superset-ui-core/src/number-format/README.md:
##########
@@ -68,7 +68,7 @@ There is also a formatter based on [pretty-ms](https://www.npmjs.com/package/pre
used to format time durations:
```js
-import { createDurationFormatter, formatNumber, getNumberFormatterRegistry } from from '@superset-ui-number-format';
+import { createDurationFormatter, formatNumber, getNumberFormatterRegistry } from '@superset-ui-number-format';
Review Comment:
This is an important flag of the duplicate word item, because it's in user facing documentation, and the documentation is wrong (but it isn't checked because no compiler checks code samples in docs).
##########
superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx:
##########
@@ -112,7 +112,7 @@ fetchMock.get('glob:*/api/v1/dashboard/26', {
json_metadata: mockedJsonMetadata,
owners: [],
position_json:
- '{"CHART-63bEuxjDMJ": {"children": [], "id": "CHART-63bEuxjDMJ", "meta": {"chartId": 369, "height": 76, "sliceName": "Vaccine Candidates per Country", "sliceNameOverride": "Map of Vaccine Candidates", "uuid": "ddc91df6-fb40-4826-bdca-16b85af1c024", "width": 7}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zvw7luvEL"], "type": "CHART"}, "CHART-F-fkth0Dnv": {"children": [], "id": "CHART-F-fkth0Dnv", "meta": {"chartId": 314, "height": 76, "sliceName": "Vaccine Candidates per Country", "sliceNameOverride": "Treemap of Vaccine Candidates per Country", "uuid": "e2f5a8a7-feb0-4f79-bc6b-01fe55b98b3c", "width": 5}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zvw7luvEL"], "type": "CHART"}, "CHART-RjD_ygqtwH": {"children": [], "id": "CHART-RjD_ygqtwH", "meta": {"chartId": 351, "height": 59, "sliceName": "Vaccine Candidates per Phase", "sliceNameOverride": "Vaccine Candidates per Phase", "uuid": "30b73c65-85e7-455f-bb24-801bb0cdc670", "width": 2}
, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-xSeNAspgw"], "type": "CHART"}, "CHART-aGfmWtliqA": {"children": [], "id": "CHART-aGfmWtliqA", "meta": {"chartId": 312, "height": 59, "sliceName": "Vaccine Candidates per Phase", "uuid": "392f293e-0892-4316-bd41-c927b65606a4", "width": 4}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-xSeNAspgw"], "type": "CHART"}, "CHART-dCUpAcPsji": {"children": [], "id": "CHART-dCUpAcPsji", "meta": {"chartId": 325, "height": 82, "sliceName": "Vaccine Candidates per Country & Stage", "sliceNameOverride": "Heatmap of Countries & Clinical Stages", "uuid": "cd111331-d286-4258-9020-c7949a109ed2", "width": 4}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zhOlQLQnB"], "type": "CHART"}, "CHART-eirDduqb1A": {"children": [], "id": "CHART-eirDduqb1A", "meta": {"chartId": 358, "height": 59, "sliceName": "Filtering Vaccines", "sliceNameOverride": "Filter Box of Vaccines", "uuid": "c29381ce-0e99-4cf3-bf0f-5
f55d6b94176", "width": 3}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-xSeNAspgw"], "type": "CHART"}, "CHART-fYo7IyvKZQ": {"children": [], "id": "CHART-fYo7IyvKZQ", "meta": {"chartId": 371, "height": 82, "sliceName": "Vaccine Candidates per Country & Stage", "sliceNameOverride": "Sunburst of Country & Clinical Stages", "uuid": "f69c556f-15fe-4a82-a8bb-69d5b6954123", "width": 5}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zhOlQLQnB"], "type": "CHART"}, "CHART-j4hUvP5dDD": {"children": [], "id": "CHART-j4hUvP5dDD", "meta": {"chartId": 364, "height": 82, "sliceName": "Vaccine Candidates per Approach & Stage", "sliceNameOverride": "Heatmap of Aproaches & Clinical Stages", "uuid": "0c953c84-0c9a-418d-be9f-2894d2a2cee0", "width": 3}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zhOlQLQnB"], "type": "CHART"}, "DASHBOARD_VERSION_KEY": "v2", "GRID_ID": {"children": [], "id": "GRID_ID", "parents": ["ROOT_ID"], "type": "GRID"}, "HE
ADER_ID": {"id": "HEADER_ID", "meta": {"text": "COVID Vaccine Dashboard"}, "type": "HEADER"}, "MARKDOWN-VjQQ5SFj5v": {"children": [], "id": "MARKDOWN-VjQQ5SFj5v", "meta": {"code": "# COVID-19 Vaccine Dashboard\\n\\nEverywhere you look, you see negative news about COVID-19. This is to be expected; it\'s been a brutal year and this disease is no joke. This dashboard hopes to use visualization to inject some optimism about the coming return to normalcy we enjoyed before 2020! There\'s lots to be optimistic about:\\n\\n- the sheer volume of attempts to fund the R&D needed to produce and bring an effective vaccine to market\\n- the large number of countries involved in at least one vaccine candidate (and the diversity of economic status of these countries)\\n- the diversity of vaccine approaches taken\\n- the fact that 2 vaccines have already been approved (and a hundreds of thousands of patients have already been vaccinated)\\n\\n### The Dataset\\n\\nThis dashboard is powered by data ma
intained by the Millken Institute ([link to dataset](https://airtable.com/shrSAi6t5WFwqo3GM/tblEzPQS5fnc0FHYR/viwDBH7b6FjmIBX5x?blocks=bipZFzhJ7wHPv7x9z)). We researched each vaccine candidate and added our own best guesses for the country responsible for each vaccine effort.\\n\\n_Note that this dataset was last updated on 12/23/2020_.\\n\\n", "height": 59, "width": 3}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-xSeNAspgw"], "type": "MARKDOWN"}, "ROOT_ID": {"children": ["TABS-wUKya7eQ0Z"], "id": "ROOT_ID", "type": "ROOT"}, "ROW-xSeNAspgw": {"children": ["MARKDOWN-VjQQ5SFj5v", "CHART-aGfmWtliqA", "CHART-RjD_ygqtwH", "CHART-eirDduqb1A"], "id": "ROW-xSeNAspgw", "meta": {"0": "ROOT_ID", "background": "BACKGROUND_TRANSPARENT"}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ"], "type": "ROW"}, "ROW-zhOlQLQnB": {"children": ["CHART-j4hUvP5dDD", "CHART-dCUpAcPsji", "CHART-fYo7IyvKZQ"], "id": "ROW-zhOlQLQnB", "meta": {"0": "ROOT_ID", "background": "BACKGROUN
D_TRANSPARENT"}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ"], "type": "ROW"}, "ROW-zvw7luvEL": {"children": ["CHART-63bEuxjDMJ", "CHART-F-fkth0Dnv"], "id": "ROW-zvw7luvEL", "meta": {"0": "ROOT_ID", "background": "BACKGROUND_TRANSPARENT"}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ"], "type": "ROW"}, "TAB-BCIJF4NvgQ": {"children": ["ROW-xSeNAspgw", "ROW-zvw7luvEL", "ROW-zhOlQLQnB"], "id": "TAB-BCIJF4NvgQ", "meta": {"text": "Overview"}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z"], "type": "TAB"}, "TABS-wUKya7eQ0Z": {"children": ["TAB-BCIJF4NvgQ"], "id": "TABS-wUKya7eQ0Z", "meta": {}, "parents": ["ROOT_ID"], "type": "TABS"}}',
+ '{"CHART-63bEuxjDMJ": {"children": [], "id": "CHART-63bEuxjDMJ", "meta": {"chartId": 369, "height": 76, "sliceName": "Vaccine Candidates per Country", "sliceNameOverride": "Map of Vaccine Candidates", "uuid": "ddc91df6-fb40-4826-bdca-16b85af1c024", "width": 7}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zvw7luvEL"], "type": "CHART"}, "CHART-F-fkth0Dnv": {"children": [], "id": "CHART-F-fkth0Dnv", "meta": {"chartId": 314, "height": 76, "sliceName": "Vaccine Candidates per Country", "sliceNameOverride": "Treemap of Vaccine Candidates per Country", "uuid": "e2f5a8a7-feb0-4f79-bc6b-01fe55b98b3c", "width": 5}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zvw7luvEL"], "type": "CHART"}, "CHART-RjD_ygqtwH": {"children": [], "id": "CHART-RjD_ygqtwH", "meta": {"chartId": 351, "height": 59, "sliceName": "Vaccine Candidates per Phase", "sliceNameOverride": "Vaccine Candidates per Phase", "uuid": "30b73c65-85e7-455f-bb24-801bb0cdc670", "width": 2}
, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-xSeNAspgw"], "type": "CHART"}, "CHART-aGfmWtliqA": {"children": [], "id": "CHART-aGfmWtliqA", "meta": {"chartId": 312, "height": 59, "sliceName": "Vaccine Candidates per Phase", "uuid": "392f293e-0892-4316-bd41-c927b65606a4", "width": 4}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-xSeNAspgw"], "type": "CHART"}, "CHART-dCUpAcPsji": {"children": [], "id": "CHART-dCUpAcPsji", "meta": {"chartId": 325, "height": 82, "sliceName": "Vaccine Candidates per Country & Stage", "sliceNameOverride": "Heatmap of Countries & Clinical Stages", "uuid": "cd111331-d286-4258-9020-c7949a109ed2", "width": 4}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zhOlQLQnB"], "type": "CHART"}, "CHART-eirDduqb1A": {"children": [], "id": "CHART-eirDduqb1A", "meta": {"chartId": 358, "height": 59, "sliceName": "Filtering Vaccines", "sliceNameOverride": "Filter Box of Vaccines", "uuid": "c29381ce-0e99-4cf3-bf0f-5
f55d6b94176", "width": 3}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-xSeNAspgw"], "type": "CHART"}, "CHART-fYo7IyvKZQ": {"children": [], "id": "CHART-fYo7IyvKZQ", "meta": {"chartId": 371, "height": 82, "sliceName": "Vaccine Candidates per Country & Stage", "sliceNameOverride": "Sunburst of Country & Clinical Stages", "uuid": "f69c556f-15fe-4a82-a8bb-69d5b6954123", "width": 5}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zhOlQLQnB"], "type": "CHART"}, "CHART-j4hUvP5dDD": {"children": [], "id": "CHART-j4hUvP5dDD", "meta": {"chartId": 364, "height": 82, "sliceName": "Vaccine Candidates per Approach & Stage", "sliceNameOverride": "Heatmap of Approaches & Clinical Stages", "uuid": "0c953c84-0c9a-418d-be9f-2894d2a2cee0", "width": 3}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-zhOlQLQnB"], "type": "CHART"}, "DASHBOARD_VERSION_KEY": "v2", "GRID_ID": {"children": [], "id": "GRID_ID", "parents": ["ROOT_ID"], "type": "GRID"}, "H
EADER_ID": {"id": "HEADER_ID", "meta": {"text": "COVID Vaccine Dashboard"}, "type": "HEADER"}, "MARKDOWN-VjQQ5SFj5v": {"children": [], "id": "MARKDOWN-VjQQ5SFj5v", "meta": {"code": "# COVID-19 Vaccine Dashboard\\n\\nEverywhere you look, you see negative news about COVID-19. This is to be expected; it\'s been a brutal year and this disease is no joke. This dashboard hopes to use visualization to inject some optimism about the coming return to normalcy we enjoyed before 2020! There\'s lots to be optimistic about:\\n\\n- the sheer volume of attempts to fund the R&D needed to produce and bring an effective vaccine to market\\n- the large number of countries involved in at least one vaccine candidate (and the diversity of economic status of these countries)\\n- the diversity of vaccine approaches taken\\n- the fact that 2 vaccines have already been approved (and a hundreds of thousands of patients have already been vaccinated)\\n\\n### The Dataset\\n\\nThis dashboard is powered by data m
aintained by the Millken Institute ([link to dataset](https://airtable.com/shrSAi6t5WFwqo3GM/tblEzPQS5fnc0FHYR/viwDBH7b6FjmIBX5x?blocks=bipZFzhJ7wHPv7x9z)). We researched each vaccine candidate and added our own best guesses for the country responsible for each vaccine effort.\\n\\n_Note that this dataset was last updated on 12/23/2020_.\\n\\n", "height": 59, "width": 3}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ", "ROW-xSeNAspgw"], "type": "MARKDOWN"}, "ROOT_ID": {"children": ["TABS-wUKya7eQ0Z"], "id": "ROOT_ID", "type": "ROOT"}, "ROW-xSeNAspgw": {"children": ["MARKDOWN-VjQQ5SFj5v", "CHART-aGfmWtliqA", "CHART-RjD_ygqtwH", "CHART-eirDduqb1A"], "id": "ROW-xSeNAspgw", "meta": {"0": "ROOT_ID", "background": "BACKGROUND_TRANSPARENT"}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ"], "type": "ROW"}, "ROW-zhOlQLQnB": {"children": ["CHART-j4hUvP5dDD", "CHART-dCUpAcPsji", "CHART-fYo7IyvKZQ"], "id": "ROW-zhOlQLQnB", "meta": {"0": "ROOT_ID", "background": "BACKGROU
ND_TRANSPARENT"}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ"], "type": "ROW"}, "ROW-zvw7luvEL": {"children": ["CHART-63bEuxjDMJ", "CHART-F-fkth0Dnv"], "id": "ROW-zvw7luvEL", "meta": {"0": "ROOT_ID", "background": "BACKGROUND_TRANSPARENT"}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z", "TAB-BCIJF4NvgQ"], "type": "ROW"}, "TAB-BCIJF4NvgQ": {"children": ["ROW-xSeNAspgw", "ROW-zvw7luvEL", "ROW-zhOlQLQnB"], "id": "TAB-BCIJF4NvgQ", "meta": {"text": "Overview"}, "parents": ["ROOT_ID", "TABS-wUKya7eQ0Z"], "type": "TAB"}, "TABS-wUKya7eQ0Z": {"children": ["TAB-BCIJF4NvgQ"], "id": "TABS-wUKya7eQ0Z", "meta": {}, "parents": ["ROOT_ID"], "type": "TABS"}}',
Review Comment:
```diff
-Aproaches
+Approaches
```
##########
superset-frontend/src/explore/components/Control.test.tsx:
##########
@@ -61,7 +61,7 @@ describe('Control', () => {
it('render null if type is not valid', () => {
render(
setup({
- type: 'UnkownControl',
+ type: 'UnknownControl',
Review Comment:
?
##########
superset-frontend/src/views/components/types.ts:
##########
@@ -19,7 +19,7 @@
import { NavBarProps, MenuObjectProps } from './Menu';
-export interface ExtentionConfigs {
+export interface ExtensionConfigs {
Review Comment:
API break
##########
docs/src/resources/data.js:
##########
@@ -106,7 +106,7 @@ export const Databases = [
{
title: 'SQLite',
href: 'https://www.sqlite.org/index.html',
- imgName: 'sqllite.png',
+ imgName: 'sqlite.png',
Review Comment:
I missed renaming this file, but it's a brand so it should have the name I'm selecting.
##########
RELEASING/release-notes-1-4/README.md:
##########
@@ -19,7 +19,7 @@ under the License.
# Release Notes for Superset 1.4
-Superset 1.4 focuses heavily on continuing to polish the core Superset experience. This release has a very very long list of fixes from across the community.
+Superset 1.4 focuses heavily on continuing to polish the core Superset experience. This release has a very long list of fixes from across the community.
Review Comment:
I'm happy to drop this, but I don't think it added any real value. (I left one really long duplicate item.)
##########
RELEASING/Dockerfile.from_local_tarball:
##########
@@ -24,7 +24,7 @@ ENV LANG=C.UTF-8 \
RUN apt-get update -y
-# Install dependencies to fix `curl https support error` and `elaying package configuration warning`
+# Install dependencies to fix `curl https support error` and `delaying package configuration warning`
Review Comment:
When I saw this item flagged I guessed `relaying`, I was wrong.
##########
superset/viz.py:
##########
@@ -449,7 +449,7 @@ def cache_key(self, query_obj: QueryObjectDict, **extra: Any) -> str:
"5 days ago" or "now").
The `extra` arguments are currently used by time shift queries, since
- different time shifts wil differ only in the `from_dttm`, `to_dttm`,
+ different time shifts will differ only in the `from_dttm`, `to_dttm`,
Review Comment:
Some projects actually have a `wil`, but I think this is just a typo
##########
UPDATING.md:
##########
@@ -25,7 +25,7 @@ assists people when migrating to a new version.
## Next
- [19046](https://github.com/apache/superset/pull/19046): Enables the drag and drop interface in Explore control panel by default. Flips `ENABLE_EXPLORE_DRAG_AND_DROP` and `ENABLE_DND_WITH_CLICK_UX` feature flags to `True`.
-- [18936](https://github.com/apache/superset/pull/18936): Removes legacy SIP-15 interm logic/flags—specifically the `SIP_15_ENABLED`, `SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and `SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the start and exclusive of the end. Additionally this change removes the now obsolete `time_range_endpoints` from the form-data and resulting in the cache being busted.
+- [18936](https://github.com/apache/superset/pull/18936): Removes legacy SIP-15 interim logic/flags—specifically the `SIP_15_ENABLED`, `SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and `SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the start and exclusive of the end. Additionally this change removes the now obsolete `time_range_endpoints` from the form-data and resulting in the cache being busted.
Review Comment:
?
##########
superset-frontend/packages/superset-ui-core/src/math-expression/index.ts:
##########
@@ -106,7 +106,7 @@ export function evalExpression(expression: string, value: number): number {
const subExpressions = String(parsedExpression).split('=');
parsedExpression = subExpressions[1] ?? subExpressions[0];
// we can ignore the type requirement on `TOKENS`, as value is always `number`
- // and doesn't need to consider `number | underfined`.
+ // and doesn't need to consider `number | undefined`.
Review Comment:
probably?
##########
RELEASING/changelog.py:
##########
@@ -24,9 +24,9 @@
from click.core import Context
try:
- from github import BadCredentialsException, Github, PullRequest, Repository
+ from github import BadCredentialsException, GitHub, PullRequest, Repository
except ModuleNotFoundError:
- print("PyGithub is a required package for this script")
+ print("PyGitHub is a required package for this script")
exit(1)
Review Comment:
If these are third party modules, then these changes will break. It's trivial for me to drop individual change families although I'll probably try to carefully tease out the text and noncode instances of GitHub.
##########
superset-frontend/cypress-base/cypress/integration/dashboard/key_value.test.ts:
##########
@@ -27,7 +27,7 @@ interface QueryString {
native_filters_key: string;
}
-xdescribe('nativefiler url param key', () => {
+xdescribe('nativefilter url param key', () => {
Review Comment:
?
##########
tests/integration_tests/event_logger_tests.py:
##########
@@ -179,7 +179,7 @@ def log(
duration=timedelta(days=64, seconds=29156, microseconds=10),
object_ref={"baz": "food"},
log_to_statsd=False,
- payload_override={"engine": "sqllite"},
+ payload_override={"engine": "sqlite"},
Review Comment:
?
##########
CODE_OF_CONDUCT.md:
##########
@@ -119,7 +119,7 @@ If you decide to join the [Community Slack](https://join.slack.com/t/apache-supe
**3. Ask thoughtful questions.**
-- We’re all here to help each other out. The best way to get help is by investing effort into your questions. First check and see if your question is answered in [the Superset documentation](https://superset.apache.org/faq.html) or on [Stack Overflow](https://stackoverflow.com/search?q=apache+superset). You can also check [Github issues](https://github.com/apache/superset/issues) to see if your question or feature request has been submitted before. Then, use Slack search to see if your question has already been asked and answered in the past. If you still feel the need to ask a question, make sure you include:
+- We’re all here to help each other out. The best way to get help is by investing effort into your questions. First check and see if your question is answered in [the Superset documentation](https://superset.apache.org/faq.html) or on [Stack Overflow](https://stackoverflow.com/search?q=apache+superset). You can also check [GitHub issues](https://github.com/apache/superset/issues) to see if your question or feature request has been submitted before. Then, use Slack search to see if your question has already been asked and answered in the past. If you still feel the need to ask a question, make sure you include:
Review Comment:
Brand
##########
UPDATING.md:
##########
@@ -221,7 +221,7 @@ flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in conf
- [10324](https://github.com/apache/superset/pull/10324): Facebook Prophet has been introduced as an optional dependency to add support for timeseries forecasting in the chart data API. To enable this feature, install Superset with the optional dependency `prophet` or directly `pip install fbprophet`.
-- [10320](https://github.com/apache/superset/pull/10320): References to blacklst/whitelist language have been replaced with more appropriate alternatives. All configs refencing containing `WHITE`/`BLACK` have been replaced with `ALLOW`/`DENY`. Affected config variables that need to be updated: `TIME_GRAIN_BLACKLIST`, `VIZ_TYPE_BLACKLIST`, `DRUID_DATA_SOURCE_BLACKLIST`.
+- [10320](https://github.com/apache/superset/pull/10320): References to blacklist/whitelist language have been replaced with more appropriate alternatives. All configs referencing containing `WHITE`/`BLACK` have been replaced with `ALLOW`/`DENY`. Affected config variables that need to be updated: `TIME_GRAIN_BLACKLIST`, `VIZ_TYPE_BLACKLIST`, `DRUID_DATA_SOURCE_BLACKLIST`.
Review Comment:
I appreciate the improvements, but I don't think the typo here was intended to avoid including one instance given that there are a number of the term in this line.
##########
superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/Area/stories/controlsShown.tsx:
##########
@@ -31,7 +31,7 @@ export const controlsShown = () => (
queriesData={[{ data }]}
formData={{
bottomMargin: 'auto',
- colorCcheme: 'd3Category10',
+ colorScheme: 'd3Category10',
Review Comment:
This is interesting
##########
docs/docs/installation/configuring-superset.mdx:
##########
@@ -99,7 +99,7 @@ If you're not using Gunicorn, you may want to disable the use of `flask-compress
If you are running superset behind a load balancer or reverse proxy (e.g. NGINX or ELB on AWS), you
may need to utilize a healthcheck endpoint so that your load balancer knows if your superset
instance is running. This is provided at `/health` which will return a 200 response containing “OK”
-if the the webserver is running.
+if the webserver is running.
Review Comment:
This is a doubled word, it's a fairly new feature of my tooling, and I'm generally fairly happy w/ the items it flags.
##########
superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/src/ReactParallelCoordinates.jsx:
##########
@@ -23,17 +23,17 @@ import Component from './ParallelCoordinates';
const ReactComponent = reactify(Component);
-const ParallelCoordianes = ({ className, ...otherProps }) => (
+const ParallelCoordinates = ({ className, ...otherProps }) => (
<div className={className}>
<ReactComponent {...otherProps} />
</div>
);
-ParallelCoordianes.propTypes = {
+ParallelCoordinates.propTypes = {
className: PropTypes.string.isRequired,
};
-export default styled(ParallelCoordianes)`
+export default styled(ParallelCoordinates)`
Review Comment:
API change?
##########
superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-chart/SuperChartStories.tsx:
##########
@@ -110,7 +110,7 @@ export const fixedHeight100Width = () => {
};
fixedHeight100Width.story = { name: 'fixed height, 100% width' };
-export const withErrorBoundar = () => {
+export const withErrorBoundary = () => {
Review Comment:
API break
##########
superset-frontend/packages/superset-ui-core/src/query/types/AdvancedAnalytics.ts:
##########
@@ -29,15 +29,15 @@ export interface RollingWindow {
min_periods?: number;
}
-export enum ComparisionType {
+export enum ComparisonType {
Values = 'values',
Difference = 'difference',
Percentage = 'percentage',
Ratio = 'ratio',
}
export interface TimeCompare {
time_compare?: string;
- comparison_type?: ComparisionType;
+ comparison_type?: ComparisonType;
Review Comment:
This is an API break
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -93,7 +93,7 @@ describe('plugin-chart-table', () => {
<TableChart {...transformProps(testData.advanced)} sticky={false} />,
);
tree = wrap.render();
- // should successfull rerender with new props
+ // should successful rerender with new props
Review Comment:
This should probably be successfully
##########
superset-frontend/src/preamble.ts:
##########
@@ -25,7 +25,7 @@ import { merge } from 'lodash';
import setupClient from './setup/setupClient';
import setupColors from './setup/setupColors';
import setupFormatters from './setup/setupFormatters';
-import setupDashboardComponents from './setup/setupDasboardComponents';
+import setupDashboardComponents from './setup/setupDashboardComponents';
Review Comment:
Renamed below:
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils/fitViewport.ts:
##########
@@ -21,7 +21,7 @@ import computeBoundsFromPoints from './computeBoundsFromPoints';
import { Point } from '../types';
export type Viewport = {
- longtitude: number;
+ longitude: number;
Review Comment:
API change?
##########
superset-frontend/src/dashboard/util/filterboxMigrationHelper.ts:
##########
@@ -75,7 +75,7 @@ interface PreselectedFilterColumn {
[key: string]: boolean | string | number | string[] | number[];
}
-interface PreselectedFiltersMeatadata {
+interface PreselectedFiltersMetadata {
Review Comment:
API break?
##########
superset-frontend/src/views/CRUD/data/database/DatabaseList.tsx:
##########
@@ -166,7 +166,7 @@ function DatabaseList({ addDangerToast, addSuccessToast }: DatabaseListProps) {
const uploadDropdownMenu = [
{
label: t('Upload file to database'),
- childs: [
+ children: [
Review Comment:
Probably an api break.
##########
superset/cli/importexport.py:
##########
@@ -66,7 +66,7 @@ def import_directory(directory: str, overwrite: bool, force: bool) -> None:
@click.option(
"--dashboard-file",
"-f",
- help="Specify the the file to export to",
+ help="Specify the file to export to",
Review Comment:
This is public facing of some sort
##########
superset/dashboards/filter_sets/commands/base.py:
##########
@@ -20,7 +20,7 @@
from flask_appbuilder.models.sqla import Model
from flask_appbuilder.security.sqla.models import User
-from superset.common.not_authrized_object import NotAuthorizedException
+from superset.common.not_authorized_object import NotAuthorizedException
Review Comment:
This file was renamed above
##########
superset/connectors/sqla/models.py:
##########
@@ -1158,7 +1158,7 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma
if metrics_exprs:
main_metric_expr = metrics_exprs[0]
else:
- main_metric_expr, label = literal_column("COUNT(*)"), "ccount"
+ main_metric_expr, label = literal_column("COUNT(*)"), "count"
Review Comment:
This is a notable change. I'm not certain about it.
##########
superset/examples/configs/datasets/examples/FCC_2018_Survey.yaml:
##########
@@ -930,7 +930,7 @@ columns:
expression: null
description: null
python_date_format: null
-- column_name: rsrc_pluralsght
+- column_name: rsrc_pluralsight
Review Comment:
At a certain point, I decided not to rename most of the `column_name` fields from files like this.
I'm not sure if I should/shouldn't.
##########
superset/examples/configs/charts/Messages_per_Channel.yaml:
##########
@@ -50,7 +50,7 @@ params:
dashboards: '#3CCCCB'
design: '#1FA8C9'
developers: '#9EE5E5'
- embedd-dashboards: '#ACE1C4'
+ embedded-dashboards: '#ACE1C4'
Review Comment:
I can't tell if this should be `embed-dashboards` or `embedded-dashboards`. I think I'm right.
##########
superset/migrations/versions/4736ec66ce19_.py:
##########
@@ -124,7 +124,7 @@ def upgrade():
logging.warning(
"Constraint drop failed, you may want to do this "
"manually on your database. For context, this is a known "
- "issue around undeterministic contraint names on Postgres "
+ "issue around nondeterministic constraint names on Postgres "
Review Comment:
Notable change
##########
superset/reports/schemas.py:
##########
@@ -84,7 +84,7 @@
"Superset nags you again. (in seconds)"
)
working_timeout_description = (
- "If an alert is staled at a working state, how long until it's state is reseted to"
+ "If an alert is staled at a working state, how long until its state is reset to"
Review Comment:
As noted earlier, I'm generally not dealing w/ grammar, I made this change to `it's` because I was going to make the change to `reset` and my tooling cares about order. I have not checked the rest of the repo for `it's`/`its`, but i'm sure there are plenty of instances where it's missued, misuse of its is fairly comment everywhere.
##########
superset/examples/multiformat_time_series.py:
##########
@@ -97,7 +97,7 @@ def load_multiformat_time_series( # pylint: disable=too-many-locals
for col in obj.columns:
dttm_and_expr = dttm_and_expr_dict[col.column_name]
col.python_date_format = dttm_and_expr[0]
- col.dbatabase_expr = dttm_and_expr[1]
+ col.database_expr = dttm_and_expr[1]
Review Comment:
Not sure about this.
Possibly an api break
##########
superset/utils/core.py:
##########
@@ -128,7 +128,7 @@
NO_TIME_RANGE = "No filter"
-TIME_COMPARISION = "__"
+TIME_COMPARISON = "__"
Review Comment:
API change
##########
superset/utils/core.py:
##########
@@ -332,7 +332,7 @@ class TemporalType(str, Enum):
class ColumnTypeSource(Enum):
GET_TABLE = 1
- CURSOR_DESCRIPION = 2
+ CURSOR_DESCRIPTION = 2
Review Comment:
API change
##########
tests/integration_tests/annotation_layers/fixtures.py:
##########
@@ -73,7 +73,7 @@ def _insert_annotation(
def create_annotation_layers():
"""
Creates ANNOTATION_LAYERS_COUNT-1 layers with no annotations
- and a final one with ANNOTATION_COUNT childs
+ and a final one with ANNOTATION_COUNT children
Review Comment:
?
##########
superset/views/base_api.py:
##########
@@ -66,7 +66,7 @@ class DistinctResultResponseSchema(Schema):
text = fields.String(description="The distinct item")
-class DistincResponseSchema(Schema):
+class DistinctResponseSchema(Schema):
Review Comment:
API break
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160815279
##########
RELEASING/changelog.py:
##########
@@ -78,7 +78,7 @@ def __init__(
self._github_prs: Dict[int, Any] = {}
self._wait = 10
github_token = access_token or os.environ.get("GITHUB_TOKEN")
- self._github = Github(github_token)
+ self._github = GitHub(github_token)
Review Comment:
This should be `Github` as well, as I'm sure you noticed already :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19648: chore: Spelling
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19648:
URL: https://github.com/apache/superset/pull/19648#issuecomment-1500703415
@rusackas Ephemeral environment spinning up at http://54.191.2.216:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19648:
URL: https://github.com/apache/superset/pull/19648#issuecomment-1500702655
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160886652
##########
CONTRIBUTING.md:
##########
@@ -661,7 +661,7 @@ We use [Pylint](https://pylint.org/) for linting which can be invoked via:
tox -e pylint
```
-In terms of best practices please advoid blanket disablement of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disablement should occur inline as it prevents masking issues and provides context as to why said message is disabled.
+In terms of best practices please avoid blanket disablement of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disablement should occur inline as it prevents masking issues and provides context as to why said message is disabled.
Review Comment:
Agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160851988
##########
superset/advanced_data_type/plugins/internet_address.py:
##########
@@ -1,10 +1,10 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
-# regarding coperatoryright ownership. The ASF licenses this file
+# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
-# with the License. You may obtain a coperatory of the License at
+# with the License. You may obtain a copy of the License at
Review Comment:
Wow, yeah, I'm not sure what exactly happened there. Looks like you caught both instances though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160813117
##########
CONTRIBUTING.md:
##########
@@ -170,7 +170,7 @@ articles. See [Documentation](#documentation) for more details.
### Add Translations
If you are proficient in a non-English language, you can help translate
-text strings from Superset's UI. You can jump in to the existing
+text strings from Superset's UI. You can jump into the existing
Review Comment:
Seems acceptable to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160854453
##########
tests/integration_tests/core_tests.py:
##########
@@ -615,7 +615,7 @@ def test_cache_logging(self):
app.config["STORE_CACHE_KEYS_IN_METADATA_DB"] = store_cache_keys
def test_redirect_invalid(self):
- model_url = models.Url(url="hhttp://invalid.com")
+ model_url = models.Url(url="not-http://invalid.com")
Review Comment:
I think it's actually trying to test w/ an invalid protocol.
If it isn't, then it needs way more text explaining what it's trying to do...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160855305
##########
superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts:
##########
@@ -462,10 +462,10 @@ export function applyAdvancedTimeRangeFilterOnDashboard(
}
/** ************************************************************************
- * Input default valule in Native filter in filter settings
+ * Input default value in Native filter in filter settings
* @param defaultValue: default value for native filter
* @return {null}
- * @summary helper for input default valule in Native filter in filter settings
+ * @summary helper to input default value in Native filter in filter settings
Review Comment:
this is the `value` change i mentioned... and here i've changed `for` to `to`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160830952
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -595,7 +595,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
useLayoutEffect(() => {
// After initial load the table should resize only when the new sizes
- // Are not only scrollbar updates, otherwise, the table would twicth
+ // Are not only scrollbar updates, otherwise, the table would twitch
Review Comment:
Yep, it literally twitches/blinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on a diff in pull request #19648: chore: Spelling
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160839758
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -127,7 +127,7 @@ class App extends React.PureComponent {
) {
this.showLocalStorageUsageWarning(
this.props.localStorageUsageInKilobytes,
- this.props.queries?.lenghth || 0,
+ this.props.queries?.length || 0,
Review Comment:
This is one of the important reason for typescript!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #19648: chore: Spelling
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r848356852
##########
superset/views/base_api.py:
##########
@@ -66,7 +66,7 @@ class DistinctResultResponseSchema(Schema):
text = fields.String(description="The distinct item")
-class DistincResponseSchema(Schema):
+class DistinctResponseSchema(Schema):
Review Comment:
not a breaking change
##########
superset/viz.py:
##########
@@ -449,7 +449,7 @@ def cache_key(self, query_obj: QueryObjectDict, **extra: Any) -> str:
"5 days ago" or "now").
The `extra` arguments are currently used by time shift queries, since
- different time shifts wil differ only in the `from_dttm`, `to_dttm`,
+ different time shifts will differ only in the `from_dttm`, `to_dttm`,
Review Comment:
it is :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160822973
##########
docs/static/resources/openapi.json:
##########
@@ -2075,7 +2075,7 @@
"type": "string"
},
"query_context_generation": {
- "description": "The query context generation represents whether the query_contextis user generated or not so that it does not update user modfiedstate.",
+ "description": "The query context generation represents whether the query_contexts user generated or not so that it does not update user modifiedstate.",
Review Comment:
```suggestion
"description": "The query context generation represents whether the query_context is user generated or not so that it does not update user modified state.",
```
I think this is what the author was going for?
##########
docs/static/resources/openapi.json:
##########
@@ -2182,7 +2182,7 @@
"type": "string"
},
"query_context_generation": {
- "description": "The query context generation represents whether the query_contextis user generated or not so that it does not update user modfiedstate.",
+ "description": "The query context generation represents whether the query_contexts user generated or not so that it does not update user modifiedstate.",
Review Comment:
```suggestion
"description": "The query context generation represents whether the query_context is user generated or not so that it does not update user modified state.",
```
déjà vu!
##########
docs/static/resources/openapi.json:
##########
@@ -2883,7 +2883,7 @@
"type": "string"
},
"query_context_generation": {
- "description": "The query context generation represents whether the query_contextis user generated or not so that it does not update user modfiedstate.",
+ "description": "The query context generation represents whether the query_contexts user generated or not so that it does not update user modifiedstate.",
Review Comment:
```suggestion
"description": "The query context generation represents whether the query_context is user generated or not so that it does not update user modified state.",
```
"Was it the same black cat?"
— Morpheus
##########
docs/static/resources/openapi.json:
##########
@@ -17912,7 +17912,7 @@
"description": "Menu items in a forest like data structure",
"items": {
"properties": {
- "childs": {
+ "children": {
Review Comment:
Eek! Houston, we have a problem. @dpgaspar can correct me here, but I believe the underlying library (Flask Appbuilder) expects "childs" here, so this is correct implementation, by way of a typo in the base library. We might want to unwind these.
But again, this is passing CI... so... I'm not sure what's up with that.
##########
superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts:
##########
@@ -195,9 +195,9 @@ export function expandFilterOnLeftPanel() {
}
/** ************************************************************************
- * Collapes Native Filter from the left panel on dashboard
+ * Collapses Native Filter from the left panel on dashboard
* @returns {None}
- * @summary helper for collape native filter
+ * @summary helper for collapse native filter
Review Comment:
collapsing?
##########
docs/static/resources/openapi.json:
##########
@@ -17912,7 +17912,7 @@
"description": "Menu items in a forest like data structure",
"items": {
"properties": {
- "childs": {
+ "children": {
"items": {
"type": "object"
Review Comment:
These look scary, but I think you fixed the corresponding logic, so we're all good here.
##########
docs/static/resources/openapi.json:
##########
@@ -2990,7 +2990,7 @@
"type": "string"
},
"query_context_generation": {
- "description": "The query context generation represents whether the query_contextis user generated or not so that it does not update user modfiedstate.",
+ "description": "The query context generation represents whether the query_contexts user generated or not so that it does not update user modifiedstate.",
Review Comment:
I don't know how many more there are, but I'll stop correcting these :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160818821
##########
docs/docs/databases/sql-server.mdx:
##########
@@ -19,5 +19,5 @@ It is also possible to connect using [pyodbc](https://pypi.org/project/pyodbc) w
The connection string for SQL Server looks like this:
```
-mssql+pyodbc:///?odbc_connect=Driver%3D%7BODBC+Driver+17+for+SQL+Server%7D%3BServer%3Dtcp%3A%3Cmy_server%3E%2C1433%3BDatabase%3Dmy_datasbase%3BUid%3Dmy_user_name%3BPwd%3Dmy_password%3BEncrypt%3Dyes%3BConnection+Timeout%3D30
+mssql+pyodbc:///?odbc_connect=Driver%3D%7BODBC+Driver+17+for+SQL+Server%7D%3BServer%3Dtcp%3A%3Cmy_server%3E%2C1433%3BDatabase%3Dmy_database%3BUid%3Dmy_user_name%3BPwd%3Dmy_password%3BEncrypt%3Dyes%3BConnection+Timeout%3D30
Review Comment:
Agreed, but I _think_ this is harmless, as it looks like a trumped up example in a documentation file, so the string is intended to just be a placeholder anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r847405605
##########
superset/reports/schemas.py:
##########
@@ -84,7 +84,7 @@
"Superset nags you again. (in seconds)"
)
working_timeout_description = (
- "If an alert is staled at a working state, how long until it's state is reseted to"
+ "If an alert is staled at a working state, how long until its state is reset to"
Review Comment:
As noted earlier, I'm generally not dealing w/ grammar, I made this change to `it's` because I was going to make the change to `reset` and my tooling cares about order. I have not checked the rest of the repo for `it's`/`its`, but i'm sure there are plenty of instances where it's missued, misuse of its is fairly common everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #19648: chore: Spelling
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed pull request #19648: chore: Spelling
URL: https://github.com/apache/superset/pull/19648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19648: chore: Spelling
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #19648:
URL: https://github.com/apache/superset/pull/19648#issuecomment-1435927589
# [Codecov](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19648](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6ddc4b) into [master](https://codecov.io/gh/apache/superset/commit/f851e992cfcfd75786e236948c8678a013ff1265?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f851e99) will **decrease** coverage by `11.24%`.
> The diff coverage is `66.66%`.
> :exclamation: Current head e6ddc4b differs from pull request most recent head 642ba5e. Consider uploading reports for the commit 642ba5e to get more accurate results
```diff
@@ Coverage Diff @@
## master #19648 +/- ##
===========================================
- Coverage 67.54% 56.31% -11.24%
===========================================
Files 1881 1881
Lines 72396 72377 -19
Branches 7882 7873 -9
===========================================
- Hits 48902 40761 -8141
- Misses 21472 29597 +8125
+ Partials 2022 2019 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.67% <66.66%> (ø)` | |
| python | `58.93% <66.66%> (-23.34%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.53% <66.66%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ges/superset-ui-core/src/query/buildQueryObject.ts](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvYnVpbGRRdWVyeU9iamVjdC50cw==) | `100.00% <ø> (ø)` | |
| [...packages/superset-ui-core/src/query/types/Query.ts](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvUXVlcnkudHM=) | `100.00% <ø> (ø)` | |
| [...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdWktb3ZlcnJpZGVzL0V4dGVuc2lvbnNSZWdpc3RyeS50cw==) | `100.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <ø> (ø)` | |
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `52.27% <ø> (ø)` | |
| [...tend/plugins/plugin-chart-table/src/TableChart.tsx](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL1RhYmxlQ2hhcnQudHN4) | `46.66% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/App/index.jsx](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC9pbmRleC5qc3g=) | `82.60% <ø> (-0.73%)` | :arrow_down: |
| [...d/src/SqlLab/components/QueryAutoRefresh/index.tsx](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2gvaW5kZXgudHN4) | `58.62% <ø> (ø)` | |
| [...c/components/DeprecatedSelect/DeprecatedSelect.tsx](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVwcmVjYXRlZFNlbGVjdC9EZXByZWNhdGVkU2VsZWN0LnRzeA==) | `41.33% <ø> (ø)` | |
| [...rontend/src/components/MetadataBar/MetadataBar.tsx](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0YWRhdGFCYXIvTWV0YWRhdGFCYXIudHN4) | `98.18% <ø> (-0.04%)` | :arrow_down: |
| ... and [332 more](https://codecov.io/gh/apache/superset/pull/19648?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1111192967
##########
CONTRIBUTING.md:
##########
@@ -170,7 +170,7 @@ articles. See [Documentation](#documentation) for more details.
### Add Translations
If you are proficient in a non-English language, you can help translate
-text strings from Superset's UI. You can jump in to the existing
+text strings from Superset's UI. You can jump into the existing
Review Comment:
This is probably controversial...
##########
docs/docs/databases/sql-server.mdx:
##########
@@ -19,5 +19,5 @@ It is also possible to connect using [pyodbc](https://pypi.org/project/pyodbc) w
The connection string for SQL Server looks like this:
```
-mssql+pyodbc:///?odbc_connect=Driver%3D%7BODBC+Driver+17+for+SQL+Server%7D%3BServer%3Dtcp%3A%3Cmy_server%3E%2C1433%3BDatabase%3Dmy_datasbase%3BUid%3Dmy_user_name%3BPwd%3Dmy_password%3BEncrypt%3Dyes%3BConnection+Timeout%3D30
+mssql+pyodbc:///?odbc_connect=Driver%3D%7BODBC+Driver+17+for+SQL+Server%7D%3BServer%3Dtcp%3A%3Cmy_server%3E%2C1433%3BDatabase%3Dmy_database%3BUid%3Dmy_user_name%3BPwd%3Dmy_password%3BEncrypt%3Dyes%3BConnection+Timeout%3D30
Review Comment:
scary
##########
superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js:
##########
@@ -331,7 +331,7 @@ function Icicle(element, props) {
tooltip.interrupt().transition().duration(250).style('opacity', 0);
});
- // When clicking a subdivision, the vis will zoom in to it
+ // When clicking a subdivision, the vis will zoom into it
Review Comment:
potentially controversial
##########
RELEASING/changelog.py:
##########
@@ -24,7 +24,7 @@
from click.core import Context
try:
- from github import BadCredentialsException, Github, PullRequest, Repository
+ from github import BadCredentialsException, GitHub, PullRequest, Repository
Review Comment:
(I think I should re-drop this, but I've included it because it's too late in my day to be careful w/ such notes)
##########
superset/viz.py:
##########
@@ -2516,15 +2516,15 @@ def get_spatial_columns(self, key: str) -> List[str]:
return []
@staticmethod
- def parse_coordinates(latlog: Any) -> Optional[Tuple[float, float]]:
- if not latlog:
+ def parse_coordinates(latlong: Any) -> Optional[Tuple[float, float]]:
+ if not latlong:
Review Comment:
hopefully?
##########
superset/migrations/versions/2018-07-20_15-57_e9df189e5c7e_update_base_metrics.py:
##########
@@ -16,7 +16,7 @@
# under the License.
"""update base metrics
-Note that the metrics table was previously partially modifed by revision
+Note that the metrics table was previously partially modified by revision
f231d82b9b26.
Revision ID: e9df189e5c7e
Review Comment:
Comment to note a renamed file below
##########
RELEASING/release-notes-2-0/changelog.md:
##########
@@ -314,7 +314,7 @@ under the License.
- [#19166](https://github.com/apache/superset/pull/19166) fix: time filter should be [start, end) (@zhaoyongjie)
**Others**
-- [#20116](https://github.com/apache/superset/pull/20116) style(typo): occured -> occurred (@sfirke)
+- [#20116](https://github.com/apache/superset/pull/20116) style(typo): occurred -> occurred (@sfirke)
Review Comment:
Sigh, I'll drop this and add a pattern to try to guard against spotting it again
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -595,7 +595,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
useLayoutEffect(() => {
// After initial load the table should resize only when the new sizes
- // Are not only scrollbar updates, otherwise, the table would twicth
+ // Are not only scrollbar updates, otherwise, the table would twitch
Review Comment:
?
##########
superset/advanced_data_type/plugins/internet_address.py:
##########
@@ -1,10 +1,10 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
-# regarding coperatoryright ownership. The ASF licenses this file
+# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
-# with the License. You may obtain a coperatory of the License at
+# with the License. You may obtain a copy of the License at
Review Comment:
find-and-replace damage??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #19648: chore: Spelling
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r848351357
##########
docs/docs/installation/configuring-superset.mdx:
##########
@@ -99,7 +99,7 @@ If you're not using Gunicorn, you may want to disable the use of `flask-compress
If you are running superset behind a load balancer or reverse proxy (e.g. NGINX or ELB on AWS), you
may need to utilize a healthcheck endpoint so that your load balancer knows if your superset
instance is running. This is provided at `/health` which will return a 200 response containing “OK”
-if the the webserver is running.
+if the webserver is running.
Review Comment:
nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19648:
URL: https://github.com/apache/superset/pull/19648#issuecomment-1435382863
@jsoref now that the other ones have merged (hooray and thank you!) do you want to rebase this one and keep going, or shall we close it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160855611
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -94,7 +94,7 @@ describe('plugin-chart-table', () => {
<TableChart {...transformProps(testData.advanced)} sticky={false} />,
);
tree = wrap.render();
- // should successful rerender with new props
+ // should successfully rerender with new props
Review Comment:
I mentioned I'd do this a while ago and one of the comments caused my reminder to reappear, so I've done it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160846793
##########
superset/examples/configs/charts/Messages_per_Channel.yaml:
##########
@@ -50,7 +50,7 @@ params:
dashboards: '#3CCCCB'
design: '#1FA8C9'
developers: '#9EE5E5'
- embedd-dashboards: '#ACE1C4'
+ embedded-dashboards: '#ACE1C4'
Review Comment:
I concur!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19648:
URL: https://github.com/apache/superset/pull/19648#issuecomment-1499659412
I think the bulk of these changes were handled in your more granular PRs (thanks again for those). Should we rebase this one, or scrap it?
Clearly, we should follow up when time allows and add your tooling to our CI pipeline! SOOO MANY TYPOS!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on a diff in pull request #19648: chore: Spelling
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160838582
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -127,7 +127,7 @@ class App extends React.PureComponent {
) {
this.showLocalStorageUsageWarning(
this.props.localStorageUsageInKilobytes,
- this.props.queries?.lenghth || 0,
+ this.props.queries?.length || 0,
Review Comment:
This value is only used for logging, so it's not highly critical.. (Thanks for catching up. I found this issue when I queried the this new logging item first time)
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -127,7 +127,7 @@ class App extends React.PureComponent {
) {
this.showLocalStorageUsageWarning(
this.props.localStorageUsageInKilobytes,
- this.props.queries?.lenghth || 0,
+ this.props.queries?.length || 0,
Review Comment:
This value is only used for logging, so it's not highly critical. (Thanks for catching up. I found this issue when I queried the this new logging item first time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19648: chore: Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1161012627
##########
tests/integration_tests/core_tests.py:
##########
@@ -615,7 +615,7 @@ def test_cache_logging(self):
app.config["STORE_CACHE_KEYS_IN_METADATA_DB"] = store_cache_keys
def test_redirect_invalid(self):
- model_url = models.Url(url="hhttp://invalid.com")
+ model_url = models.Url(url="not-http://invalid.com")
Review Comment:
Well, there were two, and I guessed the same way for both. It seems it was a split decision...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160814388
##########
RELEASING/changelog.py:
##########
@@ -24,7 +24,7 @@
from click.core import Context
try:
- from github import BadCredentialsException, Github, PullRequest, Repository
+ from github import BadCredentialsException, GitHub, PullRequest, Repository
Review Comment:
Indeed, in this case, the imported library is actually `Github` so this could break things (even though CI is passing, so... ¯\\\_(ツ)_/¯)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19648: chore: Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19648:
URL: https://github.com/apache/superset/pull/19648#discussion_r1160814955
##########
RELEASING/changelog.py:
##########
@@ -24,7 +24,7 @@
from click.core import Context
try:
- from github import BadCredentialsException, Github, PullRequest, Repository
+ from github import BadCredentialsException, GitHub, PullRequest, Repository
Review Comment:
From the [docs](https://github.com/PyGithub/PyGithub):
<img width="348" alt="image" src="https://user-images.githubusercontent.com/812905/230643367-368c30ed-d8f3-4acb-96dc-27c3086effa3.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org