You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/27 22:01:52 UTC
[GitHub] [arrow] wesm opened a new pull request #7558: ARROW-9250: [C++] Instantiate fewer templates in IsIn, Match kernel implementations
wesm opened a new pull request #7558:
URL: https://github.com/apache/arrow/pull/7558
This yields a 150KB reduction in code for me on Linux.
Since this may become a common pattern (using e.g. a single `uint32_t`-based function to process both int32/uint32), some of this may be factored out to make writing such kernel implementations simpler in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7558: ARROW-9250: [C++] Instantiate fewer templates in IsIn, Match kernel implementations
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7558:
URL: https://github.com/apache/arrow/pull/7558#issuecomment-650771972
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7558: ARROW-9250: [C++] Instantiate fewer templates in IsIn, Match kernel implementations
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7558:
URL: https://github.com/apache/arrow/pull/7558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on a change in pull request #7558: ARROW-9250: [C++] Instantiate fewer templates in IsIn, Match kernel implementations
Posted by GitBox <gi...@apache.org>.
wesm commented on a change in pull request #7558:
URL: https://github.com/apache/arrow/pull/7558#discussion_r446571732
##########
File path: cpp/src/arrow/type.h
##########
@@ -900,7 +902,7 @@ class ARROW_EXPORT LargeStringType : public LargeBinaryType {
public:
static constexpr Type::type type_id = Type::LARGE_STRING;
static constexpr bool is_utf8 = true;
- using EquivalentBinaryType = LargeBinaryType;
+ using PhysicalType = LargeBinaryType;
Review comment:
These changes are for consistency with the `PhysicalType` attributes added to the CType-based types
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7558: ARROW-9250: [C++] Instantiate fewer templates in IsIn, Match kernel implementations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7558:
URL: https://github.com/apache/arrow/pull/7558#issuecomment-650637397
https://issues.apache.org/jira/browse/ARROW-9250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org