[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11305: fix: should update last_modified_time in client-side after save dash

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #11305:
URL: https://github.com/apache/incubator-superset/pull/11305#discussion_r506609576



##########
File path: superset-frontend/src/dashboard/components/HeaderActionsDropdown.jsx
##########
@@ -138,6 +139,7 @@ class HeaderActionsDropdown extends React.PureComponent {
       isLoading,
       refreshLimit,
       refreshWarning,
+      lastModifiedTime,

Review comment:
       yes. `dashboardInfo` is read only dashboard metadata. I will consider group other edit-able dashboard metadata into another object.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org