You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/05 12:16:59 UTC
[GitHub] [beam] iemejia commented on a change in pull request #11046:
[BEAM-9442] Properly handle nullable fields in Select
iemejia commented on a change in pull request #11046: [BEAM-9442] Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#discussion_r388257264
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
##########
@@ -256,6 +260,10 @@ public StackManipulation append(StackManipulation valueToWrite) {
return store(currentArrayField++, valueToWrite);
}
+ public int reserveSlot() {
Review comment:
nit: (slightly related to this PR) can we make `SelectByteBuddyHelpers` package private please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services