You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/26 16:07:34 UTC
[GitHub] [airflow] houqp commented on a change in pull request #5664:
[AIRFLOW-XXX] fix all missing type annotation errors from dmypy
houqp commented on a change in pull request #5664: [AIRFLOW-XXX] fix all missing type annotation errors from dmypy
URL: https://github.com/apache/airflow/pull/5664#discussion_r307810810
##########
File path: airflow/contrib/hooks/gcp_cloud_build_hook.py
##########
@@ -19,8 +19,8 @@
"""Hook for Google Cloud Build service"""
import time
-
-from googleapiclient.discovery import build
+from typing import Optional
+from googleapiclient.discovery import build, Resource
Review comment:
Sure, I will wait for your PR to be merged first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services