[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1062: Require redis-cli for testing

[GitBox <gi...@apache.org>]

PragmaTwice commented on code in PR #1062:
URL: https://github.com/apache/incubator-kvrocks/pull/1062#discussion_r1013746057


##########
x.py:
##########
@@ -266,6 +266,7 @@ def test_cpp(dir: str, rest: List[str]) -> None:
 
 def test_go(dir: str, rest: List[str]) -> None:
     go = find_command('go', msg='go is required for testing')
+    find_command('redis-cli', msg='redis-cli is required for testing')

Review Comment:
   ```suggestion
   def test_go(dir: str, cli_path: str, rest: List[str]) -> None:
       go = find_command('go', msg='go is required for testing')
       find_command(cli_path, msg='redis-cli is required for testing')
   ```
   
   To respect `cliPath` according to @tisonkun , you can follow these proposed changes:
   
   And add this line:
   ```
   parser_test_go.add_argument('--cli-path', default='redis-cli', help="path of redis-cli to test kvrocks")
   ```
   
   Append `cliPath` to `args`:
   ```
   args = [
           'test', '-bench=.', './...',
           f'-binPath={binpath}',
           f'-cliPath={cli_path}',
           f'-workspace={worksapce}',
           *rest
       ]
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org