You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/30 10:38:36 UTC
[GitHub] [dolphinscheduler] abzymeinsjtu opened a new pull request, #11703: [DOC] improve zk digest doc
abzymeinsjtu opened a new pull request, #11703:
URL: https://github.com/apache/dolphinscheduler/pull/11703
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
improve zookeeper digest configuration related doc
## Brief change log
explain zookeeper digest configuration and add link to Apache Zookeeper acl doc
## Verify this pull request
This pull request is code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 merged pull request #11703: [DOC] improve zk digest doc
Posted by GitBox <gi...@apache.org>.
EricGao888 merged PR #11703:
URL: https://github.com/apache/dolphinscheduler/pull/11703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11703: [DOC] improve zk digest doc
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11703:
URL: https://github.com/apache/dolphinscheduler/pull/11703#discussion_r958351742
##########
docs/docs/en/architecture/configuration.md:
##########
@@ -173,7 +173,7 @@ The default configuration is as follows:
|registry.zookeeper.session-timeout|30s|session timeout|
|registry.zookeeper.connection-timeout|30s|connection timeout|
|registry.zookeeper.block-until-connected|600ms|waiting time to block until the connection succeeds|
-|registry.zookeeper.digest|~|digest of zookeeper|
+|registry.zookeeper.digest|{username}:{password}|digest of zookeeper to access znode, works only when acl is enabled, for more details plz check [https://zookeeper.apache.org/doc/r3.4.14/zookeeperAdmin.html](Apache Zookeeper doc) |
Review Comment:
```suggestion
|registry.zookeeper.digest|{username}:{password}|digest of zookeeper to access znode, works only when acl is enabled, for more details please check [https://zookeeper.apache.org/doc/r3.4.14/zookeeperAdmin.html](Apache Zookeeper doc) |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11703: [DOC] improve zk digest doc
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11703:
URL: https://github.com/apache/dolphinscheduler/pull/11703#issuecomment-1231531372
BTW you could add `closes: #11187` in the description of your PR to link it to the related issue automatically. The issue will get closed as soon as your PR merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org