You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/05/21 22:54:35 UTC

Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2762
    https://issues.apache.org/jira/browse/MESOS-2762


Repository: mesos


Description
-------

Allowed explicitly-defaulted functions in styleguide.


Diffs
-----

  docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 

Diff: https://reviews.apache.org/r/34565/diff/


Testing
-------


Thanks,

Joerg Schad

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/#review84877
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rojas


On May 21, 2015, 10:54 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34565/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 10:54 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2762
>     https://issues.apache.org/jira/browse/MESOS-2762
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed explicitly-defaulted functions in styleguide.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 
> 
> Diff: https://reviews.apache.org/r/34565/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/#review86182
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On May 21, 2015, 8:54 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34565/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2762
>     https://issues.apache.org/jira/browse/MESOS-2762
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed explicitly-defaulted functions in styleguide.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 
> 
> Diff: https://reviews.apache.org/r/34565/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/#review84801
-----------------------------------------------------------


Patch looks great!

Reviews applied: [34565]

All tests passed.

- Mesos ReviewBot


On May 21, 2015, 8:54 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34565/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2762
>     https://issues.apache.org/jira/browse/MESOS-2762
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed explicitly-defaulted functions in styleguide.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 
> 
> Diff: https://reviews.apache.org/r/34565/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/#review84797
-----------------------------------------------------------


Left a comment in the JIRA about possibly calling out some patterns for this.

- Joris Van Remoortere


On May 21, 2015, 8:54 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34565/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2762
>     https://issues.apache.org/jira/browse/MESOS-2762
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed explicitly-defaulted functions in styleguide.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 
> 
> Diff: https://reviews.apache.org/r/34565/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/#review86179
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On May 21, 2015, 8:54 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34565/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2762
>     https://issues.apache.org/jira/browse/MESOS-2762
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed explicitly-defaulted functions in styleguide.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 
> 
> Diff: https://reviews.apache.org/r/34565/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34565/
-----------------------------------------------------------

(Updated June 2, 2015, 9:59 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Rebased.


Bugs: MESOS-2762
    https://issues.apache.org/jira/browse/MESOS-2762


Repository: mesos


Description
-------

Allowed explicitly-defaulted functions in styleguide.


Diffs (updated)
-----

  docs/mesos-c++-style-guide.md cb45beb98527daa338a98e8a8b6a30730f881c43 

Diff: https://reviews.apache.org/r/34565/diff/


Testing
-------


Thanks,

Joerg Schad