You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "chrisdutz (via GitHub)" <gi...@apache.org> on 2023/09/05 09:27:31 UTC

[GitHub] [iotdb] chrisdutz opened a new pull request, #11043: Fix/grafana plugin error

chrisdutz opened a new pull request, #11043:
URL: https://github.com/apache/iotdb/pull/11043

   resolves #11042
   
   Turns out that on some systems the GOROOT variable wrapps the path in double quotes, but some newer systems these are wrapped by single quotes. So I added a second sed-replace that simply strips the variable of all single quotes.
   
   Besides that I told the tasks in the maven-antrun-plugin configuration to fail the build, if the execution fails, this way we shouldn't miss issues like this in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou merged pull request #11043: Fix/grafana plugin error

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #11043:
URL: https://github.com/apache/iotdb/pull/11043


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org