You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jung JaeHwa <jh...@gruter.com> on 2014/01/28 12:07:23 UTC
Review Request 17453: TAJO-558: HCatalogStore can't scan columns.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17453/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-558
https://issues.apache.org/jira/browse/TAJO-558
Repository: tajo
Description
-------
If we write partitioned columns at where clause on tsql, tajo print a error message as follows:
{code:xml}
tajo> select * from table1 where id = 1;
ERROR: no such a column name default
{code}
For reference, hive table schema is as the following:
{code:xml}
CREATE TABLE table1(
id int,
name string,
score float,
type string);
{code}
It occurred on both managed tables and partitioned tables.
Diffs
-----
tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnReferenceExpr.java 9734593
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java c971b63
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java ab20f42
Diff: https://reviews.apache.org/r/17453/diff/
Testing
-------
Thanks,
Jung JaeHwa
Re: Review Request 17453: TAJO-558: HCatalogStore can't scan columns.
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17453/#review32979
-----------------------------------------------------------
Ship it!
+1
The patch looks good for me. After you remove LogFactory line in ColumnReferenceExpr, please commit it.
tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnReferenceExpr.java
<https://reviews.apache.org/r/17453/#comment62118>
It looks unnecessary. Please remove it.
- Hyunsik Choi
On Jan. 28, 2014, 8:07 p.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17453/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 8:07 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-558
> https://issues.apache.org/jira/browse/TAJO-558
>
>
> Repository: tajo
>
>
> Description
> -------
>
> If we write partitioned columns at where clause on tsql, tajo print a error message as follows:
> {code:xml}
> tajo> select * from table1 where id = 1;
> ERROR: no such a column name default
> {code}
>
> For reference, hive table schema is as the following:
> {code:xml}
> CREATE TABLE table1(
> id int,
> name string,
> score float,
> type string);
> {code}
>
> It occurred on both managed tables and partitioned tables.
>
>
> Diffs
> -----
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnReferenceExpr.java 9734593
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java c971b63
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java ab20f42
>
> Diff: https://reviews.apache.org/r/17453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jung JaeHwa
>
>
Re: Review Request 17453: TAJO-558: HCatalogStore can't scan columns.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17453/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 11:41 a.m.)
Review request for Tajo.
Bugs: TAJO-558
https://issues.apache.org/jira/browse/TAJO-558
Repository: tajo
Description
-------
If we write partitioned columns at where clause on tsql, tajo print a error message as follows:
{code:xml}
tajo> select * from table1 where id = 1;
ERROR: no such a column name default
{code}
For reference, hive table schema is as the following:
{code:xml}
CREATE TABLE table1(
id int,
name string,
score float,
type string);
{code}
It occurred on both managed tables and partitioned tables.
Diffs (updated)
-----
tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnReferenceExpr.java 9734593
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java c971b63
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java ab20f42
Diff: https://reviews.apache.org/r/17453/diff/
Testing
-------
Thanks,
Jung JaeHwa