You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/12/21 00:26:40 UTC
[GitHub] [incubator-gobblin] Will-Lo opened a new pull request #2855:
[GOBBLIN-1010] Adds flags to use cgroup memory for heap space available for
Gobblin images
Will-Lo opened a new pull request #2855: [GOBBLIN-1010] Adds flags to use cgroup memory for heap space available for Gobblin images
URL: https://github.com/apache/incubator-gobblin/pull/2855
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1010
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Currently Gobblin's memory usage is defined as arguments passed to its processes.
In a containerized environment (i.e. Kubernetes), it is more accurate and usable if the process can just utilize the available memory in its container.
This option is described in this article https://blog.softwaremill.com/docker-support-in-new-java-8-finally-fd595df0ca54
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2855:
[GOBBLIN-1010] Adds flags to use cgroup memory for heap space available for
Gobblin images
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2855: [GOBBLIN-1010] Adds flags to use cgroup memory for heap space available for Gobblin images
URL: https://github.com/apache/incubator-gobblin/pull/2855#issuecomment-568648817
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2855?src=pr&el=h1) Report
> Merging [#2855](https://codecov.io/gh/apache/incubator-gobblin/pull/2855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/dfef88e5a820f4153dfcacba4e8b5c4d463d31bf?src=pr&el=desc) will **increase** coverage by `0.1%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2855 +/- ##
===========================================
+ Coverage 45.5% 45.61% +0.1%
- Complexity 8998 9051 +53
===========================================
Files 1905 1909 +4
Lines 71612 71766 +154
Branches 7901 7918 +17
===========================================
+ Hits 32587 32735 +148
Misses 36020 36020
- Partials 3005 3011 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2855?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `35.51% <0%> (-3.74%)` | `12% <0%> (-1%)` | |
| [...ompaction/verify/CompactionAuditCountVerifier.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0NvbXBhY3Rpb25BdWRpdENvdW50VmVyaWZpZXIuamF2YQ==) | `79.03% <0%> (-0.97%)` | `13% <0%> (ø)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | |
| [.../gobblin/compaction/suite/CompactionSuiteBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZS5qYXZh) | `100% <0%> (ø)` | `10% <0%> (+2%)` | :arrow_up: |
| [...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...gement/copy/TimeAwareRecursiveCopyableDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvVGltZUF3YXJlUmVjdXJzaXZlQ29weWFibGVEYXRhc2V0LmphdmE=) | `91.17% <0%> (ø)` | `15% <0%> (ø)` | :arrow_down: |
| [...ta/management/dataset/TimePartitionGlobFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvVGltZVBhcnRpdGlvbkdsb2JGaW5kZXIuamF2YQ==) | `93.4% <0%> (ø)` | `23% <0%> (?)` | |
| [.../org/apache/gobblin/dataset/FileSystemDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9GaWxlU3lzdGVtRGF0YXNldC5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...ta/management/dataset/SimpleFileSystemDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvU2ltcGxlRmlsZVN5c3RlbURhdGFzZXQuamF2YQ==) | `88.88% <0%> (ø)` | `4% <0%> (?)` | |
| [...ain/java/org/apache/gobblin/time/TimeIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGltZS9UaW1lSXRlcmF0b3IuamF2YQ==) | `73.07% <0%> (ø)` | `12% <0%> (?)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2855?src=pr&el=footer). Last update [dfef88e...4c113f4](https://codecov.io/gh/apache/incubator-gobblin/pull/2855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] Will-Lo closed pull request #2855: [GOBBLIN-1010] Adds flags to use cgroup memory for heap space available for Gobblin images
Posted by GitBox <gi...@apache.org>.
Will-Lo closed pull request #2855:
URL: https://github.com/apache/incubator-gobblin/pull/2855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] Will-Lo closed pull request #2855: [GOBBLIN-1010] Adds flags to use cgroup memory for heap space available for Gobblin images
Posted by GitBox <gi...@apache.org>.
Will-Lo closed pull request #2855:
URL: https://github.com/apache/incubator-gobblin/pull/2855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org